10693972114

Committed 04 Sep 2024 02:22AM UTC coverage: 31.913% (+0.04%) from 31.878%

Build # 10693972114

Build Type

Pull #9704

github

Committed by

ben-pace

Commit Message

pr fixes

Pull Request Pull Request #9704: Curation Page

Run Details

5027 of 41142 branches covered (12.22%)

Branch coverage included in aggregate %.

58 of 94 new or added lines in 15 files covered. (61.7%)

879 existing lines in 27 files now uncovered.

29391 of 66709 relevant lines covered (44.06%)

188.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

11.21

/packages/lesswrong/lib/editor/ellipsize.tsx

import { truncatise } from '../truncatise';

const highlightMaxChars = 2400;
export const GTP2_TRUNCATION_CHAR_COUNT = 400;
export const SMALL_TRUNCATION_CHAR_COUNT = 750;
export const LARGE_TRUNCATION_CHAR_COUNT = 1600;
export const TRUNCATION_KARMA_THRESHOLD = 10

export const highlightFromHTML = (html: string | null): string => {
  if (!html) return ""
  const styles: string[]|null = html.match(/<style[\s\S]*?<\/style>/g);
  const htmlWithoutStyles = styles ? html.replace(/<style[\s\S]*?<\/style>/g, '') : html;
  const suffix = styles ? `... ${styles}` : '... ';

  return truncatise(htmlWithoutStyles, {
    TruncateLength: highlightMaxChars,
    TruncateBy: "characters",
    Suffix: suffix,
  });
};

export const truncate = (
  html: string|null|undefined,
  truncateLength: number,
  truncateBy?: "words" | "characters" | "paragraphs",
  suffix?: string,
  allowTruncationMidWord = true,
) => {
  const newTruncateBy = truncateBy || "characters"
  const newSuffix = (suffix !== undefined) ? suffix : "..."

  if(!html) return ""
  const styles = html.match(/<style[\s\S]*?<\/style>/g) || ""
  const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');

  const truncatedHtml = truncatise(htmlRemovedStyles, {
    TruncateLength: Math.floor(truncateLength - (truncateLength/4)) || truncateLength,
    TruncateBy: newTruncateBy,
    Suffix: `${newSuffix}`,
    Strict: allowTruncationMidWord,
  });
  return styles + truncatedHtml;
}

export const truncateWithGrace = (html: string, maxLengthWords: number, graceWords: number, rawWordCount: number, suffix?: string): {
  truncatedHtml: string,
  wasTruncated: boolean,
  wordsLeft: number,
} => {
  const truncatedHtml = truncate(html, maxLengthWords, "words", suffix);
  const wordsLeft = (truncatedHtml===html) ? 0 : rawWordCount-maxLengthWords;
  
  if (truncatedHtml === html || wordsLeft<graceWords) {
    return {
      truncatedHtml: html,
      wasTruncated: false,
      wordsLeft: 0,
    };
  }
  
  return {
    truncatedHtml, wordsLeft,
    wasTruncated: true,
  };
}

export function getTruncationCharCount (comment: CommentsList, currentUser?: UsersCurrent|null, postPage?: boolean) {
  // Do not truncate for users who have disabled it in their user settings. Might want to do someting more elegant here someday.
  if (currentUser && currentUser.noCollapseCommentsPosts && postPage) {
    return 10000000
  }
  if (currentUser && currentUser.noCollapseCommentsFrontpage && !postPage) {
    return 10000000
  }
  const commentIsByGPT2 = !!(comment && comment.user && comment.user.displayName === "GPT2")
  if (commentIsByGPT2) return GTP2_TRUNCATION_CHAR_COUNT

  const commentIsRecent = comment.postedAt > new Date(new Date().getTime()-(2*24*60*60*1000)); // past 2 days
  const commentIsHighKarma = comment.baseScore >= TRUNCATION_KARMA_THRESHOLD
  
  if (postPage) {
    return (commentIsRecent || commentIsHighKarma) ? LARGE_TRUNCATION_CHAR_COUNT : SMALL_TRUNCATION_CHAR_COUNT
  } else {
    return SMALL_TRUNCATION_CHAR_COUNT
  }
}

export const answerTocExcerptFromHTML = (html: string): string => {
  if(!html) return ""
  const styles = html.match(/<style[\s\S]*?<\/style>/g) || ""
  const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');

  const firstParagraph = truncatise(htmlRemovedStyles, {
    TruncateLength: 1,
    TruncateBy: "paragraphs",
    Suffix: '',
  });

  return truncatise(firstParagraph, {
    TruncateLength: 70,
    TruncateBy: "characters",
    Suffix: `...${styles}`,
  });
};

export function commentExcerptFromHTML (comment: CommentsList, currentUser?: UsersCurrent|null, postPage?: boolean) {
  const html = comment.contents?.html;
  if(!html) return ""
  const styles = html.match(/<style[\s\S]*?<\/style>/g) || ""
  const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');

  const truncationCharCount = getTruncationCharCount(comment, currentUser, postPage)

  if (htmlRemovedStyles.length > truncationCharCount) {
    return truncatise(htmlRemovedStyles, {
      // We want the amount comments get truncated to to be less than the threshold at which they are truncated, so that users don't have the experience of expanding a comment only to see a couple more words (which just feels silly).
  
      // This varies by the size of the comment or truncation amount, and reducing it by 1/4th seems about right.
      TruncateLength: Math.floor(truncationCharCount - (truncationCharCount/4)),
      TruncateBy: "characters",
      Suffix: `... <span class="read-more-button">(read more)</span>${styles}`,
    });
  } else {
    return htmlRemovedStyles
  }
};


1	import { truncatise } from '../truncatise';	68✔
2
3	const highlightMaxChars = 2400;	22✔
4	export const GTP2_TRUNCATION_CHAR_COUNT = 400;	22✔
5	export const SMALL_TRUNCATION_CHAR_COUNT = 750;	22✔
6	export const LARGE_TRUNCATION_CHAR_COUNT = 1600;	22✔
7	export const TRUNCATION_KARMA_THRESHOLD = 10	22✔
8
9	export const highlightFromHTML = (html: string \| null): string => {	22✔
10	if (!html) return ""	2!
UNCOV 11	const styles: string[]\|null = html.match(/<style[\s\S]*?<\/style>/g);	×
UNCOV 12	const htmlWithoutStyles = styles ? html.replace(/<style[\s\S]*?<\/style>/g, '') : html;	×
UNCOV 13	const suffix = styles ? `... ${styles}` : '... ';	×
14
UNCOV 15	return truncatise(htmlWithoutStyles, {	×
16	TruncateLength: highlightMaxChars,
17	TruncateBy: "characters",
18	Suffix: suffix,
19	});
20	};
21
22	export const truncate = (	22✔
23	html: string\|null\|undefined,
24	truncateLength: number,
25	truncateBy?: "words" \| "characters" \| "paragraphs",
26	suffix?: string,
27	allowTruncationMidWord = true,	×
28	) => {
UNCOV 29	const newTruncateBy = truncateBy \|\| "characters"	×
UNCOV 30	const newSuffix = (suffix !== undefined) ? suffix : "..."	×
31
UNCOV 32	if(!html) return ""	×
UNCOV 33	const styles = html.match(/<style[\s\S]*?<\/style>/g) \|\| ""	×
UNCOV 34	const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');	×
35
UNCOV 36	const truncatedHtml = truncatise(htmlRemovedStyles, {	×
37	TruncateLength: Math.floor(truncateLength - (truncateLength/4)) \|\| truncateLength,	×
38	TruncateBy: newTruncateBy,
39	Suffix: `${newSuffix}`,
40	Strict: allowTruncationMidWord,
41	});
UNCOV 42	return styles + truncatedHtml;	×
43	}
44
45	export const truncateWithGrace = (html: string, maxLengthWords: number, graceWords: number, rawWordCount: number, suffix?: string): {	22✔
46	truncatedHtml: string,
47	wasTruncated: boolean,
48	wordsLeft: number,
49	} => {
50	const truncatedHtml = truncate(html, maxLengthWords, "words", suffix);	×
51	const wordsLeft = (truncatedHtml===html) ? 0 : rawWordCount-maxLengthWords;	×
52
53	if (truncatedHtml === html \|\| wordsLeft<graceWords) {	×
54	return {	×
55	truncatedHtml: html,
56	wasTruncated: false,
57	wordsLeft: 0,
58	};
59	}
60
61	return {	×
62	truncatedHtml, wordsLeft,
63	wasTruncated: true,
64	};
65	}
66
67	export function getTruncationCharCount (comment: CommentsList, currentUser?: UsersCurrent\|null, postPage?: boolean) {
68	// Do not truncate for users who have disabled it in their user settings. Might want to do someting more elegant here someday.
69	if (currentUser && currentUser.noCollapseCommentsPosts && postPage) {	×
70	return 10000000	×
71	}
72	if (currentUser && currentUser.noCollapseCommentsFrontpage && !postPage) {	×
73	return 10000000	×
74	}
75	const commentIsByGPT2 = !!(comment && comment.user && comment.user.displayName === "GPT2")	×
76	if (commentIsByGPT2) return GTP2_TRUNCATION_CHAR_COUNT	×
77
78	const commentIsRecent = comment.postedAt > new Date(new Date().getTime()-(22460601000)); // past 2 days	×
79	const commentIsHighKarma = comment.baseScore >= TRUNCATION_KARMA_THRESHOLD	×
80
81	if (postPage) {	×
82	return (commentIsRecent \|\| commentIsHighKarma) ? LARGE_TRUNCATION_CHAR_COUNT : SMALL_TRUNCATION_CHAR_COUNT	×
83	} else {
84	return SMALL_TRUNCATION_CHAR_COUNT	×
85	}
86	}
87
88	export const answerTocExcerptFromHTML = (html: string): string => {	22✔
89	if(!html) return ""	×
90	const styles = html.match(/<style[\s\S]*?<\/style>/g) \|\| ""	×
91	const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');	×
92
93	const firstParagraph = truncatise(htmlRemovedStyles, {	×
94	TruncateLength: 1,
95	TruncateBy: "paragraphs",
96	Suffix: '',
97	});
98
99	return truncatise(firstParagraph, {	×
100	TruncateLength: 70,
101	TruncateBy: "characters",
102	Suffix: `...${styles}`,
103	});
104	};
105
106	export function commentExcerptFromHTML (comment: CommentsList, currentUser?: UsersCurrent\|null, postPage?: boolean) {
107	const html = comment.contents?.html;	×
108	if(!html) return ""	×
109	const styles = html.match(/<style[\s\S]*?<\/style>/g) \|\| ""	×
110	const htmlRemovedStyles = html.replace(/<style[\s\S]*?<\/style>/g, '');	×
111
112	const truncationCharCount = getTruncationCharCount(comment, currentUser, postPage)	×
113
114	if (htmlRemovedStyles.length > truncationCharCount) {	×
115	return truncatise(htmlRemovedStyles, {	×
116	// We want the amount comments get truncated to to be less than the threshold at which they are truncated, so that users don't have the experience of expanding a comment only to see a couple more words (which just feels silly).
117
118	// This varies by the size of the comment or truncation amount, and reducing it by 1/4th seems about right.
119	TruncateLength: Math.floor(truncationCharCount - (truncationCharCount/4)),
120	TruncateBy: "characters",
121	Suffix: `... <span class="read-more-button">(read more)</span>${styles}`,
122	});
123	} else {
124	return htmlRemovedStyles	×
125	}
126	};
127

ForumMagnum / ForumMagnum / 10693972114

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous