10685937883

Committed 03 Sep 2024 03:25PM UTC coverage: 31.874% (+0.04%) from 31.837%

Build # 10685937883

Build Type

Pull #9698

github

Committed by

web-flow

Commit Message

Merge 2d0aa7787 into a6ff63a86

Pull Request Pull Request #9698: Merge master into lw-deploy

Run Details

5071 of 41240 branches covered (12.3%)

Branch coverage included in aggregate %.

23 of 77 new or added lines in 11 files covered. (29.87%)

42 existing lines in 36 files now uncovered.

29374 of 66826 relevant lines covered (43.96%)

185.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.22

/packages/lesswrong/server/repos/PostRecommendationsRepo.ts

import AbstractRepo from "./AbstractRepo";
import PostRecommendations from "../../lib/collections/postRecommendations/collection";
import { randomId } from "../../lib/random";
import type {
  RecommendationStrategyName,
  StrategySettings,
} from "../../lib/collections/users/recommendationSettings";
import { recordPerfMetrics } from "./perfMetricWrapper";

class PostRecommendationsRepo extends AbstractRepo<"PostRecommendations"> {
  constructor() {
    super(PostRecommendations);
  }

  async recordRecommendations(
    currentUser: DbUser|null,
    clientId: string|null,
    strategyName: RecommendationStrategyName,
    strategySettings: StrategySettings,
    posts: DbPost[],
  ): Promise<void> {
    const userId = currentUser?._id;
    if (userId) {
      clientId = null;
    } else if (!clientId) {
      return;
    }
    const settings = strategySettings as unknown as JsonRecord;
    await Promise.all(posts.map(({_id: postId}) => this.none(`
      -- PostRecommendationsRepo.recordRecommendations
      INSERT INTO "PostRecommendations" (
        "_id",
        "userId",
        "clientId",
        "postId",
        "strategyName",
        "strategySettings",
        "recommendationCount",
        "lastRecommendedAt",
        "createdAt"
      ) VALUES (
        $1, $2, $3, $4, $5, $6, 0, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP
      ) ON CONFLICT (
        COALESCE("userId", ''),
        COALESCE("clientId", ''),
        "postId"
      ) DO UPDATE SET
        "strategyName" = $5,
        "strategySettings" = $6,
        "lastRecommendedAt" = CURRENT_TIMESTAMP
    `, [randomId(), userId, clientId, postId, strategyName, settings])));
  }

  async markRecommendationAsObserved(
    userId: string | null,
    clientId: string | null,
    postId: string,
  ): Promise<void> {
    if (userId) {
      await this.none(`
        -- PostRecommendationsRepo.markRecommendationAsObserved
        UPDATE "PostRecommendations"
        SET "recommendationCount" = "recommendationCount" + 1
        WHERE "userId" = $1 AND "postId" = $2
      `, [userId, postId]);
    } else if (clientId) {
      await this.none(`
        -- PostRecommendationsRepo.markRecommendationAsObserved
        UPDATE "PostRecommendations"
        SET "recommendationCount" = "recommendationCount" + 1
        WHERE "clientId" = $1 AND "postId" = $2
      `, [clientId, postId]);
    }
  }

  async markRecommendationAsClicked(
    userId: string | null,
    clientId: string | null,
    postId: string,
  ): Promise<void> {
    if (userId) {
      await this.none(`
        -- PostRecommendationsRepo.markRecommendationAsClicked
        UPDATE "PostRecommendations"
        SET "clickedAt" = CURRENT_TIMESTAMP
        WHERE "userId" = $1 AND "postId" = $2
      `, [userId, postId]);
    } else if (clientId) {
      await this.none(`
        -- PostRecommendationsRepo.markRecommendationAsClicked
        UPDATE "PostRecommendations"
        SET "clickedAt" = CURRENT_TIMESTAMP
        WHERE "clientId" = $1 AND "postId" = $2
      `, [clientId, postId]);
    }
  }

  async clearStaleRecommendations(): Promise<void> {
    // Delete all recommedations that are at least 1 day old and that
    // never appeared above the fold
    await this.none(`
      -- PostRecommendationsRepo.clearStaleRecommendations
      DELETE
      FROM "PostRecommendations"
      WHERE
        "recommendationCount" < 1 AND
        (CURRENT_TIMESTAMP - "createdAt") > '1 day'
    `);
    // Delete all recommendations that were never clicked that were last
    // recommended at least 3 months ago
    // This is currently disabled as it will ruin the analytics - if we
    // want to enable this is the future then we should probably move
    // the data into a separate "archive" table instead of completely
    // deleting it.
    /*
    await this.none(`
      -- PostRecommendationsRepo.clearStaleRecommendations
      DELETE
      FROM "PostRecommendations"
      WHERE
        "clickedAt" IS NULL AND
        (CURRENT_TIMESTAMP - "createdAt") > '3 months'
    `);
    */
  }
}

recordPerfMetrics(PostRecommendationsRepo);

export default PostRecommendationsRepo;

1	import AbstractRepo from "./AbstractRepo";	84✔
2	import PostRecommendations from "../../lib/collections/postRecommendations/collection";	21✔
3	import { randomId } from "../../lib/random";	21✔
4	import type {
5	RecommendationStrategyName,
6	StrategySettings,
7	} from "../../lib/collections/users/recommendationSettings";
8	import { recordPerfMetrics } from "./perfMetricWrapper";	21✔
9
10	class PostRecommendationsRepo extends AbstractRepo<"PostRecommendations"> {
11	constructor() {
UNCOV 12	super(PostRecommendations);	×
13	}
14
15	async recordRecommendations(
16	currentUser: DbUser\|null,
17	clientId: string\|null,
18	strategyName: RecommendationStrategyName,
19	strategySettings: StrategySettings,
20	posts: DbPost[],
21	): Promise<void> {
22	const userId = currentUser?._id;	×
23	if (userId) {	×
24	clientId = null;	×
25	} else if (!clientId) {	×
26	return;	×
27	}
28	const settings = strategySettings as unknown as JsonRecord;	×
29	await Promise.all(posts.map(({_id: postId}) => this.none(`	×
30	-- PostRecommendationsRepo.recordRecommendations
31	INSERT INTO "PostRecommendations" (
32	"_id",
33	"userId",
34	"clientId",
35	"postId",
36	"strategyName",
37	"strategySettings",
38	"recommendationCount",
39	"lastRecommendedAt",
40	"createdAt"
41	) VALUES (
42	$1, $2, $3, $4, $5, $6, 0, CURRENT_TIMESTAMP, CURRENT_TIMESTAMP
43	) ON CONFLICT (
44	COALESCE("userId", ''),
45	COALESCE("clientId", ''),
46	"postId"
47	) DO UPDATE SET
48	"strategyName" = $5,
49	"strategySettings" = $6,
50	"lastRecommendedAt" = CURRENT_TIMESTAMP
51	`, [randomId(), userId, clientId, postId, strategyName, settings])));
52	}
53
54	async markRecommendationAsObserved(
55	userId: string \| null,
56	clientId: string \| null,
57	postId: string,
58	): Promise<void> {
59	if (userId) {	×
60	await this.none(`	×
61	-- PostRecommendationsRepo.markRecommendationAsObserved
62	UPDATE "PostRecommendations"
63	SET "recommendationCount" = "recommendationCount" + 1
64	WHERE "userId" = $1 AND "postId" = $2
65	`, [userId, postId]);
66	} else if (clientId) {	×
67	await this.none(`	×
68	-- PostRecommendationsRepo.markRecommendationAsObserved
69	UPDATE "PostRecommendations"
70	SET "recommendationCount" = "recommendationCount" + 1
71	WHERE "clientId" = $1 AND "postId" = $2
72	`, [clientId, postId]);
73	}
74	}
75
76	async markRecommendationAsClicked(
77	userId: string \| null,
78	clientId: string \| null,
79	postId: string,
80	): Promise<void> {
81	if (userId) {	×
82	await this.none(`	×
83	-- PostRecommendationsRepo.markRecommendationAsClicked
84	UPDATE "PostRecommendations"
85	SET "clickedAt" = CURRENT_TIMESTAMP
86	WHERE "userId" = $1 AND "postId" = $2
87	`, [userId, postId]);
88	} else if (clientId) {	×
89	await this.none(`	×
90	-- PostRecommendationsRepo.markRecommendationAsClicked
91	UPDATE "PostRecommendations"
92	SET "clickedAt" = CURRENT_TIMESTAMP
93	WHERE "clientId" = $1 AND "postId" = $2
94	`, [clientId, postId]);
95	}
96	}
97
98	async clearStaleRecommendations(): Promise<void> {
99	// Delete all recommedations that are at least 1 day old and that
100	// never appeared above the fold
101	await this.none(`	×
102	-- PostRecommendationsRepo.clearStaleRecommendations
103	DELETE
104	FROM "PostRecommendations"
105	WHERE
106	"recommendationCount" < 1 AND
107	(CURRENT_TIMESTAMP - "createdAt") > '1 day'
108	`);
109	// Delete all recommendations that were never clicked that were last
110	// recommended at least 3 months ago
111	// This is currently disabled as it will ruin the analytics - if we
112	// want to enable this is the future then we should probably move
113	// the data into a separate "archive" table instead of completely
114	// deleting it.
115	/*
116	await this.none(`
117	-- PostRecommendationsRepo.clearStaleRecommendations
118	DELETE
119	FROM "PostRecommendations"
120	WHERE
121	"clickedAt" IS NULL AND
122	(CURRENT_TIMESTAMP - "createdAt") > '3 months'
123	`);
124	*/
125	}
126	}	21✔
127
128	recordPerfMetrics(PostRecommendationsRepo);
129
130	export default PostRecommendationsRepo;	21✔

ForumMagnum / ForumMagnum / 10685937883

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous