10657650892

Committed 01 Sep 2024 09:58PM UTC coverage: 82.662% (-0.009%) from 82.671%

Build # 10657650892

Build Type

Pull #353

github

Committed by

web-flow

Commit Message

Merge fe0c8d1d7 into e7cfda55c

Pull Request Pull Request #353: Refactored code in src/notifications.js to reduce its Cognitive Complexity

Run Details

9963 of 13474 branches covered (73.94%)

Branch coverage included in aggregate %.

4 of 6 new or added lines in 1 file covered. (66.67%)

2 existing lines in 2 files now uncovered.

22324 of 25585 relevant lines covered (87.25%)

1632.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.74

/src/meta/errors.js

'use strict';

const winston = require('winston');
const validator = require('validator');
const cronJob = require('cron').CronJob;

const db = require('../database');
const analytics = require('../analytics');

const Errors = module.exports;

let counters = {};

new cronJob('0 * * * * *', (() => {
        Errors.writeData();
}), null, true);

Errors.writeData = async function () {
        try {
                const _counters = { ...counters };
                counters = {};
                const keys = Object.keys(_counters);
                if (!keys.length) {
                        return;
                }

                for (const key of keys) {
                        /* eslint-disable no-await-in-loop */
                        await db.sortedSetIncrBy('errors:404', _counters[key], key);
                }
        } catch (err) {
                winston.error(err.stack);
        }
};

Errors.log404 = function (route) {
        if (!route) {
                return;
        }
        route = route.slice(0, 512).replace(/\/$/, ''); // remove trailing slashes
        analytics.increment('errors:404');
        counters[route] = counters[route] || 0;
        counters[route] += 1;
};

Errors.get = async function (escape) {
        const data = await db.getSortedSetRevRangeWithScores('errors:404', 0, 199);
        data.forEach((nfObject) => {
                nfObject.value = escape ? validator.escape(String(nfObject.value || '')) : nfObject.value;
        });
        return data;
};

Errors.clear = async function () {
        await db.delete('errors:404');
};

1	'use strict';
2
3	const winston = require('winston');	8✔
4	const validator = require('validator');	8✔
5	const cronJob = require('cron').CronJob;	8✔
6
7	const db = require('../database');	8✔
8	const analytics = require('../analytics');	8✔
9
10	const Errors = module.exports;	8✔
11
12	let counters = {};	8✔
13
14	new cronJob('0 * * * * *', (() => {	8✔
15	Errors.writeData();	2✔
16	}), null, true);
17
18	Errors.writeData = async function () {	8✔
19	try {	2✔
20	const _counters = { ...counters };	2✔
21	counters = {};	2✔
22	const keys = Object.keys(_counters);	2✔
23	if (!keys.length) {	2!
UNCOV 24	return;	×
25	}
26
27	for (const key of keys) {	2✔
28	/* eslint-disable no-await-in-loop */
29	await db.sortedSetIncrBy('errors:404', _counters[key], key);	50✔
30	}
31	} catch (err) {
32	winston.error(err.stack);	×
33	}
34	};
35
36	Errors.log404 = function (route) {	8✔
37	if (!route) {	61!
38	return;	×
39	}
40	route = route.slice(0, 512).replace(/\/$/, ''); // remove trailing slashes	61✔
41	analytics.increment('errors:404');	61✔
42	counters[route] = counters[route] \|\| 0;	61✔
43	counters[route] += 1;	61✔
44	};
45
46	Errors.get = async function (escape) {	8✔
47	const data = await db.getSortedSetRevRangeWithScores('errors:404', 0, 199);	4✔
48	data.forEach((nfObject) => {	4✔
49	nfObject.value = escape ? validator.escape(String(nfObject.value \|\| '')) : nfObject.value;	×
50	});
51	return data;	4✔
52	};
53
54	Errors.clear = async function () {	8✔
55	await db.delete('errors:404');	2✔
56	};

CMU-313 / NodeBB / 10657650892

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous