10638852467

Committed 30 Aug 2024 08:35PM UTC coverage: 31.867%. Remained the same

Build # 10638852467

Build Type

Pull #9681

github

Committed by

Raemon

Commit Message

clearer linkpost UI on LW

Pull Request Pull Request #9681: Clearer linkpost UI on LW

Run Details

5023 of 41140 branches covered (12.21%)

Branch coverage included in aggregate %.

0 of 1 new or added line in 1 file covered. (0.0%)

7 existing lines in 2 files now uncovered.

29342 of 66699 relevant lines covered (43.99%)

187.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

31.48

/packages/lesswrong/components/posts/PostsPage/PostBodyPrefix.tsx

import React from 'react';
import { Components, registerComponent } from '../../../lib/vulcan-lib';
import Info from '@material-ui/icons/Info';
import { forumTitleSetting, siteNameWithArticleSetting } from '../../../lib/instanceSettings';
import { useCurrentUser } from '../../common/withUser';
import { canNominate, postEligibleForReview, postIsVoteable, reviewIsActive, REVIEW_YEAR } from '../../../lib/reviewUtils';
import { forumSelect } from "../../../lib/forumTypeUtils";
import { Link } from '../../../lib/reactRouterWrapper';
import { isFriendlyUI } from '../../../themes/forumTheme';

const shortformDraftMessage = isFriendlyUI
  ? "This is a special post that holds your quick takes. Because it's marked as a draft, your quick takes will not be displayed. To un-draft it, pick Edit from the menu above, then click Publish."
  : "This is a special post that holds your short-form writing. Because it's marked as a draft, your short-form posts will not be displayed. To un-draft it, pick Edit from the menu above, then click Publish.";

const styles = (theme: ThemeType): JssStyles => ({
  reviewInfo: {
    textAlign: "center",
    marginBottom: 32
  },
  reviewLabel: {
    ...theme.typography.postStyle,
    ...theme.typography.contentNotice,
    marginBottom: theme.spacing.unit,
  },
  contentNotice: {
    ...theme.typography.contentNotice,
    ...theme.typography.postStyle,
    maxWidth: 600,
    ...(isFriendlyUI && {
      fontFamily: theme.palette.fonts.sansSerifStack,
    }),
  },
  rejectionNotice: {
    ...theme.typography.contentNotice,
    ...theme.typography.postStyle,
    maxWidth: 600,
    opacity: .75,
    marginBottom: 40
  },
  infoIcon: {
    width: 16,
    height: 16,
    marginLeft: theme.spacing.unit,
    verticalAlign: "top",
    color: theme.palette.icon.dim2,
  },
  reviewVoting: {
    textAlign: "center",
    padding: theme.spacing.unit*2,
    paddingBottom: theme.spacing.unit*6
  },
  reviewButton: {
    border: `solid 1px ${theme.palette.primary.main}`,
    paddingLeft: theme.spacing.unit*2,
    paddingRight: theme.spacing.unit*2,
    paddingTop: theme.spacing.unit,
    paddingBottom: theme.spacing.unit,
    marginTop: theme.spacing.unit,
    display: "inline-block",
    borderRadius: 3
  }
});

const forumNewUserProcessingTime = forumSelect({
  EAForum: 24,
  LessWrong: 72,
  AlignmentForum: 72,
  default: 24
})

const PostBodyPrefix = ({post, query, classes}: {
  post: PostsWithNavigation|PostsWithNavigationAndRevision|PostsList,
  query?: any,
  classes: ClassesType,
}) => {
  const { AlignmentPendingApprovalMessage, LinkPostMessage, PostsRevisionMessage, LWTooltip, ReviewVotingWidget, ReviewPostButton, ContentItemBody, ContentStyles } = Components;
  const currentUser = useCurrentUser();

  return <>
    {reviewIsActive() && postEligibleForReview(post) && postIsVoteable(post) && <div className={classes.reviewVoting}>
      {canNominate(currentUser, post) && <ReviewVotingWidget post={post}/>}
      <ReviewPostButton post={post} year={REVIEW_YEAR+""} reviewMessage={<LWTooltip title={`Write up your thoughts on what was good about a post, how it could be improved, and how you think stands the tests of time as part of the broader ${forumTitleSetting.get()} conversation`} placement="bottom">
        <div className={classes.reviewButton}>Review</div>
      </LWTooltip>}/>
    </div>}

    <AlignmentPendingApprovalMessage post={post} />

    {post.shortform && post.draft && <div className={classes.contentNotice}>
      {shortformDraftMessage}
    </div>}
    {post.shortform && !post.draft && <div className={classes.contentNotice}>
      <>
        This is a special post for quick takes by <Components.UsersNameDisplay user={post.user}/>. Only they can create top-level comments. Comments here also appear on the <Link to="/quicktakes">Quick Takes page</Link> and <Link to="/allPosts">All Posts page</Link>.
      </>
    </div>}

    {post.rejected && <div className={classes.rejectionNotice}>
      <p>This post was rejected{post.rejectedReason && " for the following reason(s):"}</p>
      <ContentStyles contentType="postHighlight">
        <ContentItemBody dangerouslySetInnerHTML={{__html: post.rejectedReason || "" }}/>
      </ContentStyles>
    </div>}
    {!post.rejected && post.authorIsUnreviewed && !post.draft && <div className={classes.contentNotice}>
      {currentUser?._id === post.userId
        ? "Because this is your first post, this post is awaiting moderator approval."
        : "This post is unlisted and is still awaiting moderation.\nUsers' first posts need to be approved by a moderator."
      }
      <LWTooltip title={<p>
        New users' first posts on {siteNameWithArticleSetting.get()} are checked by moderators before they appear on the site.
        Most posts will be approved within {forumNewUserProcessingTime} hours; posts that are spam or that don't meet site
        standards will be deleted. After you've had a post approved, future posts will appear
        immediately without waiting for review.
      </p>}>
        <Info className={classes.infoIcon}/>
      </LWTooltip>
    </div>}
    {isFriendlyUI && <LinkPostMessage post={post} negativeTopMargin={isFriendlyUI} />}
    {query?.revision && post.contents && <PostsRevisionMessage post={post} />}
  </>;
}

const PostBodyPrefixComponent = registerComponent('PostBodyPrefix', PostBodyPrefix, {styles});

declare global {
  interface ComponentTypes {
    PostBodyPrefix: typeof PostBodyPrefixComponent
  }
}

1	import React from 'react';	1✔
2	import { Components, registerComponent } from '../../../lib/vulcan-lib';	1✔
3	import Info from '@material-ui/icons/Info';	1✔
4	import { forumTitleSetting, siteNameWithArticleSetting } from '../../../lib/instanceSettings';	1✔
5	import { useCurrentUser } from '../../common/withUser';	1✔
6	import { canNominate, postEligibleForReview, postIsVoteable, reviewIsActive, REVIEW_YEAR } from '../../../lib/reviewUtils';	1✔
7	import { forumSelect } from "../../../lib/forumTypeUtils";	1✔
8	import { Link } from '../../../lib/reactRouterWrapper';	1✔
9	import { isFriendlyUI } from '../../../themes/forumTheme';	1✔
10
11	const shortformDraftMessage = isFriendlyUI	1✔
12	? "This is a special post that holds your quick takes. Because it's marked as a draft, your quick takes will not be displayed. To un-draft it, pick Edit from the menu above, then click Publish."	1!
13	: "This is a special post that holds your short-form writing. Because it's marked as a draft, your short-form posts will not be displayed. To un-draft it, pick Edit from the menu above, then click Publish.";
14
15	const styles = (theme: ThemeType): JssStyles => ({	1✔
16	reviewInfo: {
17	textAlign: "center",
18	marginBottom: 32
19	},
20	reviewLabel: {
21	...theme.typography.postStyle,
22	...theme.typography.contentNotice,
23	marginBottom: theme.spacing.unit,
24	},
25	contentNotice: {
26	...theme.typography.contentNotice,
27	...theme.typography.postStyle,
28	maxWidth: 600,
29	...(isFriendlyUI && {	2✔
30	fontFamily: theme.palette.fonts.sansSerifStack,
31	}),
32	},
33	rejectionNotice: {
34	...theme.typography.contentNotice,
35	...theme.typography.postStyle,
36	maxWidth: 600,
37	opacity: .75,
38	marginBottom: 40
39	},
40	infoIcon: {
41	width: 16,
42	height: 16,
43	marginLeft: theme.spacing.unit,
44	verticalAlign: "top",
45	color: theme.palette.icon.dim2,
46	},
47	reviewVoting: {
48	textAlign: "center",
49	padding: theme.spacing.unit*2,
50	paddingBottom: theme.spacing.unit*6
51	},
52	reviewButton: {
53	border: `solid 1px ${theme.palette.primary.main}`,
54	paddingLeft: theme.spacing.unit*2,
55	paddingRight: theme.spacing.unit*2,
56	paddingTop: theme.spacing.unit,
57	paddingBottom: theme.spacing.unit,
58	marginTop: theme.spacing.unit,
59	display: "inline-block",
60	borderRadius: 3
61	}
62	});
63
64	const forumNewUserProcessingTime = forumSelect({	1✔
65	EAForum: 24,
66	LessWrong: 72,
67	AlignmentForum: 72,
68	default: 24
69	})
70
71	const PostBodyPrefix = ({post, query, classes}: {	1✔
72	post: PostsWithNavigation\|PostsWithNavigationAndRevision\|PostsList,
73	query?: any,
74	classes: ClassesType,
75	}) => {
UNCOV 76	const { AlignmentPendingApprovalMessage, LinkPostMessage, PostsRevisionMessage, LWTooltip, ReviewVotingWidget, ReviewPostButton, ContentItemBody, ContentStyles } = Components;	×
UNCOV 77	const currentUser = useCurrentUser();	×
78
79	return <>	×
80	{reviewIsActive() && postEligibleForReview(post) && postIsVoteable(post) && <div className={classes.reviewVoting}>	×
81	{canNominate(currentUser, post) && <ReviewVotingWidget post={post}/>}
82	<ReviewPostButton post={post} year={REVIEW_YEAR+""} reviewMessage={<LWTooltip title={`Write up your thoughts on what was good about a post, how it could be improved, and how you think stands the tests of time as part of the broader ${forumTitleSetting.get()} conversation`} placement="bottom">
83	<div className={classes.reviewButton}>Review</div>
84	</LWTooltip>}/>
85	</div>}
86
87	<AlignmentPendingApprovalMessage post={post} />
88
89	{post.shortform && post.draft && <div className={classes.contentNotice}>	×
90	{shortformDraftMessage}
91	</div>}
92	{post.shortform && !post.draft && <div className={classes.contentNotice}>	×
93	<>
94	This is a special post for quick takes by <Components.UsersNameDisplay user={post.user}/>. Only they can create top-level comments. Comments here also appear on the <Link to="/quicktakes">Quick Takes page</Link> and <Link to="/allPosts">All Posts page</Link>.
95	</>
96	</div>}
97
98	{post.rejected && <div className={classes.rejectionNotice}>	×
99	<p>This post was rejected{post.rejectedReason && " for the following reason(s):"}</p>	×
100	<ContentStyles contentType="postHighlight">
101	<ContentItemBody dangerouslySetInnerHTML={{__html: post.rejectedReason \|\| "" }}/>	×
102	</ContentStyles>
103	</div>}
104	{!post.rejected && post.authorIsUnreviewed && !post.draft && <div className={classes.contentNotice}>	×
105	{currentUser?._id === post.userId	×
106	? "Because this is your first post, this post is awaiting moderator approval."	×
107	: "This post is unlisted and is still awaiting moderation.\nUsers' first posts need to be approved by a moderator."
108	}
109	<LWTooltip title={<p>
110	New users' first posts on {siteNameWithArticleSetting.get()} are checked by moderators before they appear on the site.
111	Most posts will be approved within {forumNewUserProcessingTime} hours; posts that are spam or that don't meet site
112	standards will be deleted. After you've had a post approved, future posts will appear
113	immediately without waiting for review.
114	</p>}>
115	<Info className={classes.infoIcon}/>
116	</LWTooltip>
117	</div>}
118	{isFriendlyUI && <LinkPostMessage post={post} negativeTopMargin={isFriendlyUI} />}	×
119	{query?.revision && post.contents && <PostsRevisionMessage post={post} />}	×
120	</>;
121	}
122
123	const PostBodyPrefixComponent = registerComponent('PostBodyPrefix', PostBodyPrefix, {styles});	1✔
124
125	declare global {
126	interface ComponentTypes {
127	PostBodyPrefix: typeof PostBodyPrefixComponent
128	}
129	}

ForumMagnum / ForumMagnum / 10638852467

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous