10612891459

Committed 29 Aug 2024 10:00AM UTC coverage: 67.163% (-0.2%) from 67.362%

Build # 10612891459

Build Type

Pull #1152

github

Committed by

joshuaunity

Commit Message

chore: more concise code

Signed-off-by: joshuaunity <oghenerobojosh01@gmail.com>

Pull Request Pull Request #1152: Feat edit account

Run Details

6135 of 9994 branches covered (61.39%)

Branch coverage included in aggregate %.

26 of 67 new or added lines in 5 files covered. (38.81%)

1 existing line in 1 file now uncovered.

7763 of 10699 relevant lines covered (72.56%)

5.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

49.33

/flexmeasures/ui/crud/accounts.py

from __future__ import annotations

from sqlalchemy import select
from flask import request, url_for
from flask_classful import FlaskView
from flask_security import login_required
from flexmeasures.ui.crud.api_wrapper import InternalApi
from flexmeasures.ui.utils.view_utils import render_flexmeasures_template
from flexmeasures.ui.crud.assets import get_assets_by_account
from flexmeasures.ui.crud.users import get_users_by_account
from flexmeasures.data.models.user import Account
from flexmeasures.data import db


def get_accounts() -> list[dict]:
    """/accounts"""
    accounts_response = InternalApi().get(url_for("AccountAPI:index"))
    accounts = accounts_response.json()

    return accounts


def get_account(account_id: str) -> dict:
    account_response = InternalApi().get(url_for("AccountAPI:get", id=account_id))
    account = account_response.json()

    return account


class AccountCrudUI(FlaskView):
    route_base = "/accounts"
    trailing_slash = False

    @login_required
    def index(self):
        """/accounts"""
        accounts = get_accounts()
        for account in accounts:
            account["asset_count"] = len(get_assets_by_account(account["id"]))
            account["user_count"] = len(get_users_by_account(account["id"]))

        return render_flexmeasures_template(
            "crud/accounts.html",
            accounts=accounts,
        )

    @login_required
    def get(self, account_id: str):
        """/accounts/<account_id>"""
        include_inactive = request.args.get("include_inactive", "0") != "0"
        account = get_account(account_id)
        if account["consultancy_account_id"]:
            consultancy_account = db.session.execute(
                select(Account).filter_by(id=account["consultancy_account_id"])
            ).scalar_one_or_none()
            if consultancy_account:
                account["consultancy_account_name"] = consultancy_account.name
        assets = get_assets_by_account(account_id)
        assets += get_assets_by_account(account_id=None)
        users = get_users_by_account(account_id, include_inactive=include_inactive)
        accounts = get_accounts()
        return render_flexmeasures_template(
            "crud/account.html",
            account=account,
            accounts=accounts,
            assets=assets,
            users=users,
            include_inactive=include_inactive,
        )

    @login_required
    def auditlog(self, account_id: str):
        """/accounts/auditlog/<account_id>"""
        account = get_account(account_id)
        audit_log_response = InternalApi().get(
            url_for("AccountAPI:auditlog", id=account_id)
        )
        audit_logs_response = audit_log_response.json()
        return render_flexmeasures_template(
            "crud/account_audit_log.html",
            audit_logs=audit_logs_response,
            account=account,
        )

1	from __future__ import annotations	8✔
2
3	from sqlalchemy import select	8✔
4	from flask import request, url_for	8✔
5	from flask_classful import FlaskView	8✔
6	from flask_security import login_required	8✔
7	from flexmeasures.ui.crud.api_wrapper import InternalApi	8✔
8	from flexmeasures.ui.utils.view_utils import render_flexmeasures_template	8✔
9	from flexmeasures.ui.crud.assets import get_assets_by_account	8✔
10	from flexmeasures.ui.crud.users import get_users_by_account	8✔
11	from flexmeasures.data.models.user import Account	8✔
12	from flexmeasures.data import db	8✔
13
14
15	def get_accounts() -> list[dict]:	8✔
16	"""/accounts"""
17	accounts_response = InternalApi().get(url_for("AccountAPI:index"))	8✔
18	accounts = accounts_response.json()	8✔
19
20	return accounts	8✔
21
22
23	def get_account(account_id: str) -> dict:	8✔
24	account_response = InternalApi().get(url_for("AccountAPI:get", id=account_id))	8✔
25	account = account_response.json()	8✔
26
27	return account	8✔
28
29
30	class AccountCrudUI(FlaskView):	8✔
31	route_base = "/accounts"	8✔
32	trailing_slash = False	8✔
33
34	@login_required	8✔
35	def index(self):	8✔
36	"""/accounts"""
37	accounts = get_accounts()	×
38	for account in accounts:	×
39	account["asset_count"] = len(get_assets_by_account(account["id"]))	×
40	account["user_count"] = len(get_users_by_account(account["id"]))	×
41
42	return render_flexmeasures_template(	×
43	"crud/accounts.html",
44	accounts=accounts,
45	)
46
47	@login_required	8✔
48	def get(self, account_id: str):	8✔
49	"""/accounts/<account_id>"""
50	include_inactive = request.args.get("include_inactive", "0") != "0"	×
51	account = get_account(account_id)	×
52	if account["consultancy_account_id"]:	×
53	consultancy_account = db.session.execute(	×
54	select(Account).filter_by(id=account["consultancy_account_id"])
55	).scalar_one_or_none()
56	if consultancy_account:	×
57	account["consultancy_account_name"] = consultancy_account.name	×
58	assets = get_assets_by_account(account_id)	×
59	assets += get_assets_by_account(account_id=None)	×
60	users = get_users_by_account(account_id, include_inactive=include_inactive)	×
NEW 61	accounts = get_accounts()	×
UNCOV 62	return render_flexmeasures_template(	×
63	"crud/account.html",
64	account=account,
65	accounts=accounts,
66	assets=assets,
67	users=users,
68	include_inactive=include_inactive,
69	)
70
71	@login_required	8✔
72	def auditlog(self, account_id: str):	8✔
73	"""/accounts/auditlog/<account_id>"""
74	account = get_account(account_id)	×
75	audit_log_response = InternalApi().get(	×
76	url_for("AccountAPI:auditlog", id=account_id)
77	)
78	audit_logs_response = audit_log_response.json()	×
79	return render_flexmeasures_template(	×
80	"crud/account_audit_log.html",
81	audit_logs=audit_logs_response,
82	account=account,
83	)

FlexMeasures / flexmeasures / 10612891459

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous