10608862281

Committed 29 Aug 2024 04:46AM UTC coverage: 31.913% (-0.003%) from 31.916%

Build # 10608862281

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9642 from ForumMagnum/smalls-2024-08-27

Accumulated small changes from my git stash

Run Details

5023 of 41073 branches covered (12.23%)

Branch coverage included in aggregate %.

6 of 15 new or added lines in 11 files covered. (40.0%)

1 existing line in 1 file now uncovered.

29321 of 66545 relevant lines covered (44.06%)

188.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

19.17

/packages/lesswrong/server/rss.ts

import RSS from 'rss';
import { Comments } from '../lib/collections/comments';
import { commentGetPageUrlFromDB } from '../lib/collections/comments/helpers';
import { Posts } from '../lib/collections/posts';
import { postGetPageUrl } from '../lib/collections/posts/helpers';
import { userGetDisplayNameById } from '../lib/vulcan-users/helpers';
import { forumTitleSetting, siteUrlSetting, taglineSetting } from '../lib/instanceSettings';
import moment from '../lib/moment-timezone';
import { rssTermsToUrl, RSSTerms } from '../lib/rss_urls';
import { addStaticRoute, createAnonymousContext } from './vulcan-lib';
import { accessFilterMultiple } from '../lib/utils/schemaUtils';
import { getCommentParentTitle } from '../lib/notificationTypes';
import { asyncForeachSequential } from '../lib/utils/asyncUtils';
import { getContextFromReqAndRes } from './vulcan-lib/apollo-server/context';
import { viewTermsToQuery } from '../lib/utils/viewUtils';
import { fetchFragment } from './fetchFragment';

Posts.addView('rss', Posts.views.new); // default to 'new' view for RSS feed
Comments.addView('rss', Comments.views.recentComments); // default to 'recentComments' view for comments RSS feed

export const getMeta = (url: string) => {
  const siteUrl = siteUrlSetting.get();

  return {
    title: forumTitleSetting.get(),
    description: taglineSetting.get(),
    feed_url: url,
    site_url: siteUrl,
    image_url: "https://res.cloudinary.com/lesswrong-2-0/image/upload/v1497915096/favicon_lncumn.ico"
  };
};

type KarmaThreshold = 2 | 30 | 45 | 75 | 125 | 200;

// LESSWRONG - this was added to handle karmaThresholds
const roundKarmaThreshold = (threshold: number): KarmaThreshold =>
    (threshold < 16 || !threshold) ? 2
  : (threshold < 37) ? 30
  : (threshold < 60) ? 45
  : (threshold < 100) ? 75
  : (threshold < 162) ? 125
  : 200;

const servePostRSS = async (terms: RSSTerms, url?: string) => {
  // LESSWRONG - this was added to handle karmaThresholds
  let karmaThreshold = terms.karmaThreshold = roundKarmaThreshold(parseInt(terms.karmaThreshold, 10));
  url = url || rssTermsToUrl(terms); // Default value is the custom rss feed computed from terms
  const feed = new RSS(getMeta(url));
  const context = createAnonymousContext();
  const parameters = viewTermsToQuery("Posts", terms, undefined, context);
  delete parameters['options']['sort']['sticky'];

  parameters.options.limit = 10;

  const postsCursor = await fetchFragment({
    collectionName: "Posts",
    fragmentName: "PostsRSSFeed",
    currentUser: null,
    selector: parameters.selector,
    options: parameters.options,
  });

  await asyncForeachSequential(postsCursor, async (post) => {
    // LESSWRONG - this was added to handle karmaThresholds
    let thresholdDate = (karmaThreshold === 2)  ? post.scoreExceeded2Date
                      : (karmaThreshold === 30) ? post.scoreExceeded30Date
                      : (karmaThreshold === 45) ? post.scoreExceeded45Date
                      : (karmaThreshold === 75) ? post.scoreExceeded75Date
                      : (karmaThreshold === 125) ? post.scoreExceeded125Date
                      : (karmaThreshold === 200) ? post.scoreExceeded200Date
                      : null;
    thresholdDate = thresholdDate || post.postedAt;
    let viewDate = (terms.view === "frontpage-rss") ? post.frontpageDate
                 : (terms.view === "curated-rss")   ? post.curatedDate
                 : (terms.view === "meta-rss")      ? post.metaDate
                 : null;
    viewDate = viewDate || post.postedAt;

    let date = (viewDate > thresholdDate) ? viewDate : thresholdDate;

    const postLink = `<a href="${postGetPageUrl(post, true)}#comments">Discuss</a>`;
    const formattedTime = moment(post.postedAt).tz(moment.tz.guess()).format('LLL z');
    const feedItem: any = {
      title: post.title,
      description: `Published on ${formattedTime}<br/><br/>${(post.contents && post.contents.html) || ""}<br/><br/>${postLink}`,
      // LESSWRONG - changed how author is set for RSS because
      // LessWrong posts don't reliably have post.author defined.
      //author: post.author,
      author: await userGetDisplayNameById(post.userId),
      // LESSWRONG - this was added to handle karmaThresholds
      // date: post.postedAt
      date: date,
      guid: post._id,
      url: postGetPageUrl(post, true)
    };

    feed.item(feedItem);
  });

  return feed.xml();
};

const serveCommentRSS = async (terms: RSSTerms, req: any, res: any, url?: string) => {
  url = url || rssTermsToUrl(terms); // Default value is the custom rss feed computed from terms
  const feed = new RSS(getMeta(url));
  const context = await getContextFromReqAndRes({req, res, isSSR: false});

  let parameters = viewTermsToQuery("Comments", terms);
  parameters.options.limit = 50;
  const commentsCursor = await Comments.find(parameters.selector, parameters.options).fetch();
  const restrictedComments = await accessFilterMultiple(null, Comments, commentsCursor, null) as DbComment[];

  await asyncForeachSequential(restrictedComments, async (comment) => {
    const url = await commentGetPageUrlFromDB(comment, context, true);
    const parentTitle = await getCommentParentTitle(comment)
    feed.item({
     title: 'Comment on ' + parentTitle,
     description: `${comment.contents && comment.contents.html}</br></br><a href='${url}'>Discuss</a>`,
     author: comment.author ?? undefined,
     date: comment.postedAt,
     url: url,
     guid: comment._id
    });
  });

  return feed.xml();
};


addStaticRoute('/feed.xml', async function(params, req, res, _next) {
  res.setHeader('Content-Type', 'application/rss+xml; charset=utf-8')
  if (typeof params.query.view === 'undefined') {
    params.query.view = 'rss';
  }
  if (params.query.filterSettings) {
    params.query.filterSettings = JSON.parse(params.query.filterSettings);
  }
  if (params.query.type && params.query.type === "comments") {
    res.end(await serveCommentRSS(params.query, req, res));
  } else {
    res.end(await servePostRSS(params.query));
  }
});

1	import RSS from 'rss';	54✔
2	import { Comments } from '../lib/collections/comments';	18✔
3	import { commentGetPageUrlFromDB } from '../lib/collections/comments/helpers';	18✔
4	import { Posts } from '../lib/collections/posts';	18✔
5	import { postGetPageUrl } from '../lib/collections/posts/helpers';	18✔
6	import { userGetDisplayNameById } from '../lib/vulcan-users/helpers';	18✔
7	import { forumTitleSetting, siteUrlSetting, taglineSetting } from '../lib/instanceSettings';	18✔
8	import moment from '../lib/moment-timezone';	18✔
9	import { rssTermsToUrl, RSSTerms } from '../lib/rss_urls';	18✔
10	import { addStaticRoute, createAnonymousContext } from './vulcan-lib';	18✔
11	import { accessFilterMultiple } from '../lib/utils/schemaUtils';	18✔
12	import { getCommentParentTitle } from '../lib/notificationTypes';	18✔
13	import { asyncForeachSequential } from '../lib/utils/asyncUtils';	18✔
14	import { getContextFromReqAndRes } from './vulcan-lib/apollo-server/context';	18✔
15	import { viewTermsToQuery } from '../lib/utils/viewUtils';	18✔
16	import { fetchFragment } from './fetchFragment';	18✔
17
18	Posts.addView('rss', Posts.views.new); // default to 'new' view for RSS feed	18✔
19	Comments.addView('rss', Comments.views.recentComments); // default to 'recentComments' view for comments RSS feed	18✔
20
21	export const getMeta = (url: string) => {	18✔
22	const siteUrl = siteUrlSetting.get();	×
23
24	return {	×
25	title: forumTitleSetting.get(),
26	description: taglineSetting.get(),
27	feed_url: url,
28	site_url: siteUrl,
29	image_url: "https://res.cloudinary.com/lesswrong-2-0/image/upload/v1497915096/favicon_lncumn.ico"
30	};
31	};
32
33	type KarmaThreshold = 2 \| 30 \| 45 \| 75 \| 125 \| 200;
34
35	// LESSWRONG - this was added to handle karmaThresholds
36	const roundKarmaThreshold = (threshold: number): KarmaThreshold =>	18✔
37	(threshold < 16 \|\| !threshold) ? 2	×
38	: (threshold < 37) ? 30	×
39	: (threshold < 60) ? 45	×
40	: (threshold < 100) ? 75	×
41	: (threshold < 162) ? 125	×
42	: 200;
43
44	const servePostRSS = async (terms: RSSTerms, url?: string) => {	18✔
45	// LESSWRONG - this was added to handle karmaThresholds
46	let karmaThreshold = terms.karmaThreshold = roundKarmaThreshold(parseInt(terms.karmaThreshold, 10));	×
47	url = url \|\| rssTermsToUrl(terms); // Default value is the custom rss feed computed from terms	×
48	const feed = new RSS(getMeta(url));	×
49	const context = createAnonymousContext();	×
50	const parameters = viewTermsToQuery("Posts", terms, undefined, context);	×
51	delete parameters['options']['sort']['sticky'];	×
52
53	parameters.options.limit = 10;	×
54
55	const postsCursor = await fetchFragment({	×
56	collectionName: "Posts",
57	fragmentName: "PostsRSSFeed",
58	currentUser: null,
59	selector: parameters.selector,
60	options: parameters.options,
61	});
62
63	await asyncForeachSequential(postsCursor, async (post) => {	×
64	// LESSWRONG - this was added to handle karmaThresholds
65	let thresholdDate = (karmaThreshold === 2) ? post.scoreExceeded2Date	×
66	: (karmaThreshold === 30) ? post.scoreExceeded30Date	×
67	: (karmaThreshold === 45) ? post.scoreExceeded45Date	×
68	: (karmaThreshold === 75) ? post.scoreExceeded75Date	×
69	: (karmaThreshold === 125) ? post.scoreExceeded125Date	×
70	: (karmaThreshold === 200) ? post.scoreExceeded200Date	×
71	: null;
72	thresholdDate = thresholdDate \|\| post.postedAt;	×
73	let viewDate = (terms.view === "frontpage-rss") ? post.frontpageDate	×
74	: (terms.view === "curated-rss") ? post.curatedDate	×
75	: (terms.view === "meta-rss") ? post.metaDate	×
76	: null;
77	viewDate = viewDate \|\| post.postedAt;	×
78
79	let date = (viewDate > thresholdDate) ? viewDate : thresholdDate;	×
80
81	const postLink = `<a href="${postGetPageUrl(post, true)}#comments">Discuss</a>`;	×
82	const formattedTime = moment(post.postedAt).tz(moment.tz.guess()).format('LLL z');	×
83	const feedItem: any = {	×
84	title: post.title,
85	description: `Published on ${formattedTime}<br/><br/>${(post.contents && post.contents.html) \|\| ""}<br/><br/>${postLink}`,	×
86	// LESSWRONG - changed how author is set for RSS because
87	// LessWrong posts don't reliably have post.author defined.
88	//author: post.author,
89	author: await userGetDisplayNameById(post.userId),
90	// LESSWRONG - this was added to handle karmaThresholds
91	// date: post.postedAt
92	date: date,
93	guid: post._id,
94	url: postGetPageUrl(post, true)
95	};
96
97	feed.item(feedItem);	×
98	});
99
100	return feed.xml();	×
101	};
102
103	const serveCommentRSS = async (terms: RSSTerms, req: any, res: any, url?: string) => {	18✔
104	url = url \|\| rssTermsToUrl(terms); // Default value is the custom rss feed computed from terms	×
105	const feed = new RSS(getMeta(url));	×
NEW 106	const context = await getContextFromReqAndRes({req, res, isSSR: false});	×
107
108	let parameters = viewTermsToQuery("Comments", terms);	×
109	parameters.options.limit = 50;	×
110	const commentsCursor = await Comments.find(parameters.selector, parameters.options).fetch();	×
111	const restrictedComments = await accessFilterMultiple(null, Comments, commentsCursor, null) as DbComment[];	×
112
113	await asyncForeachSequential(restrictedComments, async (comment) => {	×
114	const url = await commentGetPageUrlFromDB(comment, context, true);	×
115	const parentTitle = await getCommentParentTitle(comment)	×
116	feed.item({	×
117	title: 'Comment on ' + parentTitle,
118	description: `${comment.contents && comment.contents.html}</br></br><a href='${url}'>Discuss</a>`,	×
119	author: comment.author ?? undefined,	×
120	date: comment.postedAt,
121	url: url,
122	guid: comment._id
123	});
124	});
125
126	return feed.xml();	×
127	};	18✔
128
129
130	addStaticRoute('/feed.xml', async function(params, req, res, _next) {
131	res.setHeader('Content-Type', 'application/rss+xml; charset=utf-8')	×
132	if (typeof params.query.view === 'undefined') {	×
133	params.query.view = 'rss';	×
134	}
135	if (params.query.filterSettings) {	×
136	params.query.filterSettings = JSON.parse(params.query.filterSettings);	×
137	}
138	if (params.query.type && params.query.type === "comments") {	×
139	res.end(await serveCommentRSS(params.query, req, res));	×
140	} else {
141	res.end(await servePostRSS(params.query));	×
142	}
143	});

ForumMagnum / ForumMagnum / 10608862281

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous