10567327498

Committed 26 Aug 2024 09:10PM UTC coverage: 32.207% (+0.07%) from 32.136%

Build # 10567327498

Build Type

Pull #9632

github

Committed by

web-flow

Commit Message

Merge 9d5516e86 into 623e2a0d4

Pull Request Pull Request #9632: Merge master into LW deploy

Run Details

5017 of 40378 branches covered (12.43%)

Branch coverage included in aggregate %.

15 of 38 new or added lines in 5 files covered. (39.47%)

1 existing line in 1 file now uncovered.

29041 of 65368 relevant lines covered (44.43%)

190.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

24.24

/packages/lesswrong/components/comments/CommentsSortBySelector.tsx

import { Components, registerComponent } from '../../lib/vulcan-lib';
import React from 'react';
import { useLocation } from '@/lib/routeUtil';
import qs from 'qs'
import isEmpty from 'lodash/isEmpty';
import type { Option } from '../common/InlineSelect';
import { useNavigate } from '@/lib/reactRouterWrapper';


export const CommentsSortBySelector = ({setRestoreScrollPos}: {
  setRestoreScrollPos?: (pos: number) => void
}) => {
  const navigate = useNavigate();
  const location = useLocation();
  const { query } = location;
  
  const {InlineSelect} = Components

  const sortByOptions = [
    {value: "top", label: "Top"},
    {value: "new", label: "Newest"},
    {value: "old", label: "Oldest"},
    {value: "recentComments", label: "Recent Replies"}
  ]

  const handleViewClick = (opt: Option & {value: CommentsViewName}) => {
    const sortBy = opt.value
    const { query } = location;
    const currentQuery = isEmpty(query) ? {} : query
    const newQuery = {...currentQuery, commentsSortBy: sortBy}
    setRestoreScrollPos?.(window.scrollY);
    navigate({...location.location, search: `?${qs.stringify(newQuery)}`})
  };

  const currentSortBy: string = query?.commentsSortBy || "new"
  const selectedOption = sortByOptions.find((option) => option.value === currentSortBy) || sortByOptions[0]

  return <InlineSelect options={sortByOptions} selected={selectedOption} handleSelect={handleViewClick}/>
};

const CommentsSortBySelectorComponent = registerComponent('CommentsSortBySelector', CommentsSortBySelector);

declare global {
  interface ComponentTypes {
    CommentsSortBySelector: typeof CommentsSortBySelectorComponent
  }
}

1	import { Components, registerComponent } from '../../lib/vulcan-lib';	3✔
2	import React from 'react';	1✔
3	import { useLocation } from '@/lib/routeUtil';	1✔
4	import qs from 'qs'	1✔
5	import isEmpty from 'lodash/isEmpty';	1✔
6	import type { Option } from '../common/InlineSelect';
7	import { useNavigate } from '@/lib/reactRouterWrapper';	1✔
8
9
10	export const CommentsSortBySelector = ({setRestoreScrollPos}: {	1✔
11	setRestoreScrollPos?: (pos: number) => void
12	}) => {
NEW 13	const navigate = useNavigate();	×
NEW 14	const location = useLocation();	×
NEW 15	const { query } = location;	×
16
NEW 17	const {InlineSelect} = Components	×
18
NEW 19	const sortByOptions = [	×
20	{value: "top", label: "Top"},
21	{value: "new", label: "Newest"},
22	{value: "old", label: "Oldest"},
23	{value: "recentComments", label: "Recent Replies"}
24	]
25
NEW 26	const handleViewClick = (opt: Option & {value: CommentsViewName}) => {	×
NEW 27	const sortBy = opt.value	×
NEW 28	const { query } = location;	×
NEW 29	const currentQuery = isEmpty(query) ? {} : query	×
NEW 30	const newQuery = {...currentQuery, commentsSortBy: sortBy}	×
NEW 31	setRestoreScrollPos?.(window.scrollY);	×
NEW 32	navigate({...location.location, search: `?${qs.stringify(newQuery)}`})	×
33	};
34
NEW 35	const currentSortBy: string = query?.commentsSortBy \|\| "new"	×
NEW 36	const selectedOption = sortByOptions.find((option) => option.value === currentSortBy) \|\| sortByOptions[0]	×
37
NEW 38	return <InlineSelect options={sortByOptions} selected={selectedOption} handleSelect={handleViewClick}/>	×
39	};
40
41	const CommentsSortBySelectorComponent = registerComponent('CommentsSortBySelector', CommentsSortBySelector);	1✔
42
43	declare global {
44	interface ComponentTypes {
45	CommentsSortBySelector: typeof CommentsSortBySelectorComponent
46	}
47	}

ForumMagnum / ForumMagnum / 10567327498

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous