10561934475

Committed 26 Aug 2024 02:44PM UTC coverage: 46.733% (-0.04%) from 46.771%

Build # 10561934475

Build Type

push

github

Committed by

web-flow

Commit Message

Extend Confirmation View with an optional value field (#1851)

- Adds `value` optional parameter to `TransactionDataDto`.
- Adds `value` field to the `NativeStakingConfirmationView` entity.
- Adjusts tests accordingly.

Run Details

496 of 3003 branches covered (16.52%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 2 files covered. (60.0%)

2 existing lines in 2 files now uncovered.

4740 of 8201 relevant lines covered (57.8%)

12.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.92

/src/routes/common/entities/transaction-data.dto.entity.ts

import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
import { z } from 'zod';
import { HexSchema } from '@/validation/entities/schemas/hex.schema';
import { AddressSchema } from '@/validation/entities/schemas/address.schema';
import { NumericStringSchema } from '@/validation/entities/schemas/numeric-string.schema';

export const TransactionDataDtoSchema = z.object({
  data: HexSchema,
  to: AddressSchema.optional(),
  value: NumericStringSchema.optional(),
});

export class TransactionDataDto
  implements z.infer<typeof TransactionDataDtoSchema>
{
  @ApiProperty({ description: 'Hexadecimal value' })
  data: `0x${string}`;
  @ApiPropertyOptional({ description: 'The target Ethereum address' })
  to?: `0x${string}`;
  @ApiPropertyOptional({
    description: 'The wei amount being sent to a payable function',
  })
  value?: string;

  constructor(data: `0x${string}`, to?: `0x${string}`, value?: string) {
    this.data = data;
    this.to = to;
    this.value = value;
  }
}

1	import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';	16✔
2	import { z } from 'zod';	16✔
3	import { HexSchema } from '@/validation/entities/schemas/hex.schema';	16✔
4	import { AddressSchema } from '@/validation/entities/schemas/address.schema';	16✔
5	import { NumericStringSchema } from '@/validation/entities/schemas/numeric-string.schema';	16✔
6
7	export const TransactionDataDtoSchema = z.object({	16✔
8	data: HexSchema,
9	to: AddressSchema.optional(),
10	value: NumericStringSchema.optional(),
11	});
12
13	export class TransactionDataDto	16✔
14	implements z.infer<typeof TransactionDataDtoSchema>
15	{
16	@ApiProperty({ description: 'Hexadecimal value' })
17	data: `0x${string}`;	16✔
18	@ApiPropertyOptional({ description: 'The target Ethereum address' })
19	to?: `0x${string}`;	16✔
20	@ApiPropertyOptional({
21	description: 'The wei amount being sent to a payable function',
22	})
23	value?: string;	16✔
24
25	constructor(data: `0x${string}`, to?: `0x${string}`, value?: string) {
26	this.data = data;	×
27	this.to = to;	×
NEW 28	this.value = value;	×
29	}
30	}

safe-global / safe-client-gateway / 10561934475

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous