10512898605

Committed 22 Aug 2024 05:34PM UTC coverage: 74.487% (-0.1%) from 74.606%

Build # 10512898605

Build Type

push

github

Committed by

web-flow

Commit Message

Go 1.23 support (#3226)

* Added support for go 1.23

* Added handling for *types.Alias

* Updated golang ci lint to 1.60.2

* Fixed lint issues and ignore SA1019 on generated test files

* Update coverage.yml

* Update fmt-and-generate.yml

* Update integration.yml

* Update lint.yml

* Update test.yml

---------

Co-authored-by: Steve Coffman <StevenACoffman@users.noreply.github.com>

Run Details

76 of 97 new or added lines in 4 files covered. (78.35%)

8 existing lines in 3 files now uncovered.

7194 of 9658 relevant lines covered (74.49%)

688.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.86

/codegen/templates/templates_1.23.go

//go:build go1.23

package templates

import (
        "fmt"
        "go/types"
)

func TypeIdentifier(t types.Type) string {
        res := ""
        for {
                switch it := t.(type) {
                case *types.Pointer:
                        t.Underlying()
                        res += "ᚖ"
                        t = it.Elem()
                case *types.Slice:
                        res += "ᚕ"
                        t = it.Elem()
                case *types.Named:
                        res += pkgReplacer.Replace(it.Obj().Pkg().Path())
                        res += "ᚐ"
                        res += it.Obj().Name()
                        return res
                case *types.Basic:
                        res += it.Name()
                        return res
                case *types.Map:
                        res += "map"
                        return res
                case *types.Interface:
                        res += "interface"
                        return res
                case *types.Alias:
                        return TypeIdentifier(it.Rhs())
                default:
                        panic(fmt.Errorf("unexpected type %T", it))
                }
        }
}

1	//go:build go1.23
2
3	package templates
4
5	import (
6	"fmt"
7	"go/types"
8	)
9
10	func TypeIdentifier(t types.Type) string {	1,222✔
11	res := ""	1,222✔
12	for {	3,115✔
13	switch it := t.(type) {	1,893✔
14	case *types.Pointer:	425✔
15	t.Underlying()	425✔
16	res += "ᚖ"	425✔
17	t = it.Elem()	425✔
18	case *types.Slice:	246✔
19	res += "ᚕ"	246✔
20	t = it.Elem()	246✔
21	case *types.Named:	535✔
22	res += pkgReplacer.Replace(it.Obj().Pkg().Path())	535✔
23	res += "ᚐ"	535✔
24	res += it.Obj().Name()	535✔
25	return res	535✔
26	case *types.Basic:	683✔
27	res += it.Name()	683✔
28	return res	683✔
29	case *types.Map:	4✔
30	res += "map"	4✔
31	return res	4✔
NEW 32	case *types.Interface:	×
NEW 33	res += "interface"	×
NEW 34	return res	×
NEW 35	case *types.Alias:	×
NEW 36	return TypeIdentifier(it.Rhs())	×
NEW 37	default:	×
NEW 38	panic(fmt.Errorf("unexpected type %T", it))	×
39	}
40	}
41	}

99designs / gqlgen / 10512898605

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous