10469349247

Committed 20 Aug 2024 09:53AM UTC coverage: 89.194% (-0.02%) from 89.217%

Build # 10469349247

Build Type

Pull #9093

github

Committed by

web-flow

Commit Message

Merge db00d4b05 into e10122308

Pull Request Pull Request #9093: Update PBR code to use luma pbrMaterial

Run Details

6541 of 7182 branches covered (91.07%)

Branch coverage included in aggregate %.

34 of 63 new or added lines in 6 files covered. (53.97%)

2 existing lines in 2 files now uncovered.

54696 of 61474 relevant lines covered (88.97%)

6291.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.25

/modules/mesh-layers/src/scenegraph-layer/gltf-utils.ts

/* global requestAnimationFrame */
import type {GroupNode, ScenegraphNode, ModelNode} from '@luma.gl/engine';

export async function waitForGLTFAssets(gltfObjects: {scenes: GroupNode[]}): Promise<void> {
  const remaining: any[] = [];

  gltfObjects.scenes.forEach(scene => {
    scene.traverse((modelNode: ScenegraphNode) => {
      // TODO v9 getUnforms() was removed, hack it with props.uniforms
      Object.values((modelNode as ModelNode).model.uniforms).forEach((uniform: any) => {
        if (uniform.loaded === false) {
          remaining.push(uniform);
        }
      });
    });
  });

  return await waitWhileCondition(() => remaining.some(uniform => !uniform.loaded));
}

async function waitWhileCondition(condition: () => boolean): Promise<void> {
  while (condition()) {
    await new Promise(resolve => requestAnimationFrame(resolve));
  }
}

1	/* global requestAnimationFrame */	1✔
2	import type {GroupNode, ScenegraphNode, ModelNode} from '@luma.gl/engine';	1✔
3		1✔
4	export async function waitForGLTFAssets(gltfObjects: {scenes: GroupNode[]}): Promise<void> {	2✔
5	const remaining: any[] = [];	2✔
6		2✔
7	gltfObjects.scenes.forEach(scene => {	2✔
8	scene.traverse((modelNode: ScenegraphNode) => {	2✔
9	// TODO v9 getUnforms() was removed, hack it with props.uniforms	3✔
10	Object.values((modelNode as ModelNode).model.uniforms).forEach((uniform: any) => {	3✔
UNCOV 11	if (uniform.loaded === false) {	×
12	remaining.push(uniform);	×
13	}	×
14	});	3✔
15	});	2✔
16	});	2✔
17		2✔
18	return await waitWhileCondition(() => remaining.some(uniform => !uniform.loaded));	2✔
19	}	2✔
20		1✔
21	async function waitWhileCondition(condition: () => boolean): Promise<void> {	2✔
22	while (condition()) {	2!
23	await new Promise(resolve => requestAnimationFrame(resolve));	×
24	}	×
25	}	2✔

visgl / deck.gl / 10469349247

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous