10452323093

Committed 19 Aug 2024 11:17AM UTC coverage: 45.836% (-1.1%) from 46.893%

Build # 10452323093

Build Type

Pull #1824

github

Committed by

iamacook

Commit Message

Add tests for batches

Pull Request Pull Request #1824: Staking confirmation screens

Run Details

489 of 3103 branches covered (15.76%)

Branch coverage included in aggregate %.

128 of 347 new or added lines in 11 files covered. (36.89%)

3 existing lines in 1 file now uncovered.

4729 of 8281 relevant lines covered (57.11%)

12.19 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

27.78

/src/routes/transactions/helpers/transaction-finder.helper.ts

import { MultiSendDecoder } from '@/domain/contracts/decoders/multi-send-decoder.helper';
import { Injectable, Module } from '@nestjs/common';

@Injectable()
export class TransactionFinder {
  constructor(private readonly multiSendDecoder: MultiSendDecoder) {}

  /**
   * Finds transaction data in a given transaction, if directly called or in a MultiSend
   *
   * @param isTransactionData - function to determine if the transaction data is the one we are looking for
   * @param transaction - transaction to search for the data
   * @returns transaction data if found, otherwise null
   */
  public findTransaction(
    isTransactionData: (args: {
      to?: `0x${string}`;
      data: `0x${string}`;
    }) => boolean,
    transaction: { to?: `0x${string}`; data: `0x${string}` },
  ): { to?: `0x${string}`; data: `0x${string}` } | null {
    if (isTransactionData(transaction)) {
      return transaction;
    }

    // TODO: Check transaction.to is MultiSend contract address
    if (this.multiSendDecoder.helpers.isMultiSend(transaction.data)) {
      const batchedTransaction = this.multiSendDecoder
        .mapMultiSendTransactions(transaction.data)
        .find(isTransactionData);

      if (batchedTransaction) {
        return {
          to: batchedTransaction.to,
          data: batchedTransaction.data,
        };
      }
    }

    return null;
  }
}

@Module({
  imports: [],
  providers: [TransactionFinder, MultiSendDecoder],
  exports: [TransactionFinder],
})
export class TransactionFinderModule {}

1	import { MultiSendDecoder } from '@/domain/contracts/decoders/multi-send-decoder.helper';	16✔
2	import { Injectable, Module } from '@nestjs/common';	16✔
3
4	@Injectable()
5	export class TransactionFinder {	16✔
6	constructor(private readonly multiSendDecoder: MultiSendDecoder) {}	16✔
7
8	/**
9	* Finds transaction data in a given transaction, if directly called or in a MultiSend
10	*
11	* @param isTransactionData - function to determine if the transaction data is the one we are looking for
12	* @param transaction - transaction to search for the data
13	* @returns transaction data if found, otherwise null
14	*/
15	public findTransaction(
16	isTransactionData: (args: {
17	to?: `0x${string}`;
18	data: `0x${string}`;
19	}) => boolean,
20	transaction: { to?: `0x${string}`; data: `0x${string}` },
21	): { to?: `0x${string}`; data: `0x${string}` } \| null {
22	if (isTransactionData(transaction)) {	×
NEW 23	return transaction;	×
24	}
25
26	// TODO: Check transaction.to is MultiSend contract address
27	if (this.multiSendDecoder.helpers.isMultiSend(transaction.data)) {	×
28	const batchedTransaction = this.multiSendDecoder	×
29	.mapMultiSendTransactions(transaction.data)
30	.find(isTransactionData);
31
32	if (batchedTransaction) {	×
NEW 33	return {	×
34	to: batchedTransaction.to,
35	data: batchedTransaction.data,
36	};
37	}
38	}
39
40	return null;	×
41	}
42	}
43
44	@Module({
45	imports: [],
46	providers: [TransactionFinder, MultiSendDecoder],
47	exports: [TransactionFinder],
48	})
49	export class TransactionFinderModule {}	16✔

safe-global / safe-client-gateway / 10452323093

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous