jorgen.edelbo_396

Committed 16 Aug 2024 07:10AM UTC coverage: 91.112% (+0.004%) from 91.108%

Build # jorgen.edelbo_396

Build Type

Pull #7987

Evergreen

Committed by

jedelbo

Commit Message

Fix handling backlink column as last element in KeyPath

Pull Request Pull Request #7987: RCORE-2061: Fix handling backlink column as last element in KeyPath

Run Details

102864 of 181636 branches covered (56.63%)

42 of 42 new or added lines in 3 files covered. (100.0%)

74 existing lines in 19 files now uncovered.

217408 of 238617 relevant lines covered (91.11%)

5643596.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.27

/src/realm/sync/noinst/client_reset_operation.cpp

/*************************************************************************
 *
 * Copyright 2021 Realm Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 **************************************************************************/

#include <realm/sync/noinst/client_reset_operation.hpp>

#include <realm/sync/history.hpp>
#include <realm/sync/noinst/client_history_impl.hpp>
#include <realm/sync/noinst/client_reset.hpp>
#include <realm/transaction.hpp>
#include <realm/util/scope_exit.hpp>

namespace realm::_impl::client_reset {

namespace {

constexpr static std::string_view c_fresh_suffix(".fresh");

} // namespace

std::string get_fresh_path_for(const std::string& path)
{
    const size_t suffix_len = c_fresh_suffix.size();
    REALM_ASSERT(path.length());
    REALM_ASSERT_DEBUG_EX(
        path.size() < suffix_len || path.substr(path.size() - suffix_len, suffix_len) != c_fresh_suffix, path);
    return path + c_fresh_suffix.data();
}

bool is_fresh_path(const std::string& path)
{
    const size_t suffix_len = c_fresh_suffix.size();
    REALM_ASSERT(path.length());
    if (path.size() < suffix_len) {
        return false;
    }
    return path.substr(path.size() - suffix_len, suffix_len) == c_fresh_suffix;
}

bool perform_client_reset(util::Logger& logger, DB& db, sync::ClientReset&& reset_config,
                          sync::SubscriptionStore* sub_store)
{
    REALM_ASSERT(reset_config.mode != ClientResyncMode::Manual);
    REALM_ASSERT(reset_config.fresh_copy);
    logger.debug(util::LogCategory::reset,
                 "Possibly beginning client reset operation: realm_path = %1, mode = %2, action = %3, error = %4",
                 db.get_path(), reset_config.mode, reset_config.action, reset_config.error);

    auto always_try_clean_up = util::make_scope_exit([&]() noexcept {
        std::string path_to_clean = reset_config.fresh_copy->get_path();
        try {
            reset_config.fresh_copy->close();
            constexpr bool delete_lockfile = true;
            DB::delete_files(path_to_clean, nullptr, delete_lockfile);
        }
        catch (const std::exception& err) {
            logger.warn(util::LogCategory::reset,
                        "In ClientResetOperation::finalize, the fresh copy '%1' could not be cleaned up due to "
                        "an exception: '%2'",
                        path_to_clean, err.what());
            // ignored, this is just a best effort
        }
    });

    // only do the reset if there is data to reset
    // if there is nothing in this Realm, then there is nothing to reset and
    // sync should be able to continue as normal
    auto latest_version = db.get_version_id_of_latest_snapshot();
    bool local_realm_exists = latest_version.version > 1;
    if (!local_realm_exists) {
        logger.debug(util::LogCategory::reset,
                     "Local Realm file has never been written to, so skipping client reset.");
        return false;
    }

    auto notify_before = std::move(reset_config.notify_before_client_reset);
    auto notify_after = std::move(reset_config.notify_after_client_reset);

    VersionID frozen_before_state_version = notify_before ? notify_before() : latest_version;

    // If m_notify_after is set, pin the previous state to keep it around.
    TransactionRef previous_state;
    if (notify_after) {
        previous_state = db.start_frozen(frozen_before_state_version);
    }
    bool did_recover = client_reset::perform_client_reset_diff(db, reset_config, logger, sub_store); // throws

    if (notify_after) {
        notify_after(previous_state->get_version_of_current_transaction(), did_recover);
    }

    return true;
}

} // namespace realm::_impl::client_reset

1	/*************************************************************************
2	*
3	* Copyright 2021 Realm Inc.
4	*
5	* Licensed under the Apache License, Version 2.0 (the "License");
6	* you may not use this file except in compliance with the License.
7	* You may obtain a copy of the License at
8	*
9	* http://www.apache.org/licenses/LICENSE-2.0
10	*
11	* Unless required by applicable law or agreed to in writing, software
12	* distributed under the License is distributed on an "AS IS" BASIS,
13	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	* See the License for the specific language governing permissions and
15	* limitations under the License.
16	*
17	**************************************************************************/
18
19	#include <realm/sync/noinst/client_reset_operation.hpp>
20
21	#include <realm/sync/history.hpp>
22	#include <realm/sync/noinst/client_history_impl.hpp>
23	#include <realm/sync/noinst/client_reset.hpp>
24	#include <realm/transaction.hpp>
25	#include <realm/util/scope_exit.hpp>
26
27	namespace realm::_impl::client_reset {
28
29	namespace {
30
31	constexpr static std::string_view c_fresh_suffix(".fresh");
32
33	} // namespace
34
35	std::string get_fresh_path_for(const std::string& path)
36	{	88,002✔
37	const size_t suffix_len = c_fresh_suffix.size();	88,002✔
38	REALM_ASSERT(path.length());	88,002✔
39	REALM_ASSERT_DEBUG_EX(	88,002✔
40	path.size() < suffix_len \|\| path.substr(path.size() - suffix_len, suffix_len) != c_fresh_suffix, path);	88,002✔
41	return path + c_fresh_suffix.data();	88,002✔
42	}	88,002✔
43
44	bool is_fresh_path(const std::string& path)
45	{	8,634✔
46	const size_t suffix_len = c_fresh_suffix.size();	8,634✔
47	REALM_ASSERT(path.length());	8,634✔
48	if (path.size() < suffix_len) {	8,634✔
49	return false;	×
50	}	×
51	return path.substr(path.size() - suffix_len, suffix_len) == c_fresh_suffix;	8,634✔
52	}	8,634✔
53
54	bool perform_client_reset(util::Logger& logger, DB& db, sync::ClientReset&& reset_config,
55	sync::SubscriptionStore* sub_store)
56	{	520✔
57	REALM_ASSERT(reset_config.mode != ClientResyncMode::Manual);	520✔
58	REALM_ASSERT(reset_config.fresh_copy);	520✔
59	logger.debug(util::LogCategory::reset,	520✔
60	"Possibly beginning client reset operation: realm_path = %1, mode = %2, action = %3, error = %4",	520✔
61	db.get_path(), reset_config.mode, reset_config.action, reset_config.error);	520✔
62
63	auto always_try_clean_up = util::make_scope_exit([&]() noexcept {	520✔
64	std::string path_to_clean = reset_config.fresh_copy->get_path();	520✔
65	try {	520✔
66	reset_config.fresh_copy->close();	520✔
67	constexpr bool delete_lockfile = true;	520✔
68	DB::delete_files(path_to_clean, nullptr, delete_lockfile);	520✔
69	}	520✔
70	catch (const std::exception& err) {	520✔
UNCOV 71	logger.warn(util::LogCategory::reset,	×
UNCOV 72	"In ClientResetOperation::finalize, the fresh copy '%1' could not be cleaned up due to "	×
UNCOV 73	"an exception: '%2'",	×
UNCOV 74	path_to_clean, err.what());	×
75	// ignored, this is just a best effort
UNCOV 76	}	×
77	});	520✔
78
79	// only do the reset if there is data to reset
80	// if there is nothing in this Realm, then there is nothing to reset and
81	// sync should be able to continue as normal
82	auto latest_version = db.get_version_id_of_latest_snapshot();	520✔
83	bool local_realm_exists = latest_version.version > 1;	520✔
84	if (!local_realm_exists) {	520✔
85	logger.debug(util::LogCategory::reset,	4✔
86	"Local Realm file has never been written to, so skipping client reset.");	4✔
87	return false;	4✔
88	}	4✔
89
90	auto notify_before = std::move(reset_config.notify_before_client_reset);	516✔
91	auto notify_after = std::move(reset_config.notify_after_client_reset);	516✔
92
93	VersionID frozen_before_state_version = notify_before ? notify_before() : latest_version;	516✔
94
95	// If m_notify_after is set, pin the previous state to keep it around.
96	TransactionRef previous_state;	516✔
97	if (notify_after) {	516✔
98	previous_state = db.start_frozen(frozen_before_state_version);	312✔
99	}	312✔
100	bool did_recover = client_reset::perform_client_reset_diff(db, reset_config, logger, sub_store); // throws	516✔
101
102	if (notify_after) {	516✔
103	notify_after(previous_state->get_version_of_current_transaction(), did_recover);	252✔
104	}	252✔
105
106	return true;	516✔
107	}	520✔
108
109	} // namespace realm::_impl::client_reset

realm / realm-core / jorgen.edelbo_396

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous