10396278539

Committed 14 Aug 2024 11:19PM UTC coverage: 32.204% (+0.002%) from 32.202%

Build # 10396278539

Build Type

Pull #9585

github

Committed by

jimrandomh

Commit Message

Undrafting a post ensures the latest contents revision is non-draft and has a non-0.x version number

Co-Authored-By: Robert M <bobert.mushky@gmail.com>

Pull Request Pull Request #9585: Undrafting a post ensures the latest contents revision is non-draft and has a non-0.x version number

Run Details

5015 of 40287 branches covered (12.45%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

18 existing lines in 1 file now uncovered.

28950 of 65181 relevant lines covered (44.41%)

190.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

27.27

/packages/lesswrong/server/fmCrosspost/requestHandlers.ts

import type { Request } from "express";
import Posts from "../../lib/collections/posts/collection";
import Users from "../../lib/collections/users/collection";
import { getGraphQLQueryFromOptions, getResolverNameFromOptions } from "../../lib/crud/withSingle";
import { Utils } from "../../lib/vulcan-lib";
import { createClient } from "../vulcan-lib/apollo-ssr/apolloClient";
import { createAnonymousContext } from "../vulcan-lib/query";
import { extractDenormalizedData } from "./denormalizedFields";
import { InvalidUserError, UnauthorizedError } from "./errors";
import { validateCrosspostingKarmaThreshold } from "./helpers";
import type { GetRouteOf, PostRouteOf } from "./routes";
import { signToken, verifyToken } from "./tokens";
import {
  ConnectCrossposterPayload, ConnectCrossposterPayloadValidator, CrosspostPayloadValidator, UnlinkCrossposterPayloadValidator, UpdateCrosspostPayloadValidator
} from "./types";

export const onCrosspostTokenRequest: GetRouteOf<'crosspostToken'> = async (req: Request) => {
  const {user} = req;
  if (!user) {
    throw new UnauthorizedError();
  }

  // Throws an error if user doesn't have enough karma on the source forum (which is the current execution environment)
  validateCrosspostingKarmaThreshold(user);

  const token = await signToken<ConnectCrossposterPayload>({ userId: user._id });
  return {token};
};

export const onConnectCrossposterRequest: PostRouteOf<'connectCrossposter'> = async (req) => {
  const { token, localUserId } = req;
  const payload = await verifyToken(token, ConnectCrossposterPayloadValidator.is);
  const {userId: foreignUserId} = payload;
  await Users.rawUpdateOne({_id: foreignUserId}, {
    $set: {fmCrosspostUserId: localUserId},
  });
  return {
    status: "connected",
    foreignUserId,
    localUserId,
  };
};

export const onUnlinkCrossposterRequest: PostRouteOf<'unlinkCrossposter'> = async (req) => {
  const { token } = req;
  const payload = await verifyToken(token, UnlinkCrossposterPayloadValidator.is);
  const {userId} = payload;
  await Users.rawUpdateOne({_id: userId}, {
    $unset: {fmCrosspostUserId: ""},
  });
  return { status: 'unlinked' };
};

export const onCrosspostRequest: PostRouteOf<'crosspost'> = async (req) => {
  const { token } = req;
  const payload = await verifyToken(token, CrosspostPayloadValidator.is);
  const {localUserId, foreignUserId, postId, ...rest} = payload;
  const denormalizedData = extractDenormalizedData(rest);

  const user = await Users.findOne({_id: foreignUserId});
  if (!user || user.fmCrosspostUserId !== localUserId) {
    throw new InvalidUserError();
  }

  /**
   * TODO: Null is made legal value for fields but database types are incorrectly generated without null. 
   * Hacky fix for now. Search 84b2 to find all instances of this casting.
   */
  const document: Partial<DbPost> = {
    userId: user._id,
    fmCrosspost: {
      isCrosspost: true,
      hostedHere: false,
      foreignPostId: postId,
    },
    ...denormalizedData,
  } as Partial<DbPost>;

  const {data: post} = await Utils.createMutator({
    document,
    collection: Posts,
    validate: false,
    currentUser: user,
    // This is a hack - we have only a fraction of the necessary information for
    // a context. But it appears to be working.
    context: {
      currentUser: user,
      isFMCrosspostRequest: true,
      Users,
    } as Partial<ResolverContext> as  ResolverContext,
  });

  return {
    status: "posted",
    postId: post._id,
  };
};

//TODO: clean up typecast `as Partial<DbPost>` below, Code: 84b2
export const onUpdateCrosspostRequest: PostRouteOf<'updateCrosspost'> = async (req) => {
  const { token } = req;
  const {postId, ...rest} = await verifyToken(token, UpdateCrosspostPayloadValidator.is);
  const denormalizedData: Partial<DbPost> = extractDenormalizedData(rest) as Partial<DbPost>;
  await Posts.rawUpdateOne({_id: postId}, {$set: denormalizedData});
  return { status: 'updated' };
};

export const onGetCrosspostRequest: PostRouteOf<'getCrosspost'> = async (req) => {
  const { collectionName, extraVariables, extraVariablesValues, fragmentName, documentId } = req;
  const apolloClient = await createClient(createAnonymousContext());
  const query = getGraphQLQueryFromOptions({
    extraVariables,
    collectionName,
    fragmentName,
    fragment: undefined,
  });
  const resolverName = getResolverNameFromOptions(collectionName);

  const { data } = await apolloClient.query({
    query,
    variables: {
      input: {
        selector: { documentId }
      },
      ...extraVariablesValues
    },
  });

  const document = data?.[resolverName]?.result;

  return { document };
};

1	import type { Request } from "express";	54✔
2	import Posts from "../../lib/collections/posts/collection";	18✔
3	import Users from "../../lib/collections/users/collection";	18✔
4	import { getGraphQLQueryFromOptions, getResolverNameFromOptions } from "../../lib/crud/withSingle";	18✔
5	import { Utils } from "../../lib/vulcan-lib";	18✔
6	import { createClient } from "../vulcan-lib/apollo-ssr/apolloClient";	18✔
7	import { createAnonymousContext } from "../vulcan-lib/query";	18✔
8	import { extractDenormalizedData } from "./denormalizedFields";	18✔
9	import { InvalidUserError, UnauthorizedError } from "./errors";	18✔
10	import { validateCrosspostingKarmaThreshold } from "./helpers";	18✔
11	import type { GetRouteOf, PostRouteOf } from "./routes";
12	import { signToken, verifyToken } from "./tokens";	18✔
13	import {
14	ConnectCrossposterPayload, ConnectCrossposterPayloadValidator, CrosspostPayloadValidator, UnlinkCrossposterPayloadValidator, UpdateCrosspostPayloadValidator
15	} from "./types";	18✔
16
17	export const onCrosspostTokenRequest: GetRouteOf<'crosspostToken'> = async (req: Request) => {	18✔
UNCOV 18	const {user} = req;	×
19	if (!user) {	×
20	throw new UnauthorizedError();	×
21	}
22
23	// Throws an error if user doesn't have enough karma on the source forum (which is the current execution environment)
UNCOV 24	validateCrosspostingKarmaThreshold(user);	×
25
UNCOV 26	const token = await signToken<ConnectCrossposterPayload>({ userId: user._id });	×
27	return {token};	×
28	};
29
30	export const onConnectCrossposterRequest: PostRouteOf<'connectCrossposter'> = async (req) => {	18✔
UNCOV 31	const { token, localUserId } = req;	×
32	const payload = await verifyToken(token, ConnectCrossposterPayloadValidator.is);	×
33	const {userId: foreignUserId} = payload;	×
34	await Users.rawUpdateOne({_id: foreignUserId}, {	×
35	$set: {fmCrosspostUserId: localUserId},
36	});
UNCOV 37	return {	×
38	status: "connected",
39	foreignUserId,
40	localUserId,
41	};
42	};
43
44	export const onUnlinkCrossposterRequest: PostRouteOf<'unlinkCrossposter'> = async (req) => {	18✔
UNCOV 45	const { token } = req;	×
46	const payload = await verifyToken(token, UnlinkCrossposterPayloadValidator.is);	×
47	const {userId} = payload;	×
48	await Users.rawUpdateOne({_id: userId}, {	×
49	$unset: {fmCrosspostUserId: ""},
50	});
UNCOV 51	return { status: 'unlinked' };	×
52	};
53
54	export const onCrosspostRequest: PostRouteOf<'crosspost'> = async (req) => {	18✔
UNCOV 55	const { token } = req;	×
56	const payload = await verifyToken(token, CrosspostPayloadValidator.is);	×
57	const {localUserId, foreignUserId, postId, ...rest} = payload;	×
58	const denormalizedData = extractDenormalizedData(rest);	×
59
UNCOV 60	const user = await Users.findOne({_id: foreignUserId});	×
61	if (!user \|\| user.fmCrosspostUserId !== localUserId) {	×
62	throw new InvalidUserError();	×
63	}
64
65	/**
66	* TODO: Null is made legal value for fields but database types are incorrectly generated without null.
67	* Hacky fix for now. Search 84b2 to find all instances of this casting.
68	*/
UNCOV 69	const document: Partial<DbPost> = {	×
70	userId: user._id,
71	fmCrosspost: {
72	isCrosspost: true,
73	hostedHere: false,
74	foreignPostId: postId,
75	},
76	...denormalizedData,
77	} as Partial<DbPost>;
78
UNCOV 79	const {data: post} = await Utils.createMutator({	×
80	document,
81	collection: Posts,
82	validate: false,
83	currentUser: user,
84	// This is a hack - we have only a fraction of the necessary information for
85	// a context. But it appears to be working.
86	context: {
87	currentUser: user,
88	isFMCrosspostRequest: true,
89	Users,
90	} as Partial<ResolverContext> as ResolverContext,
91	});
92
UNCOV 93	return {	×
94	status: "posted",
95	postId: post._id,
96	};
97	};
98
99	//TODO: clean up typecast `as Partial<DbPost>` below, Code: 84b2
100	export const onUpdateCrosspostRequest: PostRouteOf<'updateCrosspost'> = async (req) => {	18✔
UNCOV 101	const { token } = req;	×
UNCOV 102	const {postId, ...rest} = await verifyToken(token, UpdateCrosspostPayloadValidator.is);	×
103	const denormalizedData: Partial<DbPost> = extractDenormalizedData(rest) as Partial<DbPost>;	×
104	await Posts.rawUpdateOne({_id: postId}, {$set: denormalizedData});	×
105	return { status: 'updated' };	×
106	};
107
108	export const onGetCrosspostRequest: PostRouteOf<'getCrosspost'> = async (req) => {	18✔
UNCOV 109	const { collectionName, extraVariables, extraVariablesValues, fragmentName, documentId } = req;	×
UNCOV 110	const apolloClient = await createClient(createAnonymousContext());	×
111	const query = getGraphQLQueryFromOptions({	×
112	extraVariables,
113	collectionName,
114	fragmentName,
115	fragment: undefined,
116	});
UNCOV 117	const resolverName = getResolverNameFromOptions(collectionName);	×
118
119	const { data } = await apolloClient.query({	×
120	query,
121	variables: {
122	input: {
123	selector: { documentId }
124	},
125	...extraVariablesValues
126	},
127	});
128
UNCOV 129	const document = data?.[resolverName]?.result;	×
130
131	return { document };	×
132	};

ForumMagnum / ForumMagnum / 10396278539

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous