10383405535

Committed 14 Aug 2024 07:36AM UTC coverage: 32.193% (+0.2%) from 32.024%

Build # 10383405535

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9301 from ForumMagnum/normalized-posts-contents

Normalized posts contents

Run Details

5010 of 40238 branches covered (12.45%)

Branch coverage included in aggregate %.

132 of 244 new or added lines in 43 files covered. (54.1%)

11 existing lines in 10 files now uncovered.

28908 of 65121 relevant lines covered (44.39%)

190.7 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

22.58

/packages/lesswrong/components/posts/NewDialogueDialog.tsx

import React, { useState } from 'react';
import { Components, registerComponent } from "../../lib/vulcan-lib";
import Button from '@material-ui/core/Button';
import DialogActions from '@material-ui/core/DialogActions';
import { useCreate } from '../../lib/crud/withCreate';
import { useMessages } from '../common/withMessages';
import Input from '@material-ui/core/Input';
import { useNavigate } from '../../lib/reactRouterWrapper';
import { isFriendlyUI, preferredHeadingCase } from '../../themes/forumTheme';

const styles = (theme: ThemeType): JssStyles => ({
  dialog: {
    padding: 24,
    paddingBottom: isFriendlyUI ? undefined : 12,
    fontFamily: theme.typography.fontFamily,
    color: theme.palette.text.normal,
    "& .MuiDialogActions-root": {
      margin: isFriendlyUI ? 0 : undefined,
    },
  },
  inputRow: {
    marginBottom: 12,
  },
  label: {
    ...theme.typography.body2,
    display: "inline-block",
  },
  titleInput: {
    ...theme.typography.body1,
    ...theme.typography.headerStyle,
    marginTop: 12,
    width: 400,
  },
  userMultiselect: {
    marginTop: 12,
    display: "inline-block",
  },
  header: {
    ...theme.typography.headerStyle,
    marginTop: 0
  },
  info: {
    ...theme.typography.body2,
    marginRight: 12
  }
})

const NewDialogueDialog = ({onClose, classes}: {
  onClose: () => void,
  classes: ClassesType,
}) => {
  const { UserMultiselect, LWDialog, Loading, EAButton } = Components;
  const [title, setTitle] = useState("");
  const {flash} = useMessages();
  const [participants, setParticipants] = useState<string[]>([]);
  const {create: createPost, loading} = useCreate({ collectionName: "Posts", fragmentName: "PostsEdit" });
  const navigate = useNavigate();

  async function createDialogue() {
    if (loading) return;
    if (!title.length) {
      flash("You must choose a title");
      return;
    }
    const createResult = await createPost({
      data: {
        title,
        draft: true,
        collabEditorDialogue: true,
        coauthorStatuses: participants.map(userId => ({userId, confirmed: true, requested: false})),
        shareWithUsers: participants,
        sharingSettings: {
          anyoneWithLinkCan: "none",
          explicitlySharedUsersCan: "edit",
        },
        // Contents is a resolver only field, but there is handling for it
        // in `createMutator`/`updateMutator`
        ...({
          contents: {
            originalContents: {
              type: "ckEditorMarkup",
              data: ""
            }
          },
        }) as AnyBecauseHard,
      },
    });
    if (createResult?.data?.createPost?.data) {
      const post = createResult?.data?.createPost?.data;
      if (post) {
        const postId = post._id;
        const postEditUrl = `/editPost?postId=${postId}`;
        navigate(postEditUrl);
        onClose();
      }
    }
  }

  const ButtonComponent = isFriendlyUI ? EAButton : Button;
  return <LWDialog
    open={true}
    onClose={onClose}
    fullWidth
    maxWidth={"sm"}
    dialogClasses={{paper: classes.dialogPaper}}
  >
    <div className={classes.dialog}>
      <h2 className={classes.header}>{preferredHeadingCase("Start Dialogue")}</h2>
      <p className={classes.info}>
        Invite users to a conversation where you can explore ideas, interview each other, or debate a topic. You can edit the transcript, and when you're ready, publish it as a post.
      </p>
      <p className={classes.info}>
        You'll be able to see each other's comments as you're writing.
      </p>
      <Input
        type="text"
        placeholder={preferredHeadingCase("Dialogue Title")}
        value={title}
        className={classes.titleInput}
        onChange={ev => setTitle(ev.currentTarget.value)}
      />
      <div className={classes.userMultiselect}>
        <UserMultiselect
          value={participants}
          setValue={setParticipants}
          label={preferredHeadingCase("Add Participants")}
        />
      </div>

      <DialogActions>
        {loading && <Loading/>}
        <ButtonComponent onClick={createDialogue} disabled={!!loading}>
          {preferredHeadingCase("Create Dialogue")}
        </ButtonComponent>
      </DialogActions>
    </div>
  </LWDialog>
}

const NewDialogueDialogComponent = registerComponent('NewDialogueDialog', NewDialogueDialog, {styles});

declare global {
  interface ComponentTypes {
    NewDialogueDialog: typeof NewDialogueDialogComponent
  }
}

1	import React, { useState } from 'react';	1✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3	import Button from '@material-ui/core/Button';	1✔
4	import DialogActions from '@material-ui/core/DialogActions';	1✔
5	import { useCreate } from '../../lib/crud/withCreate';	1✔
6	import { useMessages } from '../common/withMessages';	1✔
7	import Input from '@material-ui/core/Input';	1✔
8	import { useNavigate } from '../../lib/reactRouterWrapper';	1✔
9	import { isFriendlyUI, preferredHeadingCase } from '../../themes/forumTheme';	1✔
10
11	const styles = (theme: ThemeType): JssStyles => ({	1✔
12	dialog: {
13	padding: 24,
14	paddingBottom: isFriendlyUI ? undefined : 12,	1!
15	fontFamily: theme.typography.fontFamily,
16	color: theme.palette.text.normal,
17	"& .MuiDialogActions-root": {
18	margin: isFriendlyUI ? 0 : undefined,	1!
19	},
20	},
21	inputRow: {
22	marginBottom: 12,
23	},
24	label: {
25	...theme.typography.body2,
26	display: "inline-block",
27	},
28	titleInput: {
29	...theme.typography.body1,
30	...theme.typography.headerStyle,
31	marginTop: 12,
32	width: 400,
33	},
34	userMultiselect: {
35	marginTop: 12,
36	display: "inline-block",
37	},
38	header: {
39	...theme.typography.headerStyle,
40	marginTop: 0
41	},
42	info: {
43	...theme.typography.body2,
44	marginRight: 12
45	}
46	})
47
48	const NewDialogueDialog = ({onClose, classes}: {	1✔
49	onClose: () => void,
50	classes: ClassesType,
51	}) => {
52	const { UserMultiselect, LWDialog, Loading, EAButton } = Components;	×
53	const [title, setTitle] = useState("");	×
54	const {flash} = useMessages();	×
55	const [participants, setParticipants] = useState<string[]>([]);	×
NEW 56	const {create: createPost, loading} = useCreate({ collectionName: "Posts", fragmentName: "PostsEdit" });	×
57	const navigate = useNavigate();	×
58
59	async function createDialogue() {
60	if (loading) return;	×
61	if (!title.length) {	×
62	flash("You must choose a title");	×
63	return;	×
64	}
65	const createResult = await createPost({	×
66	data: {
67	title,
68	draft: true,
69	collabEditorDialogue: true,
70	coauthorStatuses: participants.map(userId => ({userId, confirmed: true, requested: false})),	×
71	shareWithUsers: participants,
72	sharingSettings: {
73	anyoneWithLinkCan: "none",
74	explicitlySharedUsersCan: "edit",
75	},
76	// Contents is a resolver only field, but there is handling for it
77	// in `createMutator`/`updateMutator`
78	...({
79	contents: {
80	originalContents: {
81	type: "ckEditorMarkup",
82	data: ""
83	}
84	},
85	}) as AnyBecauseHard,
86	},
87	});
88	if (createResult?.data?.createPost?.data) {	×
89	const post = createResult?.data?.createPost?.data;	×
90	if (post) {	×
91	const postId = post._id;	×
92	const postEditUrl = `/editPost?postId=${postId}`;	×
93	navigate(postEditUrl);	×
94	onClose();	×
95	}
96	}
97	}
98
99	const ButtonComponent = isFriendlyUI ? EAButton : Button;	×
100	return <LWDialog	×
101	open={true}
102	onClose={onClose}
103	fullWidth
104	maxWidth={"sm"}
105	dialogClasses={{paper: classes.dialogPaper}}
106	>
107	<div className={classes.dialog}>
108	<h2 className={classes.header}>{preferredHeadingCase("Start Dialogue")}</h2>
109	<p className={classes.info}>
110	Invite users to a conversation where you can explore ideas, interview each other, or debate a topic. You can edit the transcript, and when you're ready, publish it as a post.
111	</p>
112	<p className={classes.info}>
113	You'll be able to see each other's comments as you're writing.
114	</p>
115	<Input
116	type="text"
117	placeholder={preferredHeadingCase("Dialogue Title")}
118	value={title}
119	className={classes.titleInput}
120	onChange={ev => setTitle(ev.currentTarget.value)}	×
121	/>
122	<div className={classes.userMultiselect}>
123	<UserMultiselect
124	value={participants}
125	setValue={setParticipants}
126	label={preferredHeadingCase("Add Participants")}
127	/>
128	</div>
129
130	<DialogActions>
131	{loading && <Loading/>}	×
132	<ButtonComponent onClick={createDialogue} disabled={!!loading}>
133	{preferredHeadingCase("Create Dialogue")}
134	</ButtonComponent>
135	</DialogActions>
136	</div>
137	</LWDialog>
138	}
139
140	const NewDialogueDialogComponent = registerComponent('NewDialogueDialog', NewDialogueDialog, {styles});	1✔
141
142	declare global {
143	interface ComponentTypes {
144	NewDialogueDialog: typeof NewDialogueDialogComponent
145	}
146	}

ForumMagnum / ForumMagnum / 10383405535

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous