6a8770b120f3d930965dd99df3ab2f6080487345

Committed 12 Aug 2024 01:59PM UTC coverage: 51.02% (-0.005%) from 51.025%

Build # 6a8770b120f3d930965dd99df3ab2f6080487345

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #21524 from Yoast/7203-wordpress-link-button-does-not-recognize-primary-category-permalink

Add admin-ajax to conditional to rework permalinks based on primary category

Run Details

0 of 4 new or added lines in 1 file covered. (0.0%)

16230 of 31811 relevant lines covered (51.02%)

3.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/conditionals/primary-category-conditional.php

<?php

namespace Yoast\WP\SEO\Conditionals;

use Yoast\WP\SEO\Helpers\Current_Page_Helper;

/**
 * Conditional that is only met when in frontend or page is a post overview or post add/edit form.
 */
class Primary_Category_Conditional implements Conditional {

        /**
         * The current page helper.
         *
         * @var Current_Page_Helper
         */
        private $current_page;

        /**
         * Primary_Category_Conditional constructor.
         *
         * @param Current_Page_Helper $current_page The current page helper.
         */
        public function __construct( Current_Page_Helper $current_page ) {
                $this->current_page = $current_page;
        }

        /**
         * Returns `true` when on the frontend,
         * or when on the post overview, post edit or new post admin page,
         * or when on additional admin pages, allowed by filter.
         *
         * @return bool `true` when on the frontend, or when on the post overview,
         *          post edit, new post admin page or additional admin pages, allowed by filter.
         */
        public function is_met() {

                if ( ! \is_admin() ) {
                        return true;
                }

                $current_page = $this->current_page->get_current_admin_page();
                // phpcs:ignore WordPress.Security.NonceVerification.Missing -- Reason: We are not processing form information.
                if ( $current_page === 'admin-ajax.php' && isset( $_POST['action'] ) && $_POST['action'] === 'wp-link-ajax' ) {
                        return true;
                }

                /**
                 * Filter: Adds the possibility to use primary category at additional admin pages.
                 *
                 * @param array $admin_pages List of additional admin pages.
                 */
                $additional_pages = \apply_filters( 'wpseo_primary_category_admin_pages', [] );
                return \in_array( $current_page, \array_merge( [ 'edit.php', 'post.php', 'post-new.php' ], $additional_pages ), true );
        }
}

1	<?php
2
3	namespace Yoast\WP\SEO\Conditionals;
4
5	use Yoast\WP\SEO\Helpers\Current_Page_Helper;
6
7	/**
8	* Conditional that is only met when in frontend or page is a post overview or post add/edit form.
9	*/
10	class Primary_Category_Conditional implements Conditional {
11
12	/**
13	* The current page helper.
14	*
15	* @var Current_Page_Helper
16	*/
17	private $current_page;
18
19	/**
20	* Primary_Category_Conditional constructor.
21	*
22	* @param Current_Page_Helper $current_page The current page helper.
23	*/
24	public function __construct( Current_Page_Helper $current_page ) {	×
25	$this->current_page = $current_page;	×
26	}
27
28	/**
29	* Returns `true` when on the frontend,
30	* or when on the post overview, post edit or new post admin page,
31	* or when on additional admin pages, allowed by filter.
32	*
33	* @return bool `true` when on the frontend, or when on the post overview,
34	* post edit, new post admin page or additional admin pages, allowed by filter.
35	*/
36	public function is_met() {	×
37
38	if ( ! \is_admin() ) {	×
39	return true;	×
40	}
41
NEW 42	$current_page = $this->current_page->get_current_admin_page();	×
43	// phpcs:ignore WordPress.Security.NonceVerification.Missing -- Reason: We are not processing form information.
NEW 44	if ( $current_page === 'admin-ajax.php' && isset( $_POST['action'] ) && $_POST['action'] === 'wp-link-ajax' ) {	×
NEW 45	return true;	×
46	}
47
48	/**
49	* Filter: Adds the possibility to use primary category at additional admin pages.
50	*
51	* @param array $admin_pages List of additional admin pages.
52	*/
53	$additional_pages = \apply_filters( 'wpseo_primary_category_admin_pages', [] );	×
NEW 54	return \in_array( $current_page, \array_merge( [ 'edit.php', 'post.php', 'post-new.php' ], $additional_pages ), true );	×
55	}
56	}

Yoast / wordpress-seo / 6a8770b120f3d930965dd99df3ab2f6080487345

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous