10290937703

Committed 07 Aug 2024 08:02PM UTC coverage: 66.609% (-0.07%) from 66.682%

Build # 10290937703

Build Type

Pull #2274

github

Committed by

web-flow

Commit Message

feat: set valid beneficiary (#2281)

Pull Request Pull Request #2274: feat: offchain bids

Run Details

2655 of 5178 branches covered (51.27%)

Branch coverage included in aggregate %.

157 of 257 new or added lines in 29 files covered. (61.09%)

2 existing lines in 2 files now uncovered.

7780 of 10488 relevant lines covered (74.18%)

78.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

46.67

/webapp/src/modules/vendor/decentraland/TradeService.ts

import { Trade, TradeCreation } from '@dcl/schemas'
import { sendTransaction } from 'decentraland-dapps/dist/modules/wallet/utils'
import { AuthIdentity } from 'decentraland-crypto-fetch'
import { ContractName, getContract } from 'decentraland-transactions'
import { getOnChainTrade } from '../../../utils/trades'
import { TradeService as TradeServiceInterface } from '../services'
import { MARKETPLACE_SERVER_URL } from './nft'
import { TradesAPI } from './trades/api'

export class TradeService implements TradeServiceInterface {
  private tradesAPI: TradesAPI

  constructor(getIdentity: () => AuthIdentity | undefined) {
    this.tradesAPI = new TradesAPI(MARKETPLACE_SERVER_URL, { identity: getIdentity, retries: 0 })
  }

  async addTrade(trade: TradeCreation) {
    return this.tradesAPI.addTrade(trade)
  }

  async fetchTrade(tradeId: string) {
    return this.tradesAPI.fetchTrade(tradeId)
  }

  async accept(trade: Trade, sentBeneficiaryAddress: string) {
    const offchainMarketplaceContract = getContract(ContractName.OffChainMarketplace, trade.chainId)
    const tradeToAccept = getOnChainTrade(trade, sentBeneficiaryAddress)
    return sendTransaction(offchainMarketplaceContract, 'accept', [tradeToAccept])
  }

  async cancel(trade: Trade, sentBeneficiaryAddress: string) {
    const offchainMarketplaceContract = getContract(ContractName.OffChainMarketplace, trade.chainId)
    const tradeToCancel = getOnChainTrade(trade, sentBeneficiaryAddress)
    return sendTransaction(offchainMarketplaceContract, 'cancelSignature', [tradeToCancel])
  }
}

1	import { Trade, TradeCreation } from '@dcl/schemas'
2	import { sendTransaction } from 'decentraland-dapps/dist/modules/wallet/utils'	32✔
3	import { AuthIdentity } from 'decentraland-crypto-fetch'
4	import { ContractName, getContract } from 'decentraland-transactions'	32✔
5	import { getOnChainTrade } from '../../../utils/trades'	32✔
6	import { TradeService as TradeServiceInterface } from '../services'
7	import { MARKETPLACE_SERVER_URL } from './nft'	32✔
8	import { TradesAPI } from './trades/api'	32✔
9
10	export class TradeService implements TradeServiceInterface {	274✔
11	private tradesAPI: TradesAPI
12
13	constructor(getIdentity: () => AuthIdentity \| undefined) {
14	this.tradesAPI = new TradesAPI(MARKETPLACE_SERVER_URL, { identity: getIdentity, retries: 0 })	274✔
15	}
16
17	async addTrade(trade: TradeCreation) {
NEW 18	return this.tradesAPI.addTrade(trade)	×
19	}
20
21	async fetchTrade(tradeId: string) {
NEW 22	return this.tradesAPI.fetchTrade(tradeId)	×
23	}
24
25	async accept(trade: Trade, sentBeneficiaryAddress: string) {
NEW 26	const offchainMarketplaceContract = getContract(ContractName.OffChainMarketplace, trade.chainId)	×
NEW 27	const tradeToAccept = getOnChainTrade(trade, sentBeneficiaryAddress)	×
NEW 28	return sendTransaction(offchainMarketplaceContract, 'accept', [tradeToAccept])	×
29	}
30
31	async cancel(trade: Trade, sentBeneficiaryAddress: string) {
NEW 32	const offchainMarketplaceContract = getContract(ContractName.OffChainMarketplace, trade.chainId)	×
NEW 33	const tradeToCancel = getOnChainTrade(trade, sentBeneficiaryAddress)	×
NEW 34	return sendTransaction(offchainMarketplaceContract, 'cancelSignature', [tradeToCancel])	×
35	}
36	}

decentraland / marketplace / 10290937703

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous