10274492512

Committed 06 Aug 2024 09:56PM UTC coverage: 32.033% (-0.008%) from 32.041%

Build # 10274492512

Build Type

Pull #9570

github

Committed by

darkruby501

Commit Message

fix typescript errors from typing ls local storage

Pull Request Pull Request #9570: LLM Chat Interface (& RAG) Integration into LW

Run Details

4936 of 40131 branches covered (12.3%)

Branch coverage included in aggregate %.

37 of 161 new or added lines in 18 files covered. (22.98%)

391 existing lines in 14 files now uncovered.

28761 of 65065 relevant lines covered (44.2%)

180.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

11.25

/packages/lesswrong/components/ea-forum/digestAd/useDigestAd.ts

import { useCallback, useRef, useState } from "react";
import { useCurrentUser } from "../../common/withUser";
import { useUpdateCurrentUser } from "../../hooks/useUpdateCurrentUser";
import { getBrowserLocalStorage } from "../../editor/localStorageHandlers";
import { useMessages } from "../../common/withMessages";
import { useTracking } from "../../../lib/analyticsEvents";
import { hasDigests } from "../../../lib/betas";
import { userHasEmailAddress } from "../../../lib/collections/users/helpers";

/**
 * Handles some shared logic around the EA Forum digest ad:
 * in particular, logged in vs logged out forms function differently.
 *
 * This has some functionality overlap with the Forum Digest ad that appears in "Recent discussion".
 * Specifically, both components use currentUser.hideSubscribePoke,
 * so for logged in users, hiding one ad hides the other.
 * See RecentDiscussionSubscribeReminder.tsx for the other component.
 */
export const useDigestAd = () => {
  const currentUser = useCurrentUser()
  const updateCurrentUser = useUpdateCurrentUser()
  const emailRef = useRef<HTMLInputElement|null>(null)
  const ls = getBrowserLocalStorage()
  const [isHidden, setIsHidden] = useState(
    // logged out user clicked the X in this ad, or previously submitted the form
    (!currentUser && ls?.getItem('hideHomeDigestAd')) ||
    // user is already subscribed
    currentUser?.subscribedToDigest ||
    // user is logged in and clicked the X in this ad, or "Don't ask again" in the ad in "Recent discussion"
    currentUser?.hideSubscribePoke
  )
  const [loading, setLoading] = useState(false)
  const [subscribeClicked, setSubscribeClicked] = useState(false)
  const { flash } = useMessages()
  const { captureEvent } = useTracking()
  
  // If the user is logged in and has an email address, we show their email address and the "Subscribe" button.
  // Otherwise, we show the form with the email address input.
  const showForm = !currentUser || !userHasEmailAddress(currentUser)
  
  /**
   * Close the digest ad, and make sure it doesn't appear again
   */
  const handleClose = useCallback(() => {
    setIsHidden(true)
    captureEvent("digestAdClosed")
    if (currentUser) {
      void updateCurrentUser({hideSubscribePoke: true})
    } else {
      ls?.setItem('hideHomeDigestAd', 'true')
    }
  }, [setIsHidden, captureEvent, currentUser, updateCurrentUser, ls])
  
  /**
   * When the user clicks the "Sign up" button,
   * if they are logged in, subscribe them to the digest,
   * and if they are logged out, set hideHomeDigestAd
   */
  const handleUserSubscribe = useCallback(async () => {
    setLoading(true)
    setSubscribeClicked(true)
    captureEvent("digestAdSubscribed")
    
    if (currentUser) {
      try {
        await updateCurrentUser({
          subscribedToDigest: true
        })
      } catch(e) {
        setSubscribeClicked(false)
        flash('There was a problem subscribing you to the digest. Please try again later.')
      }
    }
    if (showForm && emailRef.current?.value) {
      ls?.setItem('hideHomeDigestAd', 'true')
    }
    
    setLoading(false)
  }, [setLoading, setSubscribeClicked, captureEvent, currentUser, updateCurrentUser, flash, showForm, ls])

  // Only show this on sites that have a digest
  if (!hasDigests) {
    return {
      showDigestAd: false,
    }
  }
  // Make sure we only show it to logged out users if they have the ability to hide it
  if (!currentUser && !ls) {
    return {
      showDigestAd: false,
    }
  }
  // If the user just submitted the form, make sure not to hide it, so that it properly finishes submitting.
  // Alternatively, if the logged in user just clicked "Subscribe", show the success text rather than hiding this.
  if (isHidden && !subscribeClicked) {
    return {
      showDigestAd: false,
    }
  }

  return {
    showDigestAd: true,
    emailRef,
    showForm,
    loading,
    subscribeClicked,
    handleClose,
    handleUserSubscribe
  }
}

1	import { useCallback, useRef, useState } from "react";	3✔
2	import { useCurrentUser } from "../../common/withUser";	1✔
3	import { useUpdateCurrentUser } from "../../hooks/useUpdateCurrentUser";	1✔
4	import { getBrowserLocalStorage } from "../../editor/localStorageHandlers";	1✔
5	import { useMessages } from "../../common/withMessages";	1✔
6	import { useTracking } from "../../../lib/analyticsEvents";	1✔
7	import { hasDigests } from "../../../lib/betas";	1✔
8	import { userHasEmailAddress } from "../../../lib/collections/users/helpers";	1✔
9
10	/**
11	* Handles some shared logic around the EA Forum digest ad:
12	* in particular, logged in vs logged out forms function differently.
13	*
14	* This has some functionality overlap with the Forum Digest ad that appears in "Recent discussion".
15	* Specifically, both components use currentUser.hideSubscribePoke,
16	* so for logged in users, hiding one ad hides the other.
17	* See RecentDiscussionSubscribeReminder.tsx for the other component.
18	*/
19	export const useDigestAd = () => {	1✔
20	const currentUser = useCurrentUser()	×
21	const updateCurrentUser = useUpdateCurrentUser()	×
22	const emailRef = useRef<HTMLInputElement\|null>(null)	×
23	const ls = getBrowserLocalStorage()	×
24	const [isHidden, setIsHidden] = useState(	×
25	// logged out user clicked the X in this ad, or previously submitted the form
26	(!currentUser && ls?.getItem('hideHomeDigestAd')) \|\|	×
27	// user is already subscribed
28	currentUser?.subscribedToDigest \|\|	×
29	// user is logged in and clicked the X in this ad, or "Don't ask again" in the ad in "Recent discussion"
30	currentUser?.hideSubscribePoke	×
31	)
32	const [loading, setLoading] = useState(false)	×
33	const [subscribeClicked, setSubscribeClicked] = useState(false)	×
34	const { flash } = useMessages()	×
35	const { captureEvent } = useTracking()	×
36
37	// If the user is logged in and has an email address, we show their email address and the "Subscribe" button.
38	// Otherwise, we show the form with the email address input.
39	const showForm = !currentUser \|\| !userHasEmailAddress(currentUser)	×
40
41	/**
42	* Close the digest ad, and make sure it doesn't appear again
43	*/
44	const handleClose = useCallback(() => {	×
45	setIsHidden(true)	×
46	captureEvent("digestAdClosed")	×
47	if (currentUser) {	×
48	void updateCurrentUser({hideSubscribePoke: true})	×
49	} else {
NEW 50	ls?.setItem('hideHomeDigestAd', 'true')	×
51	}
52	}, [setIsHidden, captureEvent, currentUser, updateCurrentUser, ls])
53
54	/**
55	* When the user clicks the "Sign up" button,
56	* if they are logged in, subscribe them to the digest,
57	* and if they are logged out, set hideHomeDigestAd
58	*/
59	const handleUserSubscribe = useCallback(async () => {	×
60	setLoading(true)	×
61	setSubscribeClicked(true)	×
62	captureEvent("digestAdSubscribed")	×
63
64	if (currentUser) {	×
65	try {	×
66	await updateCurrentUser({	×
67	subscribedToDigest: true
68	})
69	} catch(e) {
70	setSubscribeClicked(false)	×
71	flash('There was a problem subscribing you to the digest. Please try again later.')	×
72	}
73	}
74	if (showForm && emailRef.current?.value) {	×
NEW 75	ls?.setItem('hideHomeDigestAd', 'true')	×
76	}
77
78	setLoading(false)	×
79	}, [setLoading, setSubscribeClicked, captureEvent, currentUser, updateCurrentUser, flash, showForm, ls])
80
81	// Only show this on sites that have a digest
82	if (!hasDigests) {	×
83	return {	×
84	showDigestAd: false,
85	}
86	}
87	// Make sure we only show it to logged out users if they have the ability to hide it
88	if (!currentUser && !ls) {	×
89	return {	×
90	showDigestAd: false,
91	}
92	}
93	// If the user just submitted the form, make sure not to hide it, so that it properly finishes submitting.
94	// Alternatively, if the logged in user just clicked "Subscribe", show the success text rather than hiding this.
95	if (isHidden && !subscribeClicked) {	×
96	return {	×
97	showDigestAd: false,
98	}
99	}
100
101	return {	×
102	showDigestAd: true,
103	emailRef,
104	showForm,
105	loading,
106	subscribeClicked,
107	handleClose,
108	handleUserSubscribe
109	}
110	}

ForumMagnum / ForumMagnum / 10274492512

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous