10270307713

Committed 06 Aug 2024 04:24PM UTC coverage: 98.009% (+0.008%) from 98.001%

Build # 10270307713

Build Type

push

github

Committed by

web-flow

Commit Message

fix: Programmatic showing of popovers (#1340)

Skip the root click controller logic when programmatically
opening a popover in response to a click event that
is outside the DOM of the popover parent.

Run Details

3526 of 3722 branches covered (94.73%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 5 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

22271 of 22599 relevant lines covered (98.55%)

430.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.3

/src/components/common/controllers/root-click.ts

import type { ReactiveController, ReactiveControllerHost } from 'lit';
import { findElementFromEventPath } from '../util.js';

type RootClickControllerConfig = {
  hideCallback?: () => void;
  target?: HTMLElement;
};

type RootClickControllerHost = ReactiveControllerHost &
  HTMLElement & {
    open: boolean;
    keepOpenOnOutsideClick?: boolean;
    hide(): void;
  };

/* blazorSuppress */
export class RootClickController implements ReactiveController {
  public disabled = false;

  constructor(
    private readonly host: RootClickControllerHost,
    private config?: RootClickControllerConfig
  ) {
    this.host.addController(this);
  }

  private addEventListeners() {
    if (!this.host.keepOpenOnOutsideClick) {
      document.addEventListener('click', this);
    }
  }

  private removeEventListeners() {
    document.removeEventListener('click', this);
  }

  private configureListeners() {
    this.host.open ? this.addEventListeners() : this.removeEventListeners();
  }

  private shouldHide(event: PointerEvent) {
    const targets = new Set<Element>([this.host]);

    if (this.config?.target) {
      targets.add(this.config.target);
    }

    return !findElementFromEventPath((node) => targets.has(node), event);
  }

  public handleEvent(event: PointerEvent) {
    if (this.host.keepOpenOnOutsideClick || this.disabled) {
      return;
    }

    if (this.shouldHide(event)) {
      this.hide();
    }
  }

  private hide() {
    this.config?.hideCallback
      ? this.config.hideCallback.call(this.host)
      : this.host.hide();
  }

  public update(config?: RootClickControllerConfig) {
    if (config) {
      this.config = { ...this.config, ...config };
    }
    this.configureListeners();
  }

  public hostConnected() {
    this.configureListeners();
  }

  public hostDisconnected() {
    this.removeEventListeners();
  }
}

export function addRootClickHandler(
  host: RootClickControllerHost,
  config?: RootClickControllerConfig
) {
  return new RootClickController(host, config);
}

1	import type { ReactiveController, ReactiveControllerHost } from 'lit';	19✔
2	import { findElementFromEventPath } from '../util.js';	19✔
3		19✔
4	type RootClickControllerConfig = {	19✔
5	hideCallback?: () => void;	19✔
6	target?: HTMLElement;	19✔
7	};	19✔
8		19✔
9	type RootClickControllerHost = ReactiveControllerHost &	19✔
10	HTMLElement & {	19✔
11	open: boolean;	19✔
12	keepOpenOnOutsideClick?: boolean;	19✔
13	hide(): void;	19✔
14	};	19✔
15		19✔
16	/* blazorSuppress */	19✔
17	export class RootClickController implements ReactiveController {	19✔
18	public disabled = false;	19✔
19		19✔
20	constructor(	19✔
21	private readonly host: RootClickControllerHost,	270✔
22	private config?: RootClickControllerConfig	270✔
23	) {	270✔
24	this.host.addController(this);	270✔
25	}	270✔
26		19✔
27	private addEventListeners() {	19✔
28	if (!this.host.keepOpenOnOutsideClick) {	139✔
29	document.addEventListener('click', this);	133✔
30	}	133✔
31	}	139✔
32		19✔
33	private removeEventListeners() {	19✔
34	document.removeEventListener('click', this);	957✔
35	}	957✔
36		19✔
37	private configureListeners() {	19✔
38	this.host.open ? this.addEventListeners() : this.removeEventListeners();	826✔
39	}	826✔
40		19✔
41	private shouldHide(event: PointerEvent) {	19✔
42	const targets = new Set<Element>([this.host]);	33✔
43		33✔
44	if (this.config?.target) {	33✔
45	targets.add(this.config.target);	2✔
46	}	2✔
47		33✔
48	return !findElementFromEventPath((node) => targets.has(node), event);	33✔
49	}	33✔
50		19✔
51	public handleEvent(event: PointerEvent) {	19✔
52	if (this.host.keepOpenOnOutsideClick \|\| this.disabled) {	33!
UNCOV 53	return;	×
UNCOV 54	}	×
55		33✔
56	if (this.shouldHide(event)) {	33✔
57	this.hide();	5✔
58	}	5✔
59	}	33✔
60		19✔
61	private hide() {	19✔
62	this.config?.hideCallback	5✔
63	? this.config.hideCallback.call(this.host)	5✔
64	: this.host.hide();	5!
65	}	5✔
66		19✔
67	public update(config?: RootClickControllerConfig) {	19✔
68	if (config) {	556✔
69	this.config = { ...this.config, ...config };	220✔
70	}	220✔
71	this.configureListeners();	556✔
72	}	556✔
73		19✔
74	public hostConnected() {	19✔
75	this.configureListeners();	270✔
76	}	270✔
77		19✔
78	public hostDisconnected() {	19✔
79	this.removeEventListeners();	270✔
80	}	270✔
81	}	19✔
82		19✔
83	export function addRootClickHandler(	19✔
84	host: RootClickControllerHost,	270✔
85	config?: RootClickControllerConfig	270✔
86	) {	270✔
87	return new RootClickController(host, config);	270✔
88	}	270✔

IgniteUI / igniteui-webcomponents / 10270307713

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous