10268044337

Committed 06 Aug 2024 02:03PM UTC coverage: 15.719% (+0.009%) from 15.71%

Build # 10268044337

Build Type

Pull #8731

github

Committed by

web-flow

Commit Message

Merge 04ac1ad99 into 51960a35c

Pull Request Pull Request #8731: First Pass at removing community_id from comments and reactions

Run Details

3543 of 21057 branches covered (16.83%)

Branch coverage included in aggregate %.

5 of 16 new or added lines in 8 files covered. (31.25%)

3 existing lines in 3 files now uncovered.

4692 of 31333 relevant lines covered (14.97%)

4.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/packages/commonwealth/server/migrations/20240802153237-remove-redundant-community-pks.js

'use strict';

/** @type {import('sequelize-cli').Migration} */
module.exports = {
  async up(queryInterface) {
    await queryInterface.sequelize.transaction(async (t) => {
      await queryInterface.sequelize.query(
        `
        ALTER TABLE "Comments" DROP COLUMN IF EXISTS community_id;
        ALTER TABLE "Reactions" DROP COLUMN IF EXISTS community_id;
        `,
        {
          transaction: t,
        },
      );
    });
  },

  async down() {
    await queryInterface.sequelize.transaction(async () => {
      await queryInterface.sequelize.query(
        `
        ALTER TABLE "Comments" ADD COLUMN community_id INT;
        ALTER TABLE "Reactions" ADD COLUMN community_id INT;

        UPDATE "Comments" c SET community_id = t.community_id
        FROM "Threads" t
        WHERE c.thread_id = t.id;

        UPDATE "Reactions" r SET community_id = t.community_id
        FROM "Threads" t
        WHERE r.thread_id = c.id;

        UPDATE "Reactions" r SET community_id = t.community_id
        FROM "Comments" c JOIN "Threads" t ON c.thread_id = t.id
        WHERE r.comment_id = c.id;

        --ALTER TABLE "Comments" ADD CONSTRAINT fk_comments_community 
        --FOREIGN KEY (community_id) REFERENCES "Communities" (id);
        --ALTER TABLE "Reactions" ADD CONSTRAINT fk_reactions_community
        --FOREIGN KEY (community_id) REFERENCES "Communities" (id);
       `,
        {
          transaction: t,
        },
      );
    });
  },
};

1	'use strict';
2
3	/** @type {import('sequelize-cli').Migration} */
NEW 4	module.exports = {	×
5	async up(queryInterface) {
NEW 6	await queryInterface.sequelize.transaction(async (t) => {	×
NEW 7	await queryInterface.sequelize.query(	×
8	`
9	ALTER TABLE "Comments" DROP COLUMN IF EXISTS community_id;
10	ALTER TABLE "Reactions" DROP COLUMN IF EXISTS community_id;
11	`,
12	{
13	transaction: t,
14	},
15	);
16	});
17	},
18
19	async down() {
NEW 20	await queryInterface.sequelize.transaction(async () => {	×
NEW 21	await queryInterface.sequelize.query(	×
22	`
23	ALTER TABLE "Comments" ADD COLUMN community_id INT;
24	ALTER TABLE "Reactions" ADD COLUMN community_id INT;
25
26	UPDATE "Comments" c SET community_id = t.community_id
27	FROM "Threads" t
28	WHERE c.thread_id = t.id;
29
30	UPDATE "Reactions" r SET community_id = t.community_id
31	FROM "Threads" t
32	WHERE r.thread_id = c.id;
33
34	UPDATE "Reactions" r SET community_id = t.community_id
35	FROM "Comments" c JOIN "Threads" t ON c.thread_id = t.id
36	WHERE r.comment_id = c.id;
37
38	--ALTER TABLE "Comments" ADD CONSTRAINT fk_comments_community
39	--FOREIGN KEY (community_id) REFERENCES "Communities" (id);
40	--ALTER TABLE "Reactions" ADD CONSTRAINT fk_reactions_community
41	--FOREIGN KEY (community_id) REFERENCES "Communities" (id);
42	`,
43	{
44	transaction: t,
45	},
46	);
47	});
48	},
49	};

hicommonwealth / commonwealth / 10268044337

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous