10205658152

Committed 01 Aug 2024 08:58PM UTC coverage: 32.06% (-0.01%) from 32.074%

Build # 10205658152

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9424 from ForumMagnum/update-openai-embeddings

Switch to using text-embedding-3-large and batch operations for post embeddings

Run Details

4936 of 40072 branches covered (12.32%)

Branch coverage included in aggregate %.

14 of 64 new or added lines in 2 files covered. (21.88%)

1 existing line in 1 file now uncovered.

28725 of 64923 relevant lines covered (44.24%)

180.77 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

14.29

/packages/lesswrong/server/recommendations/Feature.ts

import { RecommendationFeatureName } from "../../lib/collections/users/recommendationSettings";
import { embeddingsSettings } from "../embeddings";

abstract class Feature {
  getJoin(): string {
    return "";
  }

  getFilter(): string {
    return "";
  }

  getScore(): string {
    return "";
  }

  getArgs(): Record<string, unknown> {
    return {};
  }
}

type ConstructableFeature = {
  new(): Feature;
}

class KarmaFeature extends Feature {
  private readonly pivot = 100;

  getScore() {
    return `
      CASE WHEN p."baseScore" > 0
        THEN p."baseScore" / (${this.pivot} + p."baseScore")
        ELSE 0
      END
    `;
  }
}

class CuratedFeature extends Feature {
  getScore() {
    return `CASE WHEN p."curatedDate" IS NULL THEN 0 ELSE 1 END`;
  }
}

class TagSimilarityFeature extends Feature {
  getScore() {
    return `fm_post_tag_similarity($(postId), p."_id")`;
  }
}

class CollabFilterFeature extends Feature {
  getJoin() {
    return `INNER JOIN "UniquePostUpvoters" rec ON rec."postId" = p."_id"`;
  }

  getScore() {
    const srcVoters = `(
      SELECT voters
      FROM "UniquePostUpvoters"
      WHERE "postId" = $(postId)
    )`;
    return `
      COALESCE(
        (# (${srcVoters} & rec.voters))::FLOAT /
          NULLIF((# (${srcVoters} | rec.voters))::FLOAT, 0),
        0
      )
    `;
  }
}

class TextSimilarityFeature extends Feature {
  constructor(
    private model = embeddingsSettings.embeddingModel,
  ) {
    super();
  }

  getJoin() {
    return `
      INNER JOIN "PostEmbeddings" pe ON
        pe."postId" = p."_id" AND
        pe."model" = $(embeddingsModel)
      JOIN "PostEmbeddings" seed_embeddings ON
        seed_embeddings."postId" = $(postId) AND
        seed_embeddings."model" = $(embeddingsModel)
    `;
  }

  getScore() {
    return `(-1 * (pe."embeddings" <#> seed_embeddings."embeddings"))`;
  }

  getArgs() {
    return {
      embeddingsModel: this.model,
    };
  }
}

export const featureRegistry: Record<
  RecommendationFeatureName,
  ConstructableFeature
> = {
  karma: KarmaFeature,
  curated: CuratedFeature,
  tagSimilarity: TagSimilarityFeature,
  collabFilter: CollabFilterFeature,
  textSimilarity: TextSimilarityFeature,
};

1	import { RecommendationFeatureName } from "../../lib/collections/users/recommendationSettings";	54✔
2	import { embeddingsSettings } from "../embeddings";	18✔
3
4	abstract class Feature {
5	getJoin(): string {
6	return "";	×
7	}
8
9	getFilter(): string {
10	return "";	×
11	}
12
13	getScore(): string {
14	return "";	×
15	}
16
17	getArgs(): Record<string, unknown> {
18	return {};	×
19	}
20	}
21
22	type ConstructableFeature = {
23	new(): Feature;
24	}
25
26	class KarmaFeature extends Feature {	×
27	private readonly pivot = 100;	×
28
29	getScore() {
30	return `	×
31	CASE WHEN p."baseScore" > 0
32	THEN p."baseScore" / (${this.pivot} + p."baseScore")
33	ELSE 0
34	END
35	`;
36	}
37	}
38
39	class CuratedFeature extends Feature {
40	getScore() {
41	return `CASE WHEN p."curatedDate" IS NULL THEN 0 ELSE 1 END`;	×
42	}
43	}
44
45	class TagSimilarityFeature extends Feature {
46	getScore() {
47	return `fm_post_tag_similarity($(postId), p."_id")`;	×
48	}
49	}
50
51	class CollabFilterFeature extends Feature {
52	getJoin() {
53	return `INNER JOIN "UniquePostUpvoters" rec ON rec."postId" = p."_id"`;	×
54	}
55
56	getScore() {
57	const srcVoters = `(	×
58	SELECT voters
59	FROM "UniquePostUpvoters"
60	WHERE "postId" = $(postId)
61	)`;
62	return `	×
63	COALESCE(
64	(# (${srcVoters} & rec.voters))::FLOAT /
65	NULLIF((# (${srcVoters} \| rec.voters))::FLOAT, 0),
66	0
67	)
68	`;
69	}
70	}
71
72	class TextSimilarityFeature extends Feature {
73	constructor(
NEW 74	private model = embeddingsSettings.embeddingModel,	×
75	) {
76	super();	×
77	}
78
79	getJoin() {
80	return `	×
81	INNER JOIN "PostEmbeddings" pe ON
82	pe."postId" = p."_id" AND
83	pe."model" = $(embeddingsModel)
84	JOIN "PostEmbeddings" seed_embeddings ON
85	seed_embeddings."postId" = $(postId) AND
86	seed_embeddings."model" = $(embeddingsModel)
87	`;
88	}
89
90	getScore() {
91	return `(-1 * (pe."embeddings" <#> seed_embeddings."embeddings"))`;	×
92	}
93
94	getArgs() {
95	return {	×
96	embeddingsModel: this.model,
97	};
98	}
99	}
100
101	export const featureRegistry: Record<
102	RecommendationFeatureName,
103	ConstructableFeature
104	> = {	18✔
105	karma: KarmaFeature,
106	curated: CuratedFeature,
107	tagSimilarity: TagSimilarityFeature,
108	collabFilter: CollabFilterFeature,
109	textSimilarity: TextSimilarityFeature,
110	};

ForumMagnum / ForumMagnum / 10205658152

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous