10205526931

Committed 01 Aug 2024 08:46PM UTC coverage: 31.812% (-0.08%) from 31.891%

Build # 10205526931

Build Type

Pull #9424

github

Committed by

darkruby501

Commit Message

forum gate embedding model and batch operations

Pull Request Pull Request #9424: Switch to using text-embedding-3-large and batch operations for post embeddings

Run Details

4821 of 39573 branches covered (12.18%)

Branch coverage included in aggregate %.

14 of 64 new or added lines in 2 files covered. (21.88%)

308 existing lines in 10 files now uncovered.

28081 of 63853 relevant lines covered (43.98%)

179.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.67

/packages/lesswrong/components/votes/lwReactions/InlineReactHoverableHighlight.tsx

import React, { useContext } from 'react';
import { Components, registerComponent } from '../../../lib/vulcan-lib';
import type { NamesAttachedReactionsList, QuoteLocator } from '../../../lib/voting/namesAttachedReactions';
import type { VotingProps } from '../votingProps';
import classNames from 'classnames';
import { HoveredReactionListContext, SetHoveredReactionContext } from './HoveredReactionContextProvider';
import sumBy from 'lodash/sumBy';
import { useHover } from '@/components/common/withHover';

const styles = (theme: ThemeType) => ({
  reactionTypeHovered: {
    backgroundColor: theme.palette.grey[200],
  },
  
  // Keeping this empty class around is necessary for the following @global style to work properly
  highlight: {},
  // Comment or post hovered
  "@global": {
    [
      ".CommentsItem-body:hover .InlineReactHoverableHighlight-highlight"
      +", .Answer-answer:hover .InlineReactHoverableHighlight-highlight"
      +", .PostsPage-postContent:hover .InlineReactHoverableHighlight-highlight"
    ]: {
      textDecorationLine: 'underline',
      textDecorationStyle: 'dashed',
      textDecorationColor: theme.palette.text.dim4,
      textUnderlineOffset: '3px'
    },
  }
})

const InlineReactHoverableHighlight = ({quote,reactions, voteProps, children, classes}: {
  quote: QuoteLocator,
  reactions: NamesAttachedReactionsList,
  voteProps: VotingProps<VoteableTypeClient>,
  children: React.ReactNode,
  classes: ClassesType<typeof styles>,
}) => {
  const { InlineReactHoverInfo, LWTooltip } = Components;

  const hoveredReactions = useContext(HoveredReactionListContext);
  const isHovered = hoveredReactions
    && Object.keys(reactions).some(reaction =>
      hoveredReactions.find(r=>r.reactionName===reaction && (r.quote === quote || r.quote === null))
    );

  const setHoveredReaction = useContext(SetHoveredReactionContext);

  function updateHoveredReactions(isHovered: boolean) {
    for (const [reactionName, documentReactionInfo] of Object.entries(reactions)) {
      if (documentReactionInfo) {
        for (const { quotes } of documentReactionInfo) {
          const [reactQuote] = quotes ?? [];
          if (quote === reactQuote) {
            setHoveredReaction?.({ isHovered, quote: reactQuote, reactionName });
          }
        }
      }
    }
  }

  const { eventHandlers } = useHover({
    onEnter: () => updateHoveredReactions(true),
    onLeave: () => updateHoveredReactions(false)
  });
  
  // (reactions is already filtered by quote, we don't have to filter it again for this)
  const anyPositive = atLeastOneQuoteReactHasPositiveScore(reactions);
  
  // We underline any given inline react if either:
  // 1) the quote itself is hovered over, or
  // 2) if the post/comment is hovered over, and the react has net-positive agreement across all users
  const shouldUnderline = isHovered || anyPositive;

  return <LWTooltip
    title={<InlineReactHoverInfo
      quote={quote}
      reactions={reactions}
      voteProps={voteProps}
    />}
    placement="top-start"
    tooltip={false}
    flip={false}
    inlineBlock={false}
    clickable={true}
  >
    <span {...eventHandlers} className={classNames({
      [classes.highlight]: shouldUnderline,
      [classes.reactionTypeHovered]: isHovered
    })}>
      {children}
    </span>
  </LWTooltip>
}

function atLeastOneQuoteReactHasPositiveScore(reactions: NamesAttachedReactionsList): boolean {
  if (!reactions) {
    return false;
  }
  
  for (let react of Object.keys(reactions)) {
    const netReaction = sumBy(reactions[react], r => r.reactType==="disagreed" ? -1 : 1);
    if (netReaction > 0) {
      return true;
    }
  }
  
  return false;
}

const InlineReactHoverableHighlightComponent = registerComponent('InlineReactHoverableHighlight', InlineReactHoverableHighlight, {styles});

declare global {
  interface ComponentTypes {
    InlineReactHoverableHighlight: typeof InlineReactHoverableHighlightComponent
  }
}


1	import React, { useContext } from 'react';	1✔
2	import { Components, registerComponent } from '../../../lib/vulcan-lib';	1✔
3	import type { NamesAttachedReactionsList, QuoteLocator } from '../../../lib/voting/namesAttachedReactions';
4	import type { VotingProps } from '../votingProps';
5	import classNames from 'classnames';	1✔
6	import { HoveredReactionListContext, SetHoveredReactionContext } from './HoveredReactionContextProvider';	1✔
7	import sumBy from 'lodash/sumBy';	1✔
8	import { useHover } from '@/components/common/withHover';	1✔
9
10	const styles = (theme: ThemeType) => ({	1✔
11	reactionTypeHovered: {
12	backgroundColor: theme.palette.grey[200],
13	},
14
15	// Keeping this empty class around is necessary for the following @global style to work properly
16	highlight: {},
17	// Comment or post hovered
18	"@global": {
19	[
20	".CommentsItem-body:hover .InlineReactHoverableHighlight-highlight"
21	+", .Answer-answer:hover .InlineReactHoverableHighlight-highlight"
22	+", .PostsPage-postContent:hover .InlineReactHoverableHighlight-highlight"
23	]: {
24	textDecorationLine: 'underline',
25	textDecorationStyle: 'dashed',
26	textDecorationColor: theme.palette.text.dim4,
27	textUnderlineOffset: '3px'
28	},
29	}
30	})
31
32	const InlineReactHoverableHighlight = ({quote,reactions, voteProps, children, classes}: {	1✔
33	quote: QuoteLocator,
34	reactions: NamesAttachedReactionsList,
35	voteProps: VotingProps<VoteableTypeClient>,
36	children: React.ReactNode,
37	classes: ClassesType<typeof styles>,
38	}) => {
39	const { InlineReactHoverInfo, LWTooltip } = Components;	×
40
UNCOV 41	const hoveredReactions = useContext(HoveredReactionListContext);	×
42	const isHovered = hoveredReactions	×
43	&& Object.keys(reactions).some(reaction =>
44	hoveredReactions.find(r=>r.reactionName===reaction && (r.quote === quote \|\| r.quote === null))	×
45	);
46
47	const setHoveredReaction = useContext(SetHoveredReactionContext);	×
48
49	function updateHoveredReactions(isHovered: boolean) {
50	for (const [reactionName, documentReactionInfo] of Object.entries(reactions)) {	×
51	if (documentReactionInfo) {	×
52	for (const { quotes } of documentReactionInfo) {	×
53	const [reactQuote] = quotes ?? [];	×
54	if (quote === reactQuote) {	×
55	setHoveredReaction?.({ isHovered, quote: reactQuote, reactionName });	×
56	}
57	}
58	}
59	}
60	}
61
62	const { eventHandlers } = useHover({	×
63	onEnter: () => updateHoveredReactions(true),	×
64	onLeave: () => updateHoveredReactions(false)	×
65	});
66
67	// (reactions is already filtered by quote, we don't have to filter it again for this)
68	const anyPositive = atLeastOneQuoteReactHasPositiveScore(reactions);	×
69
70	// We underline any given inline react if either:
71	// 1) the quote itself is hovered over, or
72	// 2) if the post/comment is hovered over, and the react has net-positive agreement across all users
73	const shouldUnderline = isHovered \|\| anyPositive;	×
74
75	return <LWTooltip	×
76	title={<InlineReactHoverInfo
77	quote={quote}
78	reactions={reactions}
79	voteProps={voteProps}
80	/>}
81	placement="top-start"
82	tooltip={false}
83	flip={false}
84	inlineBlock={false}
85	clickable={true}
86	>
87	<span {...eventHandlers} className={classNames({
88	[classes.highlight]: shouldUnderline,
89	[classes.reactionTypeHovered]: isHovered
90	})}>
91	{children}
92	</span>
93	</LWTooltip>
94	}
95
96	function atLeastOneQuoteReactHasPositiveScore(reactions: NamesAttachedReactionsList): boolean {
97	if (!reactions) {	×
98	return false;	×
99	}
100
101	for (let react of Object.keys(reactions)) {	×
102	const netReaction = sumBy(reactions[react], r => r.reactType==="disagreed" ? -1 : 1);	×
103	if (netReaction > 0) {	×
104	return true;	×
105	}
106	}
107
108	return false;	×
109	}
110
111	const InlineReactHoverableHighlightComponent = registerComponent('InlineReactHoverableHighlight', InlineReactHoverableHighlight, {styles});	1✔
112
113	declare global {
114	interface ComponentTypes {
115	InlineReactHoverableHighlight: typeof InlineReactHoverableHighlightComponent
116	}
117	}
118

ForumMagnum / ForumMagnum / 10205526931

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous