10182394296

Committed 31 Jul 2024 02:40PM UTC coverage: 47.247% (+0.2%) from 47.078%

Build # 10182394296

Build Type

Pull #1787

github

Committed by

iamacook

Commit Message

Fix tests

Pull Request Pull Request #1787: Add v2 notifications routes

Run Details

454 of 2805 branches covered (16.19%)

Branch coverage included in aggregate %.

34 of 57 new or added lines in 8 files covered. (59.65%)

1 existing line in 1 file now uncovered.

4455 of 7585 relevant lines covered (58.73%)

12.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.19

/src/routes/notifications/notifications.controller.v2.ts

import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';
import { NotificationType } from '@/domain/notifications/entities-v2/notification-type.entity';
import {
  UpsertSubscriptionsDto,
  UpsertSubscriptionsDtoSchema,
} from '@/routes/notifications/entities/upsert-subscriptions.dto.entity';
import { NotificationsServiceV2 } from '@/routes/notifications/notifications.service.v2';
import { Auth } from '@/routes/auth/decorators/auth.decorator';
import { AuthGuard } from '@/routes/auth/guards/auth.guard';
import { AddressSchema } from '@/validation/entities/schemas/address.schema';
import { NumericStringSchema } from '@/validation/entities/schemas/numeric-string.schema';
import { UuidSchema } from '@/validation/entities/schemas/uuid.schema';
import { ValidationPipe } from '@/validation/pipes/validation.pipe';
import {
  Body,
  Controller,
  Delete,
  Get,
  Param,
  Post,
  UseGuards,
} from '@nestjs/common';
import { ApiTags } from '@nestjs/swagger';
import { UUID } from 'crypto';

@ApiTags('notifications')
@Controller({ path: '', version: '2' })
export class NotificationsControllerV2 {
  constructor(private readonly notificationsService: NotificationsServiceV2) {}

  // TODO: Add ApiOkResponse and HttpCode for each route

  @Post('register/notifications')
  @UseGuards(AuthGuard)
  upsertSubscriptions(
    @Body(new ValidationPipe(UpsertSubscriptionsDtoSchema))
    upsertSubscriptionsDto: UpsertSubscriptionsDto,
    @Auth() authPayload: AuthPayload,
  ): Promise<{ deviceUuid: UUID }> {
    return this.notificationsService.upsertSubscriptions({
      authPayload,
      upsertSubscriptionsDto,
    });
  }

  @Get('chains/:chainId/notifications/devices/:deviceUuid/safes/:safeAddress')
  @UseGuards(AuthGuard)
  getSafeSubscription(
    @Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
    @Param('chainId', new ValidationPipe(NumericStringSchema)) chainId: string,
    @Param('safeAddress', new ValidationPipe(AddressSchema))
    safeAddress: `0x${string}`,
    @Auth() authPayload: AuthPayload,
  ): Promise<Array<NotificationType>> {
    return this.notificationsService.getSafeSubscription({
      authPayload,
      deviceUuid,
      chainId,
      safeAddress,
    });
  }

  @Delete(
    'chains/:chainId/notifications/devices/:deviceUuid/safes/:safeAddress',
  )
  deleteSubscription(
    @Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
    @Param('chainId', new ValidationPipe(NumericStringSchema)) chainId: string,
    @Param('safeAddress', new ValidationPipe(AddressSchema))
    safeAddress: `0x${string}`,
  ): Promise<void> {
    return this.notificationsService.deleteSubscription({
      deviceUuid,
      chainId,
      safeAddress,
    });
  }

  @Delete('chains/:chainId/notifications/devices/:deviceUuid')
  deleteDevice(
    @Param('chainId', new ValidationPipe(NumericStringSchema)) _chainId: string,
    @Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
  ): Promise<void> {
    return this.notificationsService.deleteDevice(deviceUuid);
  }
}

1	import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';	16✔
2	import { NotificationType } from '@/domain/notifications/entities-v2/notification-type.entity';
3	import {	16✔
4	UpsertSubscriptionsDto,
5	UpsertSubscriptionsDtoSchema,
6	} from '@/routes/notifications/entities/upsert-subscriptions.dto.entity';
7	import { NotificationsServiceV2 } from '@/routes/notifications/notifications.service.v2';	16✔
8	import { Auth } from '@/routes/auth/decorators/auth.decorator';	16✔
9	import { AuthGuard } from '@/routes/auth/guards/auth.guard';	16✔
10	import { AddressSchema } from '@/validation/entities/schemas/address.schema';	16✔
11	import { NumericStringSchema } from '@/validation/entities/schemas/numeric-string.schema';	16✔
12	import { UuidSchema } from '@/validation/entities/schemas/uuid.schema';	16✔
13	import { ValidationPipe } from '@/validation/pipes/validation.pipe';	16✔
14	import {	16✔
15	Body,
16	Controller,
17	Delete,
18	Get,
19	Param,
20	Post,
21	UseGuards,
22	} from '@nestjs/common';
23	import { ApiTags } from '@nestjs/swagger';	16✔
24	import { UUID } from 'crypto';
25
26	@ApiTags('notifications')
27	@Controller({ path: '', version: '2' })
28	export class NotificationsControllerV2 {	16✔
NEW 29	constructor(private readonly notificationsService: NotificationsServiceV2) {}	×
30
31	// TODO: Add ApiOkResponse and HttpCode for each route
32
33	@Post('register/notifications')
34	@UseGuards(AuthGuard)
35	upsertSubscriptions(	16✔
36	@Body(new ValidationPipe(UpsertSubscriptionsDtoSchema))
37	upsertSubscriptionsDto: UpsertSubscriptionsDto,
38	@Auth() authPayload: AuthPayload,
39	): Promise<{ deviceUuid: UUID }> {
NEW 40	return this.notificationsService.upsertSubscriptions({	×
41	authPayload,
42	upsertSubscriptionsDto,
43	});
44	}
45
46	@Get('chains/:chainId/notifications/devices/:deviceUuid/safes/:safeAddress')
47	@UseGuards(AuthGuard)
48	getSafeSubscription(	16✔
49	@Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
50	@Param('chainId', new ValidationPipe(NumericStringSchema)) chainId: string,
51	@Param('safeAddress', new ValidationPipe(AddressSchema))
52	safeAddress: `0x${string}`,
53	@Auth() authPayload: AuthPayload,
54	): Promise<Array<NotificationType>> {
NEW 55	return this.notificationsService.getSafeSubscription({	×
56	authPayload,
57	deviceUuid,
58	chainId,
59	safeAddress,
60	});
61	}
62
63	@Delete(
64	'chains/:chainId/notifications/devices/:deviceUuid/safes/:safeAddress',
65	)
66	deleteSubscription(	16✔
67	@Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
68	@Param('chainId', new ValidationPipe(NumericStringSchema)) chainId: string,
69	@Param('safeAddress', new ValidationPipe(AddressSchema))
70	safeAddress: `0x${string}`,
71	): Promise<void> {
NEW 72	return this.notificationsService.deleteSubscription({	×
73	deviceUuid,
74	chainId,
75	safeAddress,
76	});
77	}
78
79	@Delete('chains/:chainId/notifications/devices/:deviceUuid')
80	deleteDevice(	16✔
81	@Param('chainId', new ValidationPipe(NumericStringSchema)) _chainId: string,
82	@Param('deviceUuid', new ValidationPipe(UuidSchema)) deviceUuid: UUID,
83	): Promise<void> {
NEW 84	return this.notificationsService.deleteDevice(deviceUuid);	×
85	}
86	}

safe-global / safe-client-gateway / 10182394296

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous