10169800075

Committed 30 Jul 2024 09:10PM UTC coverage: 32.074% (-0.008%) from 32.082%

Build # 10169800075

Build Type

Pull #9554

github

Committed by

oetherington

Commit Message

Add notification hoverovers

Pull Request Pull Request #9554: EA Notifications redesign

Run Details

4936 of 40092 branches covered (12.31%)

Branch coverage included in aggregate %.

43 of 80 new or added lines in 11 files covered. (53.75%)

3 existing lines in 2 files now uncovered.

28746 of 64922 relevant lines covered (44.28%)

180.77 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

53.85

/packages/lesswrong/components/notifications/NoNotificationsPlaceholder.tsx

import React from "react";
import { Components, registerComponent } from "../../lib/vulcan-lib";

const styles = (theme: ThemeType) => ({
  root: {
    display: "flex",
    flexDirection: "column",
    alignItems: "center",
    gap: "32px",
    padding: "60px 24px",
    color: theme.palette.grey[600],
    lineHeight: "140%",
    textAlign: "center",
  },
  icon: {
    width: 60,
    height: 60,
  },
  title: {
    color: theme.palette.grey[1000],
    fontSize: 18,
    fontWeight: 600,
  },
  subtitle: {
    fontSize: 14,
    fontWeight: 500,
  },
});

const SubscribedPlaceholder = ({classes}: {
  classes: ClassesType<typeof styles>,
}) => {
  const {ForumIcon} = Components;
  return (
    <div className={classes.root}>
      <ForumIcon icon="BellBorder" className={classes.icon} />
      <div className={classes.title}>
        No notifications yet
      </div>
      <div className={classes.subtitle}>
        Subscribe to posts, authors or comments to get notified about new activity
      </div>
    </div>
  );
}

const NotSubscribedPlaceholder = ({classes}: {
  classes: ClassesType<typeof styles>,
}) => {
  return (
    <div className={classes.root}>
      <div className={classes.title}>
        Turn on email digest
      </div>
      <div className={classes.subtitle}>
        The EA Forum Digest is a curated reading list of Forum posts,{" "}
        sent every Wednesday
      </div>
    </div>
  );
}

const NoNotificationsPlaceholder = ({subscribedToDigest, classes}: {
  subscribedToDigest: boolean,
  classes: ClassesType<typeof styles>,
}) => {
  return (
    subscribedToDigest
      ? <SubscribedPlaceholder classes={classes} />
      : <NotSubscribedPlaceholder classes={classes} />
    );
}

const NoNotificationsPlaceholderComponent = registerComponent(
  "NoNotificationsPlaceholder",
  NoNotificationsPlaceholder,
  {styles},
);

declare global {
  interface ComponentTypes {
    NoNotificationsPlaceholder: typeof NoNotificationsPlaceholderComponent
  }
}

1	import React from "react";	1✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3
4	const styles = (theme: ThemeType) => ({	1✔
5	root: {
6	display: "flex",
7	flexDirection: "column",
8	alignItems: "center",
9	gap: "32px",
10	padding: "60px 24px",
11	color: theme.palette.grey[600],
12	lineHeight: "140%",
13	textAlign: "center",
14	},
15	icon: {
16	width: 60,
17	height: 60,
18	},
19	title: {
20	color: theme.palette.grey[1000],
21	fontSize: 18,
22	fontWeight: 600,
23	},
24	subtitle: {
25	fontSize: 14,
26	fontWeight: 500,
27	},
28	});
29
30	const SubscribedPlaceholder = ({classes}: {	1✔
31	classes: ClassesType<typeof styles>,
32	}) => {
NEW 33	const {ForumIcon} = Components;	×
NEW 34	return (	×
35	<div className={classes.root}>
36	<ForumIcon icon="BellBorder" className={classes.icon} />
37	<div className={classes.title}>
38	No notifications yet
39	</div>
40	<div className={classes.subtitle}>
41	Subscribe to posts, authors or comments to get notified about new activity
42	</div>
43	</div>
44	);
45	}
46
47	const NotSubscribedPlaceholder = ({classes}: {	1✔
48	classes: ClassesType<typeof styles>,
49	}) => {
NEW 50	return (	×
51	<div className={classes.root}>
52	<div className={classes.title}>
53	Turn on email digest
54	</div>
55	<div className={classes.subtitle}>
56	The EA Forum Digest is a curated reading list of Forum posts,{" "}
57	sent every Wednesday
58	</div>
59	</div>
60	);
61	}
62
63	const NoNotificationsPlaceholder = ({subscribedToDigest, classes}: {	1✔
64	subscribedToDigest: boolean,
65	classes: ClassesType<typeof styles>,
66	}) => {
NEW 67	return (	×
68	subscribedToDigest
69	? <SubscribedPlaceholder classes={classes} />	×
70	: <NotSubscribedPlaceholder classes={classes} />
71	);
72	}
73
74	const NoNotificationsPlaceholderComponent = registerComponent(	1✔
75	"NoNotificationsPlaceholder",
76	NoNotificationsPlaceholder,
77	{styles},
78	);
79
80	declare global {
81	interface ComponentTypes {
82	NoNotificationsPlaceholder: typeof NoNotificationsPlaceholderComponent
83	}
84	}

ForumMagnum / ForumMagnum / 10169800075

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous