10154660995

Committed 30 Jul 2024 01:39AM UTC coverage: 31.841% (-0.02%) from 31.857%

Build # 10154660995

Build Type

Pull #9556

github

Committed by

Raemon

Commit Message

move comments bottom-left

Pull Request Pull Request #9556: Minimalist Post Header

Run Details

4950 of 40709 branches covered (12.16%)

Branch coverage included in aggregate %.

25 of 82 new or added lines in 5 files covered. (30.49%)

315 existing lines in 11 files now uncovered.

28910 of 65633 relevant lines covered (44.05%)

179.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

13.24

/packages/lesswrong/components/common/excerpts/PostExcerpt.tsx

import React from "react";
import { Components, registerComponent } from "../../../lib/vulcan-lib";
import { postGetPageUrl } from "../../../lib/collections/posts/helpers";
import { usePostContents } from "../../hooks/useForeignCrosspost";
import { useForeignApolloClient } from "../../hooks/useForeignApolloClient";
import { useSingle } from "../../../lib/crud/withSingle";
import type { CommonExcerptProps } from "./ContentExcerpt";

const isSunshine = (post: PostsList | SunshinePostsList): post is SunshinePostsList =>
  "user" in post;

const PostExcerpt = ({
  post,
  hash,
  ...commonExcerptProps
}: CommonExcerptProps & {
  post: PostsList | SunshinePostsList,
  hash?: string | null,
}) => {
  // Get the post body, accounting for whether or not this is a crosspost
  const {postContents, loading, error} = usePostContents({
    post,
    fragmentName: isSunshine(post) ? "SunshinePostsList" : "PostsList",
    skip: !!hash,
  });

  // If a hash is supplied then we need to run a query to get the section
  // of the content starting at the hash, whether of not this is a crosspost
  const isForeign = post?.fmCrosspost?.isCrosspost &&
    !post.fmCrosspost.hostedHere &&
    !!post.fmCrosspost.foreignPostId;
  const foreignApolloClient = useForeignApolloClient();
  const {document: postHighlight, loading: loadingHighlight} = useSingle({
    collectionName: "Posts",
    fragmentName: "HighlightWithHash",
    documentId: post?.fmCrosspost?.foreignPostId ?? post?._id,
    skip: !hash && !!post.contents,
    fetchPolicy: "cache-first",
    extraVariables: {hash: "String"},
    extraVariablesValues: {hash},
    apolloClient: isForeign ? foreignApolloClient : undefined,
  });

  const {Loading, ContentExcerpt} = Components;
  if ((loading && !hash) || (loadingHighlight && hash)) {
    return (
      <Loading />
    );
  }

  if (error) {
    // eslint-disable-next-line
    console.error("Error loading excerpt body:", error);
  }

  const contentHtml =
    postHighlight?.contents?.htmlHighlightStartingAtHash ||
    post.customHighlight?.html ||
    postContents?.htmlHighlight ||
    (postContents as AnyBecauseHard)?.html;
  if (!contentHtml) {
    return null;
  }

  return (
    <ContentExcerpt
      contentHtml={contentHtml}
      moreLink={postGetPageUrl(post)}
      contentType="postHighlight"
      {...commonExcerptProps}
    />
  );
}

const PostExcerptComponent = registerComponent(
  "PostExcerpt",
  PostExcerpt,
);

declare global {
  interface ComponentTypes {
    PostExcerpt: typeof PostExcerptComponent,
  }
}

1	import React from "react";	1✔
2	import { Components, registerComponent } from "../../../lib/vulcan-lib";	1✔
3	import { postGetPageUrl } from "../../../lib/collections/posts/helpers";	1✔
4	import { usePostContents } from "../../hooks/useForeignCrosspost";	1✔
5	import { useForeignApolloClient } from "../../hooks/useForeignApolloClient";	1✔
6	import { useSingle } from "../../../lib/crud/withSingle";	1✔
7	import type { CommonExcerptProps } from "./ContentExcerpt";
8
9	const isSunshine = (post: PostsList \| SunshinePostsList): post is SunshinePostsList =>	1✔
10	"user" in post;	×
11
12	const PostExcerpt = ({	1✔
13	post,
14	hash,
15	...commonExcerptProps
16	}: CommonExcerptProps & {
17	post: PostsList \| SunshinePostsList,
18	hash?: string \| null,
19	}) => {
20	// Get the post body, accounting for whether or not this is a crosspost
UNCOV 21	const {postContents, loading, error} = usePostContents({	×
22	post,
23	fragmentName: isSunshine(post) ? "SunshinePostsList" : "PostsList",	×
24	skip: !!hash,
25	});
26
27	// If a hash is supplied then we need to run a query to get the section
28	// of the content starting at the hash, whether of not this is a crosspost
UNCOV 29	const isForeign = post?.fmCrosspost?.isCrosspost &&	×
30	!post.fmCrosspost.hostedHere &&
31	!!post.fmCrosspost.foreignPostId;
32	const foreignApolloClient = useForeignApolloClient();	×
UNCOV 33	const {document: postHighlight, loading: loadingHighlight} = useSingle({	×
34	collectionName: "Posts",
35	fragmentName: "HighlightWithHash",
36	documentId: post?.fmCrosspost?.foreignPostId ?? post?._id,	×
37	skip: !hash && !!post.contents,	×
38	fetchPolicy: "cache-first",
39	extraVariables: {hash: "String"},
40	extraVariablesValues: {hash},
41	apolloClient: isForeign ? foreignApolloClient : undefined,	×
42	});
43
UNCOV 44	const {Loading, ContentExcerpt} = Components;	×
UNCOV 45	if ((loading && !hash) \|\| (loadingHighlight && hash)) {	×
UNCOV 46	return (	×
47	<Loading />
48	);
49	}
50
UNCOV 51	if (error) {	×
52	// eslint-disable-next-line
UNCOV 53	console.error("Error loading excerpt body:", error);	×
54	}
55
56	const contentHtml =	×
57	postHighlight?.contents?.htmlHighlightStartingAtHash \|\|	×
58	post.customHighlight?.html \|\|	×
59	postContents?.htmlHighlight \|\|	×
60	(postContents as AnyBecauseHard)?.html;	×
UNCOV 61	if (!contentHtml) {	×
62	return null;	×
63	}
64
65	return (	×
66	<ContentExcerpt
67	contentHtml={contentHtml}
68	moreLink={postGetPageUrl(post)}
69	contentType="postHighlight"
70	{...commonExcerptProps}
71	/>
72	);
73	}
74
75	const PostExcerptComponent = registerComponent(	1✔
76	"PostExcerpt",
77	PostExcerpt,
78	);
79
80	declare global {
81	interface ComponentTypes {
82	PostExcerpt: typeof PostExcerptComponent,
83	}
84	}

ForumMagnum / ForumMagnum / 10154660995

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous