10147853341

Committed 29 Jul 2024 04:08PM UTC coverage: 62.615% (-0.7%) from 63.28%

Build # 10147853341

Build Type

push

github

Committed by

web-flow

Commit Message

sync: Fix serial_num field name (#1404)

Disable the preserve_proto_field_names option when marshalling JSON requests as this prevents the json_name attribute on fields from working properly. Add that attribute to all fields so that they marshal as expected. Stop setting the always_print_enums_as_ints field as the value we're setting to is the default anyway.

Also add a test that preflight request data looks as expected.

Run Details

5614 of 13420 branches covered (41.83%)

Branch coverage included in aggregate %.

20 of 29 new or added lines in 4 files covered. (68.97%)

199 existing lines in 11 files now uncovered.

18652 of 25334 relevant lines covered (73.62%)

6307.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/Source/gui/SNTMessageWindowController.m

#import "Source/gui/SNTMessageWindowController.h"

@implementation SNTMessageWindowController

- (IBAction)showWindow:(id)sender {
  [self.window setLevel:NSPopUpMenuWindowLevel];
  [self.window setMovableByWindowBackground:YES];
  [self.window makeKeyAndOrderFront:sender];
  [self.window center];
  [NSApp activateIgnoringOtherApps:YES];
}
- (IBAction)closeWindow:(id)sender {
  [self windowWillClose:sender];
  [self.window close];
}

- (void)windowWillClose:(NSNotification *)notification {
  if (!self.delegate) return;

  if (self.silenceFutureNotifications) {
    [self.delegate windowDidCloseSilenceHash:[self messageHash]];
  } else {
    [self.delegate windowDidCloseSilenceHash:nil];
  }
}

- (NSString *)messageHash {
  [self doesNotRecognizeSelector:_cmd];
  return nil;
}

@end

1	#import "Source/gui/SNTMessageWindowController.h"
2
3	@implementation SNTMessageWindowController
4
UNCOV 5	- (IBAction)showWindow:(id)sender {	×
UNCOV 6	[self.window setLevel:NSPopUpMenuWindowLevel];	×
UNCOV 7	[self.window setMovableByWindowBackground:YES];	×
UNCOV 8	[self.window makeKeyAndOrderFront:sender];	×
UNCOV 9	[self.window center];	×
UNCOV 10	[NSApp activateIgnoringOtherApps:YES];	×
UNCOV 11	}	×
12	- (IBAction)closeWindow:(id)sender {	×
13	[self windowWillClose:sender];	×
14	[self.window close];	×
15	}	×
16
17	- (void)windowWillClose:(NSNotification *)notification {	×
18	if (!self.delegate) return;	×
19
20	if (self.silenceFutureNotifications) {	×
21	[self.delegate windowDidCloseSilenceHash:[self messageHash]];	×
22	} else {	×
23	[self.delegate windowDidCloseSilenceHash:nil];	×
24	}	×
25	}	×
26
27	- (NSString *)messageHash {	×
28	[self doesNotRecognizeSelector:_cmd];	×
29	return nil;	×
30	}	×
31
32	@end

google / santa / 10147853341

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous