10094625598

Committed 25 Jul 2024 01:02PM UTC coverage: 31.846% (-0.01%) from 31.858%

Build # 10094625598

Build Type

Pull #9521

github

Committed by

oetherington

Commit Message

Fix TUI mode input bug

Pull Request Pull Request #9521: Crossposting e2e tests

Run Details

4903 of 40265 branches covered (12.18%)

Branch coverage included in aggregate %.

3 of 5 new or added lines in 2 files covered. (60.0%)

1124 existing lines in 63 files now uncovered.

28607 of 64961 relevant lines covered (44.04%)

180.18 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

33.33

/packages/lesswrong/components/peopleDirectory/PeopleDirectoryFilters.tsx

import React from "react";
import { Components, registerComponent } from "../../lib/vulcan-lib";
import { usePeopleDirectory } from "./usePeopleDirectory";
import { formatStat } from "../users/EAUserTooltipContent";

const styles = (theme: ThemeType) => ({
  root: {
    display: "flex",
    fontFamily: theme.palette.fonts.sansSerifStack,
  },
  filters: {
    display: "flex",
    gap: "4px",
    flexGrow: 1,
  },
  options: {
    display: "flex",
    gap: "4px",
  },
  columnsList: {
    display: "flex",
    flexDirection: "column",
    gap: "12px",
    padding: 16,
  },
  totalResults: {
    display: "flex",
    alignItems: "center",
    marginLeft: 14,
    fontWeight: 600,
    color: theme.palette.grey[600],
  },
});

export const PeopleDirectoryFilters = ({classes}: {
  classes: ClassesType<typeof styles>,
}) => {
  const {
    view,
    roles,
    organizations,
    locations,
    careerStages,
    columns,
    columnsEdited,
    resetColumns,
    totalResults,
    isEmptySearch,
  } = usePeopleDirectory();
  const {
    PeopleDirectoryFilterDropdown, PeopleDirectorySelectOption,
    PeopleDirectoryStaticFilter, PeopleDirectorySearchableFilter,
    PeopleDirectoryClearAll, PeopleDirectoryViewToggle,
  } = Components;
  return (
    <div className={classes.root}>
      <div className={classes.filters}>
        <PeopleDirectorySearchableFilter filter={roles} />
        <PeopleDirectorySearchableFilter filter={organizations} />
        <PeopleDirectoryStaticFilter filter={careerStages} />
        <PeopleDirectorySearchableFilter filter={locations} />
        {totalResults > 0 && !isEmptySearch &&
          <div className={classes.totalResults}>
            {formatStat(totalResults)} {totalResults === 1 ? "result" : "results"}
          </div>
        }
      </div>
      <div className={classes.options}>
        {view === "list" &&
          <PeopleDirectoryFilterDropdown
            title="Columns"
            icon="ViewColumns"
            style="button"
            className={classes.columnsList}
          >
            {columns.filter(({hideable}) => hideable).map((state) => (
              <PeopleDirectorySelectOption state={state} key={state.value} />
            ))}
            {columnsEdited &&
              <div>
                <PeopleDirectoryClearAll text="Reset" onClear={resetColumns} />
              </div>
            }
          </PeopleDirectoryFilterDropdown>
        }
        <PeopleDirectoryViewToggle />
      </div>
    </div>
  );
}

const PeopleDirectoryFiltersComponent = registerComponent(
  "PeopleDirectoryFilters",
  PeopleDirectoryFilters,
  {styles},
);

declare global {
  interface ComponentTypes {
    PeopleDirectoryFilters: typeof PeopleDirectoryFiltersComponent
  }
}

1	import React from "react";	3✔
2	import { Components, registerComponent } from "../../lib/vulcan-lib";	1✔
3	import { usePeopleDirectory } from "./usePeopleDirectory";	1✔
4	import { formatStat } from "../users/EAUserTooltipContent";	1✔
5
6	const styles = (theme: ThemeType) => ({	1✔
7	root: {
8	display: "flex",
9	fontFamily: theme.palette.fonts.sansSerifStack,
10	},
11	filters: {
12	display: "flex",
13	gap: "4px",
14	flexGrow: 1,
15	},
16	options: {
17	display: "flex",
18	gap: "4px",
19	},
20	columnsList: {
21	display: "flex",
22	flexDirection: "column",
23	gap: "12px",
24	padding: 16,
25	},
26	totalResults: {
27	display: "flex",
28	alignItems: "center",
29	marginLeft: 14,
30	fontWeight: 600,
31	color: theme.palette.grey[600],
32	},
33	});
34
35	export const PeopleDirectoryFilters = ({classes}: {	1✔
36	classes: ClassesType<typeof styles>,
37	}) => {
38	const {
39	view,
40	roles,
41	organizations,
42	locations,
43	careerStages,
44	columns,
45	columnsEdited,
46	resetColumns,
47	totalResults,
48	isEmptySearch,
UNCOV 49	} = usePeopleDirectory();	×
50	const {
51	PeopleDirectoryFilterDropdown, PeopleDirectorySelectOption,
52	PeopleDirectoryStaticFilter, PeopleDirectorySearchableFilter,
53	PeopleDirectoryClearAll, PeopleDirectoryViewToggle,
UNCOV 54	} = Components;	×
UNCOV 55	return (	×
56	<div className={classes.root}>
57	<div className={classes.filters}>
58	<PeopleDirectorySearchableFilter filter={roles} />
59	<PeopleDirectorySearchableFilter filter={organizations} />
60	<PeopleDirectoryStaticFilter filter={careerStages} />
61	<PeopleDirectorySearchableFilter filter={locations} />
62	{totalResults > 0 && !isEmptySearch &&	×
63	<div className={classes.totalResults}>
64	{formatStat(totalResults)} {totalResults === 1 ? "result" : "results"}	×
65	</div>
66	}
67	</div>
68	<div className={classes.options}>
69	{view === "list" &&	×
70	<PeopleDirectoryFilterDropdown
71	title="Columns"
72	icon="ViewColumns"
73	style="button"
74	className={classes.columnsList}
75	>
76	{columns.filter(({hideable}) => hideable).map((state) => (	×
UNCOV 77	<PeopleDirectorySelectOption state={state} key={state.value} />	×
78	))}
79	{columnsEdited &&	×
80	<div>
81	<PeopleDirectoryClearAll text="Reset" onClear={resetColumns} />
82	</div>
83	}
84	</PeopleDirectoryFilterDropdown>
85	}
86	<PeopleDirectoryViewToggle />
87	</div>
88	</div>
89	);
90	}
91
92	const PeopleDirectoryFiltersComponent = registerComponent(	1✔
93	"PeopleDirectoryFilters",
94	PeopleDirectoryFilters,
95	{styles},
96	);
97
98	declare global {
99	interface ComponentTypes {
100	PeopleDirectoryFilters: typeof PeopleDirectoryFiltersComponent
101	}
102	}

ForumMagnum / ForumMagnum / 10094625598

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous