10092068564

Committed 25 Jul 2024 09:59AM UTC coverage: 31.851% (-0.1%) from 31.952%

Build # 10092068564

Build Type

Pull #9532

github

Committed by

web-flow

Commit Message

Merge 30245f94b into 9ce0817c9

Pull Request Pull Request #9532: Merge master to lw-deploy 2024 07 22

Run Details

4932 of 40603 branches covered (12.15%)

Branch coverage included in aggregate %.

129 of 349 new or added lines in 55 files covered. (36.96%)

114 existing lines in 10 files now uncovered.

28887 of 65577 relevant lines covered (44.05%)

179.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/packages/lesswrong/lib/betas.ts

// Centralized control of beta-gated features. If a feature is restricted to
// admins or to users with the opt-in flag, implement that by defining a
// function here which returns whether a given user has access to that feature.
// That way, we can look here to see what features are currently beta-gated,
// and have an easy way to un-gate in all the relevant places at once.
//
// Beta-feature test functions must handle the case where user is null.

import {
  testServerSetting,
  isEAForum,
  isLWorAF,
  hasCommentsTableOfContentSetting,
  hasSideCommentsSetting, 
  hasDialoguesSetting, 
  hasPostInlineReactionsSetting,
  isBotSiteSetting,
  isLW,
} from './instanceSettings'
import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";
import {isFriendlyUI} from '../themes/forumTheme'
import { recombeeEnabledSetting } from './publicSettings';
import { useLocation } from './routeUtil';
import { isAnyTest } from './executionEnvironment';

// States for in-progress features
const adminOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars
const moderatorOnly = (user: UsersCurrent|DbUser|null): boolean => !!(user?.isAdmin || user?.groups?.includes('sunshineRegiment'))
const optInOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars
const shippedFeature = (user: UsersCurrent|DbUser|null): boolean => true; // eslint-disable-line no-unused-vars
const disabled = (user: UsersCurrent|DbUser|null): boolean => false; // eslint-disable-line no-unused-vars
const testServerOnly = (_: UsersCurrent|DbUser|null): boolean => testServerSetting.get();
const adminOrBeta = (user: UsersCurrent|DbUser|null): boolean => adminOnly(user) || optInOnly(user);

//////////////////////////////////////////////////////////////////////////////
// Features in progress                                                     //
//////////////////////////////////////////////////////////////////////////////

export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;
export const userHasBoldPostItems = disabled
export const userHasEAHomeHandbook = adminOnly
export const userCanCreateCommitMessages = moderatorOnly;
export const userHasRedesignedSettingsPage = disabled;
export const userCanUseSharing = (user: UsersCurrent|DbUser|null): boolean => moderatorOnly(user) || userOverNKarmaOrApproved(1)(user);
export const userHasNewTagSubscriptions =  isEAForum ? shippedFeature : disabled
export const userHasDefaultProfilePhotos = disabled

export const userHasAutosummarize = adminOnly

export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;

export const userHasCommentProfileImages = disabled;

export const userHasEagProfileImport = disabled;

export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;

export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;

export const userHasPeopleDirectory = (user: UsersCurrent|DbUser|null) =>
  isEAForum;

export const userHasSubscribeTabFeed = isLW ? shippedFeature : disabled;

//defining as Hook so as to combine with ABTest
export const useRecombeeFrontpage = (currentUser: UsersCurrent|DbUser|null) => {
  // TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
  // const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
  // const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
  const { query } = useLocation();
  
  const manualOptIn = currentUser && query.recExperiment === 'true';

  return isLW && (isAdmin(currentUser) || manualOptIn) && recombeeEnabledSetting.get()
}

export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;

// Non-user-specific features
export const dialoguesEnabled = hasDialoguesSetting.get();
export const ckEditorUserSessionsEnabled = isLWorAF;
export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();
export const allowSubscribeToUserComments = true;
export const allowSubscribeToSequencePosts = isFriendlyUI;
/** On the post page, do we show users other content they might want to read */
export const hasPostRecommendations = isEAForum;
/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
export const hasDigests = isEAForum;
export const hasAccountDeletionFlow = isEAForum;
export const hasSideComments = hasSideCommentsSetting.get();
export const useElicitApi = false;
export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();
export const fullHeightToCEnabled = isLWorAF;
export const hasForumEvents = isEAForum;
export const hasSurveys = isFriendlyUI && !isBotSiteSetting.get();
export const hasCollapsedFootnotes = !isLWorAF;
export const useCurationEmailsCron = isLW;

// EA Forum disabled the author's ability to moderate posts. We disregard this
// check in tests as the tests run in EA Forum mode, but we want to be able to
// test the moderation features.
export const hasAuthorModeration = !isEAForum || isAnyTest;

// Shipped Features
export const userCanManageTags = shippedFeature;
export const userCanCreateTags = shippedFeature;
export const userCanUseTags = shippedFeature;
export const userCanViewRevisionHistory = shippedFeature;
export const userHasPingbacks = shippedFeature;
export const userHasElasticsearch = shippedFeature;

1	// Centralized control of beta-gated features. If a feature is restricted to	400✔
2	// admins or to users with the opt-in flag, implement that by defining a
3	// function here which returns whether a given user has access to that feature.
4	// That way, we can look here to see what features are currently beta-gated,
5	// and have an easy way to un-gate in all the relevant places at once.
6	//
7	// Beta-feature test functions must handle the case where user is null.
8
9	import {
10	testServerSetting,
11	isEAForum,
12	isLWorAF,
13	hasCommentsTableOfContentSetting,
14	hasSideCommentsSetting,
15	hasDialoguesSetting,
16	hasPostInlineReactionsSetting,
17	isBotSiteSetting,
18	isLW,
19	} from './instanceSettings'	28✔
20	import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";	28✔
21	import {isFriendlyUI} from '../themes/forumTheme'	28✔
22	import { recombeeEnabledSetting } from './publicSettings';	28✔
23	import { useLocation } from './routeUtil';	28✔
24	import { isAnyTest } from './executionEnvironment';	28✔
25
26	// States for in-progress features
27	const adminOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars	28!
28	const moderatorOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!(user?.isAdmin \|\| user?.groups?.includes('sunshineRegiment'))	28!
29	const optInOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars	28!
30	const shippedFeature = (user: UsersCurrent\|DbUser\|null): boolean => true; // eslint-disable-line no-unused-vars	28✔
31	const disabled = (user: UsersCurrent\|DbUser\|null): boolean => false; // eslint-disable-line no-unused-vars	28✔
32	const testServerOnly = (_: UsersCurrent\|DbUser\|null): boolean => testServerSetting.get();	28✔
33	const adminOrBeta = (user: UsersCurrent\|DbUser\|null): boolean => adminOnly(user) \|\| optInOnly(user);	28!
34
35	//////////////////////////////////////////////////////////////////////////////
36	// Features in progress //
37	//////////////////////////////////////////////////////////////////////////////
38
39	export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;	28!
40	export const userHasBoldPostItems = disabled	28✔
41	export const userHasEAHomeHandbook = adminOnly	28✔
42	export const userCanCreateCommitMessages = moderatorOnly;	28✔
43	export const userHasRedesignedSettingsPage = disabled;	28✔
44	export const userCanUseSharing = (user: UsersCurrent\|DbUser\|null): boolean => moderatorOnly(user) \|\| userOverNKarmaOrApproved(1)(user);	28!
45	export const userHasNewTagSubscriptions = isEAForum ? shippedFeature : disabled	28!
46	export const userHasDefaultProfilePhotos = disabled	28✔
47
48	export const userHasAutosummarize = adminOnly	28✔
49
50	export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;	28!
51
52	export const userHasCommentProfileImages = disabled;	28✔
53
54	export const userHasEagProfileImport = disabled;	28✔
55
56	export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;	28!
57
58	export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;	28!
59
60	export const userHasPeopleDirectory = (user: UsersCurrent\|DbUser\|null) =>	28✔
NEW 61	isEAForum;	×
62
63	export const userHasSubscribeTabFeed = isLW ? shippedFeature : disabled;	28!
64
65	//defining as Hook so as to combine with ABTest
66	export const useRecombeeFrontpage = (currentUser: UsersCurrent\|DbUser\|null) => {	28✔
67	// TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
68	// const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
69	// const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
70	const { query } = useLocation();	×
71
72	const manualOptIn = currentUser && query.recExperiment === 'true';	×
73
74	return isLW && (isAdmin(currentUser) \|\| manualOptIn) && recombeeEnabledSetting.get()	×
75	}
76
77	export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;	28!
78
79	// Non-user-specific features
80	export const dialoguesEnabled = hasDialoguesSetting.get();	28✔
81	export const ckEditorUserSessionsEnabled = isLWorAF;	28✔
82	export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();	28✔
83	export const allowSubscribeToUserComments = true;	28✔
84	export const allowSubscribeToSequencePosts = isFriendlyUI;	28✔
85	/** On the post page, do we show users other content they might want to read */
86	export const hasPostRecommendations = isEAForum;	28✔
87	/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
88	export const hasDigests = isEAForum;	28✔
89	export const hasAccountDeletionFlow = isEAForum;	28✔
90	export const hasSideComments = hasSideCommentsSetting.get();	28✔
91	export const useElicitApi = false;	28✔
92	export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();	28✔
93	export const fullHeightToCEnabled = isLWorAF;	28✔
94	export const hasForumEvents = isEAForum;	28✔
95	export const hasSurveys = isFriendlyUI && !isBotSiteSetting.get();	28✔
96	export const hasCollapsedFootnotes = !isLWorAF;	28✔
97	export const useCurationEmailsCron = isLW;	28✔
98
99	// EA Forum disabled the author's ability to moderate posts. We disregard this
100	// check in tests as the tests run in EA Forum mode, but we want to be able to
101	// test the moderation features.
102	export const hasAuthorModeration = !isEAForum \|\| isAnyTest;	28✔
103
104	// Shipped Features
105	export const userCanManageTags = shippedFeature;	28✔
106	export const userCanCreateTags = shippedFeature;	28✔
107	export const userCanUseTags = shippedFeature;	28✔
108	export const userCanViewRevisionHistory = shippedFeature;	28✔
109	export const userHasPingbacks = shippedFeature;	28✔
110	export const userHasElasticsearch = shippedFeature;	28✔

ForumMagnum / ForumMagnum / 10092068564

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous