9958882167

Committed 16 Jul 2024 02:33PM UTC coverage: 84.513%. First build

Build # 9958882167

Build Type

Pull #3426

github

Committed by

web-flow

Commit Message

Merge 51145d597 into 410ec6629

Pull Request Pull Request #3426: Add Tomte order validation rules

Run Details

42 of 56 new or added lines in 5 files covered. (75.0%)

20687 of 24478 relevant lines covered (84.51%)

0.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/cg/services/order_validation_service/validators/inter_field_validators.py

from cg.services.order_validation_service.models.order import Order
from cg.services.order_validation_service.models.errors import (
    OrderNameRequiredError,
    TicketNumberRequiredError,
    OrderValidationError,
)


def validate_ticket_number_required_if_connected(order: Order, **kwargs) -> list[OrderValidationError]:
    errors: list[OrderValidationError] = []
    if _is_ticket_number_missing(order):
        error = TicketNumberRequiredError()
        errors.append(error)
    return errors


def validate_name_required_for_new_order(order: Order, **kwargs) -> list[OrderValidationError]:
    errors: list[OrderValidationError] = []
    if _is_order_name_required(order):
        error = OrderNameRequiredError()
        errors.append(error)
    return errors


def _is_order_name_required(order: Order) -> bool:
    return not order.connect_to_ticket and not order.name


def _is_ticket_number_missing(order: Order) -> bool:
    return order.connect_to_ticket and not order.ticket_number

1	from cg.services.order_validation_service.models.order import Order	1✔
2	from cg.services.order_validation_service.models.errors import (	1✔
3	OrderNameRequiredError,
4	TicketNumberRequiredError,
5	OrderValidationError,
6	)
7
8
9	def validate_ticket_number_required_if_connected(order: Order, **kwargs) -> list[OrderValidationError]:	1✔
10	errors: list[OrderValidationError] = []	1✔
11	if _is_ticket_number_missing(order):	1✔
12	error = TicketNumberRequiredError()	1✔
13	errors.append(error)	1✔
14	return errors	1✔
15
16
17	def validate_name_required_for_new_order(order: Order, **kwargs) -> list[OrderValidationError]:	1✔
NEW 18	errors: list[OrderValidationError] = []	×
NEW 19	if _is_order_name_required(order):	×
NEW 20	error = OrderNameRequiredError()	×
NEW 21	errors.append(error)	×
NEW 22	return errors	×
23
24
25	def _is_order_name_required(order: Order) -> bool:	1✔
NEW 26	return not order.connect_to_ticket and not order.name	×
27
28
29	def _is_ticket_number_missing(order: Order) -> bool:	1✔
30	return order.connect_to_ticket and not order.ticket_number	1✔

Clinical-Genomics / cg / 9958882167

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous