9946483166

Committed 15 Jul 2024 08:52PM UTC coverage: 94.991% (+2.7%) from 92.3%

Build # 9946483166

Build Type

Pull #27

github

Committed by

web-flow

Commit Message

Merge 18ba11b53 into d511103fe

Pull Request Pull Request #27: refactor: use plain `id` on `fetch`

Run Details

510 of 521 branches covered (97.89%)

Branch coverage included in aggregate %.

433 of 441 new or added lines in 28 files covered. (98.19%)

10 existing lines in 1 file now uncovered.

2202 of 2334 relevant lines covered (94.34%)

26.74 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.23

/test/unit/repository/fetch/fetch.spec.js

import assert from 'node:assert'
import { test } from 'node:test'
import ioredis from 'ioredis-mock'

import { Repository } from '../../../../src/repository.js'
import { Building } from '../../../util/model/index.js'

test('Repository', async t => {
  let repo, fetched

  await t.test('#fetch', async t => {
    t.beforeEach(() => {
      repo = new Repository(Building, new ioredis())
    })

    await t.test('no parameter is passed', async t => {
      await t.test('rejects with error', async () => {
        await assert.rejects(
          async () => {
            await repo.fetch()
          }
        )
      })
    })

    await t.test('passed "id" is an empty string', async t => {
      await t.test('rejects with error', async () => {
        await assert.rejects(
          async () => {
            await repo.fetch('')
          }
        )
      })
    })

    await t.test('passed "id" is a valid string', async t => {
      await t.test('resolves', async () => {
        await assert.doesNotReject(
          async () => {
            await repo.fetch('ciBr8Y')
          }
        )
      })
    })

    await t.test('passed "id" does not exist', async t => {
      await t.beforeEach(async () => {
        fetched = await repo.fetch('non-existent-id')
      })

      await t.test('resolves with null', async () => {
        assert.ok(fetched === null, 'result is null')
      })
    })

    t.todo('passed "id" exists', async t => {
      await t.beforeEach(async () => {
        await repo.save(new Building({ id: 'foo' }))

        fetched = await repo.fetch('foo')
      })

      await t.test('resolves with hydrated instance', async () => {
        // @TODO
        // throws `hashes.map is not a function`, maybe because `ioredis-mock`
        console.log(fetched)
      })
    })
  })
})

1	import assert from 'node:assert'	1✔
2	import { test } from 'node:test'	1✔
3	import ioredis from 'ioredis-mock'	1✔
4		1✔
5	import { Repository } from '../../../../src/repository.js'	1✔
6	import { Building } from '../../../util/model/index.js'	1✔
7		1✔
8	test('Repository', async t => {	1✔
9	let repo, fetched	1✔
10		1✔
11	await t.test('#fetch', async t => {	1✔
12	t.beforeEach(() => {	1✔
13	repo = new Repository(Building, new ioredis())	8✔
14	})	1✔
15		1✔
16	await t.test('no parameter is passed', async t => {	1✔
17	await t.test('rejects with error', async () => {	1✔
18	await assert.rejects(	1✔
19	async () => {	1✔
20	await repo.fetch()	1!
21	}	1✔
22	)	1✔
23	})	1✔
24	})	1✔
25		1✔
26	await t.test('passed "id" is an empty string', async t => {	1✔
27	await t.test('rejects with error', async () => {	1✔
28	await assert.rejects(	1✔
29	async () => {	1✔
30	await repo.fetch('')	1!
31	}	1✔
32	)	1✔
33	})	1✔
34	})	1✔
35		1✔
36	await t.test('passed "id" is a valid string', async t => {	1✔
37	await t.test('resolves', async () => {	1✔
38	await assert.doesNotReject(	1✔
39	async () => {	1✔
40	await repo.fetch('ciBr8Y')	1✔
41	}	1✔
42	)	1✔
43	})	1✔
44	})	1✔
45		1✔
46	await t.test('passed "id" does not exist', async t => {	1✔
47	await t.beforeEach(async () => {	1✔
48	fetched = await repo.fetch('non-existent-id')	1✔
49	})	1✔
50		1✔
51	await t.test('resolves with null', async () => {	1✔
52	assert.ok(fetched === null, 'result is null')	1✔
53	})	1✔
54	})	1✔
55		1✔
56	t.todo('passed "id" exists', async t => {	1✔
UNCOV 57	await t.beforeEach(async () => {	×
NEW UNCOV 58	await repo.save(new Building({ id: 'foo' }))	×
UNCOV 59		×
NEW UNCOV 60	fetched = await repo.fetch('foo')	×
UNCOV 61	})	×
UNCOV 62		×
UNCOV 63	await t.test('resolves with hydrated instance', async () => {	×
UNCOV 64	// @TODO	×
UNCOV 65	// throws `hashes.map is not a function`, maybe because `ioredis-mock`	×
UNCOV 66	console.log(fetched)	×
67	})	×
68	})	1✔
69	})	1✔
70	})	1✔

nicholaswmin / automap / 9946483166

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous