1420

Committed 11 Jul 2024 02:14PM UTC coverage: 78.936% (+0.02%) from 78.915%

Build # 1420

Build Type

push

circleci

Committed by Oleg Khasimkhanov

Commit Message

format data

Run Details

336 of 509 branches covered (66.01%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

1193 of 1428 relevant lines covered (83.54%)

3.58 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.95

/src/onedrive/refresh/index.js

const constants = require("../../constants");
const utils = require("../../utils");
const oauthTokenProvider = require("../../redis-otp/microsoft");
const onedriveApi = require("../api");
const storageApi = require("../api/rise-storage");
const cacheApi = require("../../redis-cache/api");

const {
  PROVIDER_NAME_MS_GRAPH,
  ENDPOINT_NAME_SUBSCRIBE,
  ENDPOINT_NAME_REFRESH,
  BAD_REQUEST_ERROR,
} = constants;

const MIN_DOCUMENT_REFRESH_IN_MINUTES = 60;
const CACHE_EXPIRY_IN_SECONDS = 90 * constants.DAYS;

const getLoggingDetails = (account) => {
  return `account: ${account}`;
};

const validateQueryParams = (req, endpoint) => {
  const { id, cid, provider, account, refresh } = req.body || {};

  let props = [id, cid, provider, account];
  let refreshNumber = null;

  if (endpoint === ENDPOINT_NAME_REFRESH) {
    props.push(refresh);
  }

  return utils
    .validateRequest(req, props, [PROVIDER_NAME_MS_GRAPH])
    .then(() => {
      if (endpoint === ENDPOINT_NAME_SUBSCRIBE) {
        return Promise.resolve({
          ...req.body,
        });
      }

      refreshNumber = parseInt(refresh, 10);

      if (
        Number.isNaN(refreshNumber) ||
        refreshNumber < MIN_DOCUMENT_REFRESH_IN_MINUTES
      ) {
        return Promise.reject(
          new Error(`'refresh' is not a valid integer value: ${refresh}`)
        );
      }

      return Promise.resolve({
        ...req.body,
        refresh: refreshNumber,
      });
    });
};

const getCacheKey = (account, id) => {
  return `${account}:${id}:onedrive:fileinfo`;
};

const refreshDocument = async (body, now) => {
  const { account, id, cid, refresh } = body || {};

  const key = getCacheKey(account, id);
  const cachedData = (await cacheApi.getData(key)) || {};

  if (
    cachedData.lastRefresh &&
    cachedData.lastRefresh + refresh * constants.MINUTES > now
  ) {
    return Promise.resolve({
      result: true,
      cached: true,
      message: "refresh is not needed",
    });
  }

  // update lastRefresh right away to stop other concurrent refresh requests from proceeding further
  cachedData.lastRefresh = now;
  await cacheApi.saveDataEx(key, cachedData, CACHE_EXPIRY_IN_SECONDS);
  console.log(
    "cachedData with key " + key + " and expiry " + CACHE_EXPIRY_IN_SECONDS
  );

  const fileInfo = await getFileInfo(account, id);
  if (
    fileInfo?.lastModified &&
    fileInfo.lastModified === cachedData.lastModified
  ) {
    return Promise.resolve({
      result: true,
      cached: true,
      message: "file did not change",
    });
  }

  // update lastModified
  cachedData.lastModified = fileInfo.lastModified;
  await cacheApi.saveDataEx(key, cachedData, CACHE_EXPIRY_IN_SECONDS);
  console.log(
    "cachedData2 with key " + key + " and expiry " + CACHE_EXPIRY_IN_SECONDS
  );

  const assetId = `${account}_${id}`;
  const storageResponse = await storageApi.requestAssets(
    cid,
    assetId,
    fileInfo.downloadUrl
  );
  return Promise.resolve({
    result: storageResponse.result,
    cached: false,
    message: "file updated",
  });
};

const handleRefreshRequest = (req, res) => {
  return validateQueryParams(req, ENDPOINT_NAME_REFRESH)
    .then((body) => refreshDocument(body, Date.now()))
    .then((data) => {
      res.json(data);
    })
    .catch((error) => {
      const loggingDetails = getLoggingDetails(req.body.account);
      utils.sendError(
        res,
        ENDPOINT_NAME_REFRESH,
        error.message,
        BAD_REQUEST_ERROR,
        loggingDetails
      );
    });
};

const handleSubscribeRequest = (req, res) => {
  return validateQueryParams(req, ENDPOINT_NAME_SUBSCRIBE)
    .then((body) => refreshDocument({ ...body, refresh: 1 }, Date.now()))
    .then((data) => {
      res.json(data);
    })
    .catch((error) => {
      const loggingDetails = getLoggingDetails(req.body.account);
      utils.sendError(
        res,
        ENDPOINT_NAME_SUBSCRIBE,
        error.message,
        BAD_REQUEST_ERROR,
        loggingDetails
      );
    });
};

const getFileInfo = (account, id) => {
  return oauthTokenProvider
    .getAccessToken(account, constants.PROVIDER_NAME_MS_GRAPH)
    .then(({ access_token }) => onedriveApi.getFileInfo(access_token, id))
    .then((data) => {
      return {
        downloadUrl: data["@microsoft.graph.downloadUrl"],
        lastModified: data.lastModifiedDateTime,
      };
    });
};

module.exports = {
  handleSubscribeRequest,
  handleRefreshRequest,
};

1	const constants = require("../../constants");	1✔
2	const utils = require("../../utils");	1✔
3	const oauthTokenProvider = require("../../redis-otp/microsoft");	1✔
4	const onedriveApi = require("../api");	1✔
5	const storageApi = require("../api/rise-storage");	1✔
6	const cacheApi = require("../../redis-cache/api");	1✔
7
8	const {
9	PROVIDER_NAME_MS_GRAPH,
10	ENDPOINT_NAME_SUBSCRIBE,
11	ENDPOINT_NAME_REFRESH,
12	BAD_REQUEST_ERROR,
13	} = constants;	1✔
14
15	const MIN_DOCUMENT_REFRESH_IN_MINUTES = 60;	1✔
16	const CACHE_EXPIRY_IN_SECONDS = 90 * constants.DAYS;	1✔
17
18	const getLoggingDetails = (account) => {	1✔
19	return `account: ${account}`;	11✔
20	};
21
22	const validateQueryParams = (req, endpoint) => {	1✔
23	const { id, cid, provider, account, refresh } = req.body \|\| {};	12!
24
25	let props = [id, cid, provider, account];	12✔
26	let refreshNumber = null;	12✔
27
28	if (endpoint === ENDPOINT_NAME_REFRESH) {	12✔
29	props.push(refresh);	7✔
30	}
31
32	return utils	12✔
33	.validateRequest(req, props, [PROVIDER_NAME_MS_GRAPH])
34	.then(() => {
35	if (endpoint === ENDPOINT_NAME_SUBSCRIBE) {	3✔
36	return Promise.resolve({	1✔
37	...req.body,
38	});
39	}
40
41	refreshNumber = parseInt(refresh, 10);	2✔
42
43	if (	2!
44	Number.isNaN(refreshNumber) \|\|	3✔
45	refreshNumber < MIN_DOCUMENT_REFRESH_IN_MINUTES
46	) {
47	return Promise.reject(	2✔
48	new Error(`'refresh' is not a valid integer value: ${refresh}`)
49	);
50	}
51
52	return Promise.resolve({	×
53	...req.body,
54	refresh: refreshNumber,
55	});
56	});
57	};
58
59	const getCacheKey = (account, id) => {	1✔
60	return `${account}:${id}:onedrive:fileinfo`;	5✔
61	};
62
63	const refreshDocument = async (body, now) => {	1✔
64	const { account, id, cid, refresh } = body \|\| {};	4!
65
66	const key = getCacheKey(account, id);	4✔
67	const cachedData = (await cacheApi.getData(key)) \|\| {};	4!
68
69	if (	4✔
70	cachedData.lastRefresh &&	8✔
71	cachedData.lastRefresh + refresh * constants.MINUTES > now
72	) {
73	return Promise.resolve({	1✔
74	result: true,
75	cached: true,
76	message: "refresh is not needed",
77	});
78	}
79
80	// update lastRefresh right away to stop other concurrent refresh requests from proceeding further
81	cachedData.lastRefresh = now;	3✔
82	await cacheApi.saveDataEx(key, cachedData, CACHE_EXPIRY_IN_SECONDS);	3✔
83	console.log(	3✔
84	"cachedData with key " + key + " and expiry " + CACHE_EXPIRY_IN_SECONDS
85	);
86
87	const fileInfo = await getFileInfo(account, id);	3✔
88	if (	2✔
89	fileInfo?.lastModified &&	4✔
90	fileInfo.lastModified === cachedData.lastModified
91	) {
92	return Promise.resolve({	1✔
93	result: true,
94	cached: true,
95	message: "file did not change",
96	});
97	}
98
99	// update lastModified
100	cachedData.lastModified = fileInfo.lastModified;	1✔
101	await cacheApi.saveDataEx(key, cachedData, CACHE_EXPIRY_IN_SECONDS);	1✔
102	console.log(	1✔
103	"cachedData2 with key " + key + " and expiry " + CACHE_EXPIRY_IN_SECONDS
104	);
105
106	const assetId = `${account}_${id}`;	1✔
107	const storageResponse = await storageApi.requestAssets(	1✔
108	cid,
109	assetId,
110	fileInfo.downloadUrl
111	);
112	return Promise.resolve({	1✔
113	result: storageResponse.result,
114	cached: false,
115	message: "file updated",
116	});
117	};
118
119	const handleRefreshRequest = (req, res) => {	1✔
120	return validateQueryParams(req, ENDPOINT_NAME_REFRESH)	7✔
UNCOV 121	.then((body) => refreshDocument(body, Date.now()))	×
122	.then((data) => {
UNCOV 123	res.json(data);	×
124	})
125	.catch((error) => {
126	const loggingDetails = getLoggingDetails(req.body.account);	7✔
127	utils.sendError(	7✔
128	res,
129	ENDPOINT_NAME_REFRESH,
130	error.message,
131	BAD_REQUEST_ERROR,
132	loggingDetails
133	);
134	});
135	};
136
137	const handleSubscribeRequest = (req, res) => {	1✔
138	return validateQueryParams(req, ENDPOINT_NAME_SUBSCRIBE)	5✔
139	.then((body) => refreshDocument({ ...body, refresh: 1 }, Date.now()))	1✔
140	.then((data) => {
141	res.json(data);	1✔
142	})
143	.catch((error) => {
144	const loggingDetails = getLoggingDetails(req.body.account);	4✔
145	utils.sendError(	4✔
146	res,
147	ENDPOINT_NAME_SUBSCRIBE,
148	error.message,
149	BAD_REQUEST_ERROR,
150	loggingDetails
151	);
152	});
153	};
154
155	const getFileInfo = (account, id) => {	1✔
UNCOV 156	return oauthTokenProvider	×
157	.getAccessToken(account, constants.PROVIDER_NAME_MS_GRAPH)
UNCOV 158	.then(({ access_token }) => onedriveApi.getFileInfo(access_token, id))	×
159	.then((data) => {
UNCOV 160	return {	×
161	downloadUrl: data["@microsoft.graph.downloadUrl"],
162	lastModified: data.lastModifiedDateTime,
163	};
164	});
165	};
166
167	module.exports = {	1✔
168	handleSubscribeRequest,
169	handleRefreshRequest,
170	};

Rise-Vision / google-service / 1420

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous