9886114438

Committed 11 Jul 2024 05:38AM UTC coverage: 92.868% (-0.6%) from 93.438%

Build # 9886114438

Build Type

Pull #265

github

Committed by

SushilMallRC

Commit Message

remove return

Pull Request Pull Request #265: Support asynchronous externals.localStorage API

Run Details

580 of 710 branches covered (81.69%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

14 existing lines in 2 files now uncovered.

1920 of 1982 relevant lines covered (96.87%)

41.95 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.85

/sdk/src/core/Cache.ts

import Externals from './Externals';

export interface CacheOptions {
    prefix?: string;
    externals: Externals;
}

export default class Cache {
    public static defaultPrefix = 'rc-';

    private readonly _prefix = null;

    private _externals = null;

    public constructor({prefix = Cache.defaultPrefix, externals}: CacheOptions) {
        this._prefix = prefix;
        this._externals = externals;
    }

    public setItemSync(key, data) {
        this._externals.localStorage.setItem(this._prefixKey(key), JSON.stringify(data));
        return this;
    }

    public async setItem(key, data) {
        await this._externals.localStorage.setItem(this._prefixKey(key), JSON.stringify(data));
        //this.setItemSync(key, data);
    }

    public removeItemSync(key) {
        this._externals.localStorage.removeItem(this._prefixKey(key));
        return this;
    }

    public async removeItem(key) {
        await this._externals.localStorage.removeItem(this._prefixKey(key));
        //await this.removeItemSync(key);
    }

    public getItemSync(key) {
        const item = this._externals.localStorage.getItem(this._prefixKey(key));
        if (!item) {return null;}
        return JSON.parse(item);
    }

    public async getItem(key) {
        const item = await this._externals.localStorage.getItem(this._prefixKey(key));
        if (!item) {return null;}
        return JSON.parse(item);
       // return this.getItemSync(key);
    }

    private async _keys(): Promise<string[]> {
        return 'keys' in this._externals.localStorage
            ? this._externals.localStorage.keys() // could be async
            : Object.keys(this._externals.localStorage);
    }

    public async clean() {
        await Promise.all(
            (await this._keys()).map(async key => {
                if (key.startsWith(this._prefix)) {
                    await this._externals.localStorage.removeItem(key);
                }
            }),
        );

        return this;
    }

    private _prefixKey(key: string) {
        return this._prefix + key;
    }
}

1	import Externals from './Externals';
2
3	export interface CacheOptions {
4	prefix?: string;
5	externals: Externals;
6	}
7
8	export default class Cache {	4✔
9	public static defaultPrefix = 'rc-';	4✔
10
11	private readonly _prefix = null;	97✔
12
13	private _externals = null;	97✔
14
15	public constructor({prefix = Cache.defaultPrefix, externals}: CacheOptions) {	97✔
16	this._prefix = prefix;	97✔
17	this._externals = externals;	97✔
18	}
19
20	public setItemSync(key, data) {	4✔
UNCOV 21	this._externals.localStorage.setItem(this._prefixKey(key), JSON.stringify(data));	×
UNCOV 22	return this;	×
23	}
24
25	public async setItem(key, data) {	4✔
26	await this._externals.localStorage.setItem(this._prefixKey(key), JSON.stringify(data));	326✔
27	//this.setItemSync(key, data);
28	}
29
30	public removeItemSync(key) {	4✔
UNCOV 31	this._externals.localStorage.removeItem(this._prefixKey(key));	×
UNCOV 32	return this;	×
33	}
34
35	public async removeItem(key) {	4✔
36	await this._externals.localStorage.removeItem(this._prefixKey(key));	6✔
37	//await this.removeItemSync(key);
38	}
39
40	public getItemSync(key) {	4✔
UNCOV 41	const item = this._externals.localStorage.getItem(this._prefixKey(key));	×
UNCOV 42	if (!item) {return null;}	×
UNCOV 43	return JSON.parse(item);	×
44	}
45
46	public async getItem(key) {	4✔
47	const item = await this._externals.localStorage.getItem(this._prefixKey(key));	423✔
48	if (!item) {return null;}	423✔
49	return JSON.parse(item);	317✔
50	// return this.getItemSync(key);
51	}
52
53	private async _keys(): Promise<string[]> {	4✔
54	return 'keys' in this._externals.localStorage	156!
55	? this._externals.localStorage.keys() // could be async
56	: Object.keys(this._externals.localStorage);
57	}
58
59	public async clean() {	4✔
60	await Promise.all(	312✔
61	(await this._keys()).map(async key => {	156✔
62	if (key.startsWith(this._prefix)) {	111✔
63	await this._externals.localStorage.removeItem(key);	206✔
64	}
65	}),
66	);
67
68	return this;	156✔
69	}
70
71	private _prefixKey(key: string) {	4✔
72	return this._prefix + key;	589✔
73	}
74	}	4✔

ringcentral / ringcentral-js / 9886114438

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous