9880269719

Committed 10 Jul 2024 07:28PM UTC coverage: 31.895% (+0.05%) from 31.842%

Build # 9880269719

Build Type

Pull #9498

github

Committed by

web-flow

Commit Message

Merge 1e3560917 into 7b3dfee56

Pull Request Pull Request #9498: hide deleted sequences across the site

Run Details

4901 of 40197 branches covered (12.19%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

28601 of 64842 relevant lines covered (44.11%)

180.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

25.81

/packages/lesswrong/lib/collections/sequences/permissions.ts

import { membersGroup, adminsGroup, userCanDo, userOwns } from '../../vulcan-users/permissions';
import { Sequences } from './collection';

const membersActions = [
  'sequences.edit.own',
  'sequences.new.own',
  'sequences.remove.own',
  'chapters.new.own',
  'chapters.remote.own',
  'chapters.edit.own',
];
membersGroup.can(membersActions);

const adminActions= [
  'sequences.edit.all',
  'sequences.view.all',
  'sequences.new.all'
]
adminsGroup.can(adminActions);

export const SHOW_NEW_SEQUENCE_KARMA_THRESHOLD = 100;

Sequences.checkAccess = async (user, document) => {
  if (!document || document.isDeleted) {
    return false;
  }
  
  // If it isn't a draft, it's public
  if (!document.draft) {
    return true;
  }
  
  if (!user) {
    return false;
  }
  
  if (userOwns(user, document)) {
    return true;
  } else if (userCanDo(user, `sequences.view.all`)) {
    return true;
  } else {
    return false;
  }
}

1	import { membersGroup, adminsGroup, userCanDo, userOwns } from '../../vulcan-users/permissions';	57✔
2	import { Sequences } from './collection';	19✔
3
4	const membersActions = [	19✔
5	'sequences.edit.own',
6	'sequences.new.own',
7	'sequences.remove.own',
8	'chapters.new.own',
9	'chapters.remote.own',
10	'chapters.edit.own',
11	];
12	membersGroup.can(membersActions);	19✔
13
14	const adminActions= [	19✔
15	'sequences.edit.all',
16	'sequences.view.all',
17	'sequences.new.all'
18	]
19	adminsGroup.can(adminActions);	19✔
20
21	export const SHOW_NEW_SEQUENCE_KARMA_THRESHOLD = 100;	19✔
22
23	Sequences.checkAccess = async (user, document) => {	19✔
NEW 24	if (!document \|\| document.isDeleted) {	×
25	return false;	×
26	}
27
28	// If it isn't a draft, it's public
NEW 29	if (!document.draft) {	×
UNCOV 30	return true;	×
31	}
32
33	if (!user) {	×
34	return false;	×
35	}
36
37	if (userOwns(user, document)) {	×
38	return true;	×
39	} else if (userCanDo(user, `sequences.view.all`)) {	×
40	return true;	×
41	} else {
42	return false;	×
43	}
44	}

ForumMagnum / ForumMagnum / 9880269719

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous