9843406135

Committed 08 Jul 2024 04:29PM UTC coverage: 48.139% (-0.1%) from 48.257%

Build # 9843406135

Build Type

Pull #1715

github

Committed by

hectorgomezv

Commit Message

Refactor UpsertAccountDataSettingsDto to use ids instead of names

Pull Request Pull Request #1715: Implement PUT /v1/accounts/:address/data-settings

Run Details

412 of 2595 branches covered (15.88%)

Branch coverage included in aggregate %.

22 of 58 new or added lines in 8 files covered. (37.93%)

2 existing lines in 2 files now uncovered.

4244 of 7077 relevant lines covered (59.97%)

13.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.12

/src/domain/accounts/accounts.repository.ts

import { IAccountsRepository } from '@/domain/accounts/accounts.repository.interface';
import { AccountDataSetting } from '@/domain/accounts/entities/account-data-setting.entity';
import { AccountDataType } from '@/domain/accounts/entities/account-data-type.entity';
import {
  Account,
  AccountSchema,
} from '@/domain/accounts/entities/account.entity';
import { UpsertAccountDataSettingsDto } from '@/domain/accounts/entities/upsert-account-data-settings.dto.entity';
import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';
import { IAccountsDatasource } from '@/domain/interfaces/accounts.datasource.interface';
import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';

@Injectable()
export class AccountsRepository implements IAccountsRepository {
  constructor(
    @Inject(IAccountsDatasource)
    private readonly datasource: IAccountsDatasource,
  ) {}

  async createAccount(args: {
    authPayload: AuthPayload;
    address: `0x${string}`;
  }): Promise<Account> {
    if (!args.authPayload.isForSigner(args.address)) {
      throw new UnauthorizedException();
    }
    const account = await this.datasource.createAccount(args.address);
    return AccountSchema.parse(account);
  }

  async getAccount(args: {
    authPayload: AuthPayload;
    address: `0x${string}`;
  }): Promise<Account> {
    if (!args.authPayload.isForSigner(args.address)) {
      throw new UnauthorizedException();
    }
    const account = await this.datasource.getAccount(args.address);
    return AccountSchema.parse(account);
  }

  async deleteAccount(args: {
    authPayload: AuthPayload;
    address: `0x${string}`;
  }): Promise<void> {
    if (!args.authPayload.isForSigner(args.address)) {
      throw new UnauthorizedException();
    }
    // TODO: trigger a cascade deletion of the account-associated data.
    return this.datasource.deleteAccount(args.address);
  }

  async getDataTypes(): Promise<AccountDataType[]> {
    return this.datasource.getDataTypes();
  }

  async upsertAccountDataSettings(args: {
    authPayload: AuthPayload;
    address: `0x${string}`;
    upsertAccountDataSettings: UpsertAccountDataSettingsDto;
  }): Promise<AccountDataSetting[]> {
    const { address, upsertAccountDataSettings } = args;
    if (!args.authPayload.isForSigner(args.address)) {
      throw new UnauthorizedException();
    }
    if (upsertAccountDataSettings.accountDataSettings.length === 0) {
      return [];
    }

    return this.datasource.upsertAccountDataSettings(
      address,
      upsertAccountDataSettings,
    );
  }
}

1	import { IAccountsRepository } from '@/domain/accounts/accounts.repository.interface';
2	import { AccountDataSetting } from '@/domain/accounts/entities/account-data-setting.entity';
3	import { AccountDataType } from '@/domain/accounts/entities/account-data-type.entity';
4	import {	16✔
5	Account,
6	AccountSchema,
7	} from '@/domain/accounts/entities/account.entity';
8	import { UpsertAccountDataSettingsDto } from '@/domain/accounts/entities/upsert-account-data-settings.dto.entity';
9	import { AuthPayload } from '@/domain/auth/entities/auth-payload.entity';
10	import { IAccountsDatasource } from '@/domain/interfaces/accounts.datasource.interface';	16✔
11	import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';	16✔
12
13	@Injectable()
14	export class AccountsRepository implements IAccountsRepository {	16✔
15	constructor(
16	@Inject(IAccountsDatasource)
17	private readonly datasource: IAccountsDatasource,	×
18	) {}
19
20	async createAccount(args: {
21	authPayload: AuthPayload;
22	address: `0x${string}`;
23	}): Promise<Account> {
24	if (!args.authPayload.isForSigner(args.address)) {	×
25	throw new UnauthorizedException();	×
26	}
27	const account = await this.datasource.createAccount(args.address);	×
28	return AccountSchema.parse(account);	×
29	}
30
31	async getAccount(args: {
32	authPayload: AuthPayload;
33	address: `0x${string}`;
34	}): Promise<Account> {
35	if (!args.authPayload.isForSigner(args.address)) {	×
36	throw new UnauthorizedException();	×
37	}
38	const account = await this.datasource.getAccount(args.address);	×
39	return AccountSchema.parse(account);	×
40	}
41
42	async deleteAccount(args: {
43	authPayload: AuthPayload;
44	address: `0x${string}`;
45	}): Promise<void> {
46	if (!args.authPayload.isForSigner(args.address)) {	×
47	throw new UnauthorizedException();	×
48	}
49	// TODO: trigger a cascade deletion of the account-associated data.
50	return this.datasource.deleteAccount(args.address);	×
51	}
52
53	async getDataTypes(): Promise<AccountDataType[]> {
UNCOV 54	return this.datasource.getDataTypes();	×
55	}
56
57	async upsertAccountDataSettings(args: {
58	authPayload: AuthPayload;
59	address: `0x${string}`;
60	upsertAccountDataSettings: UpsertAccountDataSettingsDto;
61	}): Promise<AccountDataSetting[]> {
NEW 62	const { address, upsertAccountDataSettings } = args;	×
NEW 63	if (!args.authPayload.isForSigner(args.address)) {	×
NEW 64	throw new UnauthorizedException();	×
65	}
NEW 66	if (upsertAccountDataSettings.accountDataSettings.length === 0) {	×
NEW 67	return [];	×
68	}
69
NEW 70	return this.datasource.upsertAccountDataSettings(	×
71	address,
72	upsertAccountDataSettings,
73	);
74	}
75	}

safe-global / safe-client-gateway / 9843406135

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous