9841305318

Committed 08 Jul 2024 02:16PM UTC coverage: 66.34% (-0.1%) from 66.486%

Build # 9841305318

Build Type

Pull #2265

github

Committed by

web-flow

Commit Message

Merge 35f368670 into 47b4d7d49

Pull Request Pull Request #2265: feat: create bids trades

Run Details

2608 of 5097 branches covered (51.17%)

Branch coverage included in aggregate %.

51 of 145 new or added lines in 9 files covered. (35.17%)

1 existing line in 1 file now uncovered.

7627 of 10331 relevant lines covered (73.83%)

77.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

15.91

/webapp/src/modules/bid/utils.ts

import { ethers, BigNumber } from 'ethers'
import { Bid, TradeAssetType, TradeCreation, TradeType } from '@dcl/schemas'
import { getNetworkProvider, getSigner } from 'decentraland-dapps/dist/lib/eth'
import { t } from 'decentraland-dapps/dist/modules/translation/utils'
import { ContractName, getContract } from 'decentraland-transactions'
import { isErrorWithMessage } from '../../lib/error'
import { getOffChainMarketplaceContract, getTradeSignature } from '../../utils/trades'
import { Item } from '../item/types'
import { NFT } from '../nft/types'

export async function isInsufficientMANA(bid: Bid) {
  try {
    const provider = await getNetworkProvider(bid.chainId)
    const contract = getContract(ContractName.MANAToken, bid.chainId)
    const mana = new ethers.Contract(contract.address, contract.abi, new ethers.providers.Web3Provider(provider))
    const balanceRaw = (await mana.balanceOf(bid.bidder)) as BigNumber
    const balance = parseFloat(ethers.utils.formatEther(balanceRaw))
    const price = parseFloat(ethers.utils.formatEther(bid.price))

    return balance < price
  } catch (error) {
    console.warn(isErrorWithMessage(error) ? error.message : t('global.unknown_error'))
  }
  return false
}

export function checkFingerprint(bid: Bid, fingerprint: string | undefined) {
  if (fingerprint && bid.fingerprint) {
    return fingerprint === bid.fingerprint
  }
  return true
}

export function toBidObject(bids: Bid[]) {
  return bids.reduce(
    (obj, bid) => {
      obj[bid.id] = bid
      return obj
    },
    {} as Record<string, Bid>
  )
}

export async function createBidTrade(asset: NFT | Item, price: number, expiresAt: number, fingerprint?: string): Promise<TradeCreation> {
  const signer = await getSigner()
  const address = await signer.getAddress()
  const marketplaceContract = await getOffChainMarketplaceContract(asset.chainId)
  const manaContract = getContract(ContractName.MANAToken, asset.chainId)
  const contractSignatureIndex = (await marketplaceContract.contractSignatureIndex()) as BigNumber
  const signerSignatureIndex = (await marketplaceContract.signerSignatureIndex(address)) as BigNumber

  const tradeToSign: Omit<TradeCreation, 'signature'> = {
    signer: address,
    network: asset.network,
    chainId: asset.chainId,
    type: TradeType.BID,
    checks: {
      uses: 1,
      allowedRoot: '0x',
      contractSignatureIndex: contractSignatureIndex.toNumber(),
      signerSignatureIndex: signerSignatureIndex.toNumber(),
      effective: Date.now(),
      expiration: expiresAt,
      externalChecks: [],
      salt: '0x'
    },
    sent: [
      {
        assetType: TradeAssetType.ERC20,
        contractAddress: manaContract.address,
        amount: ethers.utils.parseEther(price.toString()).toString(),
        extra: ''
      }
    ],
    received: [
      {
        contractAddress: asset.contractAddress,
        extra: fingerprint || '',
        beneficiary: address,
        ...('tokenId' in asset
          ? { assetType: TradeAssetType.ERC721, tokenId: asset.tokenId }
          : { assetType: TradeAssetType.COLLECTION_ITEM, itemId: asset.itemId })
      }
    ]
  }

  return { ...tradeToSign, signature: await getTradeSignature(tradeToSign) }
}

1	import { ethers, BigNumber } from 'ethers'	35✔
2	import { Bid, TradeAssetType, TradeCreation, TradeType } from '@dcl/schemas'	35✔
3	import { getNetworkProvider, getSigner } from 'decentraland-dapps/dist/lib/eth'	35✔
4	import { t } from 'decentraland-dapps/dist/modules/translation/utils'	35✔
5	import { ContractName, getContract } from 'decentraland-transactions'	35✔
6	import { isErrorWithMessage } from '../../lib/error'	35✔
7	import { getOffChainMarketplaceContract, getTradeSignature } from '../../utils/trades'	35✔
8	import { Item } from '../item/types'
9	import { NFT } from '../nft/types'
10
11	export async function isInsufficientMANA(bid: Bid) {	×
12	try {	×
13	const provider = await getNetworkProvider(bid.chainId)	×
14	const contract = getContract(ContractName.MANAToken, bid.chainId)	×
15	const mana = new ethers.Contract(contract.address, contract.abi, new ethers.providers.Web3Provider(provider))	×
16	const balanceRaw = (await mana.balanceOf(bid.bidder)) as BigNumber	×
17	const balance = parseFloat(ethers.utils.formatEther(balanceRaw))	×
18	const price = parseFloat(ethers.utils.formatEther(bid.price))	×
19
20	return balance < price	×
21	} catch (error) {
22	console.warn(isErrorWithMessage(error) ? error.message : t('global.unknown_error'))	×
23	}
24	return false	×
25	}
26
27	export function checkFingerprint(bid: Bid, fingerprint: string \| undefined) {	×
28	if (fingerprint && bid.fingerprint) {	×
29	return fingerprint === bid.fingerprint	×
30	}
31	return true	×
32	}
33
34	export function toBidObject(bids: Bid[]) {	×
35	return bids.reduce(	×
36	(obj, bid) => {
37	obj[bid.id] = bid	×
38	return obj	×
39	},
40	{} as Record<string, Bid>
41	)
42	}
43
NEW 44	export async function createBidTrade(asset: NFT \| Item, price: number, expiresAt: number, fingerprint?: string): Promise<TradeCreation> {	×
NEW 45	const signer = await getSigner()	×
NEW 46	const address = await signer.getAddress()	×
NEW 47	const marketplaceContract = await getOffChainMarketplaceContract(asset.chainId)	×
NEW 48	const manaContract = getContract(ContractName.MANAToken, asset.chainId)	×
NEW 49	const contractSignatureIndex = (await marketplaceContract.contractSignatureIndex()) as BigNumber	×
NEW 50	const signerSignatureIndex = (await marketplaceContract.signerSignatureIndex(address)) as BigNumber	×
51
NEW 52	const tradeToSign: Omit<TradeCreation, 'signature'> = {	×
53	signer: address,
54	network: asset.network,
55	chainId: asset.chainId,
56	type: TradeType.BID,
57	checks: {
58	uses: 1,
59	allowedRoot: '0x',
60	contractSignatureIndex: contractSignatureIndex.toNumber(),
61	signerSignatureIndex: signerSignatureIndex.toNumber(),
62	effective: Date.now(),
63	expiration: expiresAt,
64	externalChecks: [],
65	salt: '0x'
66	},
67	sent: [
68	{
69	assetType: TradeAssetType.ERC20,
70	contractAddress: manaContract.address,
71	amount: ethers.utils.parseEther(price.toString()).toString(),
72	extra: ''
73	}
74	],
75	received: [
76	{
77	contractAddress: asset.contractAddress,
78	extra: fingerprint \|\| '',	×
79	beneficiary: address,
80	...('tokenId' in asset	×
81	? { assetType: TradeAssetType.ERC721, tokenId: asset.tokenId }
82	: { assetType: TradeAssetType.COLLECTION_ITEM, itemId: asset.itemId })
83	}
84	]
85	}
86
NEW 87	return { ...tradeToSign, signature: await getTradeSignature(tradeToSign) }	×
88	}

decentraland / marketplace / 9841305318

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous