9809380648

Committed 05 Jul 2024 01:51PM UTC coverage: 63.374% (+0.08%) from 63.297%

Build # 9809380648

Build Type

push

github

Committed by

web-flow

Commit Message

fix(state): allow to skip parameter validator provider (#6452)

Run Details

23 of 25 new or added lines in 9 files covered. (92.0%)

717 existing lines in 31 files now uncovered.

11143 of 17583 relevant lines covered (63.37%)

52.79 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.44

/src/Symfony/Security/State/AccessCheckerProvider.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\Security\State;

use ApiPlatform\Exception\RuntimeException;
use ApiPlatform\Metadata\GraphQl\Operation as GraphQlOperation;
use ApiPlatform\Metadata\GraphQl\QueryCollection;
use ApiPlatform\Metadata\HttpOperation;
use ApiPlatform\Metadata\Operation;
use ApiPlatform\State\ProviderInterface;
use ApiPlatform\Symfony\Security\Exception\AccessDeniedException;
use ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;

/**
 * Allows access based on the ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface.
 * This implementation covers GraphQl and HTTP.
 *
 * @see ResourceAccessCheckerInterface
 */
final class AccessCheckerProvider implements ProviderInterface
{
    public function __construct(private readonly ProviderInterface $decorated, private readonly ResourceAccessCheckerInterface $resourceAccessChecker, private readonly ?string $event = null)
    {
    }

    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
    {
        switch ($this->event) {
            case 'post_denormalize':
                $isGranted = $operation->getSecurityPostDenormalize();
                $message = $operation->getSecurityPostDenormalizeMessage();
                break;
            case 'post_validate':
                $isGranted = $operation->getSecurityPostValidation();
                $message = $operation->getSecurityPostValidationMessage();
                break;
            case 'after_resolver':
                if (!$operation instanceof GraphQlOperation) {
                    throw new RuntimeException('Not a graphql operation');
                }

                $isGranted = $operation->getSecurityAfterResolver();
                $message = $operation->getSecurityMessageAfterResolver();
                // no break
            default:
                $isGranted = $operation->getSecurity();
                $message = $operation->getSecurityMessage();
        }

        $body = $this->decorated->provide($operation, $uriVariables, $context);
        if (null === $isGranted) {
            return $body;
        }

        // On a GraphQl QueryCollection we want to perform security stage only on the top-level query
        if ($operation instanceof QueryCollection && null !== ($context['source'] ?? null)) {
            return $body;
        }

        if ($operation instanceof HttpOperation) {
            $request = $context['request'] ?? null;

            $resourceAccessCheckerContext = [
                'object' => $body,
                'previous_object' => $request?->attributes->get('previous_data'),
                'request' => $request,
            ];
        } else {
            $resourceAccessCheckerContext = [
                'object' => $body,
                'previous_object' => $context['graphql_context']['previous_object'] ?? null,
            ];
        }

        if (!$this->resourceAccessChecker->isGranted($operation->getClass(), $isGranted, $resourceAccessCheckerContext)) {
            $operation instanceof GraphQlOperation ? throw new AccessDeniedHttpException($message ?? 'Access Denied.') : throw new AccessDeniedException($message ?? 'Access Denied.');
        }

        return $body;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\Security\State;
15
16	use ApiPlatform\Exception\RuntimeException;
17	use ApiPlatform\Metadata\GraphQl\Operation as GraphQlOperation;
18	use ApiPlatform\Metadata\GraphQl\QueryCollection;
19	use ApiPlatform\Metadata\HttpOperation;
20	use ApiPlatform\Metadata\Operation;
21	use ApiPlatform\State\ProviderInterface;
22	use ApiPlatform\Symfony\Security\Exception\AccessDeniedException;
23	use ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface;
24	use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
25
26	/**
27	* Allows access based on the ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface.
28	* This implementation covers GraphQl and HTTP.
29	*
30	* @see ResourceAccessCheckerInterface
31	*/
32	final class AccessCheckerProvider implements ProviderInterface
33	{
34	public function __construct(private readonly ProviderInterface $decorated, private readonly ResourceAccessCheckerInterface $resourceAccessChecker, private readonly ?string $event = null)
35	{
36	}	271✔
37
38	public function provide(Operation $operation, array $uriVariables = [], array $context = []): object\|array\|null
39	{
40	switch ($this->event) {	271✔
41	case 'post_denormalize':	271✔
42	$isGranted = $operation->getSecurityPostDenormalize();	255✔
43	$message = $operation->getSecurityPostDenormalizeMessage();	255✔
44	break;	255✔
45	case 'post_validate':	267✔
46	$isGranted = $operation->getSecurityPostValidation();	255✔
47	$message = $operation->getSecurityPostValidationMessage();	255✔
48	break;	255✔
49	case 'after_resolver':	263✔
UNCOV 50	if (!$operation instanceof GraphQlOperation) {	3✔
51	throw new RuntimeException('Not a graphql operation');	×
52	}
53
UNCOV 54	$isGranted = $operation->getSecurityAfterResolver();	3✔
UNCOV 55	$message = $operation->getSecurityMessageAfterResolver();	3✔
56	// no break
57	default:
58	$isGranted = $operation->getSecurity();	263✔
59	$message = $operation->getSecurityMessage();	263✔
60	}
61
62	$body = $this->decorated->provide($operation, $uriVariables, $context);	271✔
63	if (null === $isGranted) {	267✔
64	return $body;	247✔
65	}
66
67	// On a GraphQl QueryCollection we want to perform security stage only on the top-level query
68	if ($operation instanceof QueryCollection && null !== ($context['source'] ?? null)) {	36✔
69	return $body;	×
70	}
71
72	if ($operation instanceof HttpOperation) {	36✔
73	$request = $context['request'] ?? null;	32✔
74
75	$resourceAccessCheckerContext = [	32✔
76	'object' => $body,	32✔
77	'previous_object' => $request?->attributes->get('previous_data'),	32✔
78	'request' => $request,	32✔
79	];	32✔
80	} else {
81	$resourceAccessCheckerContext = [	4✔
82	'object' => $body,	4✔
83	'previous_object' => $context['graphql_context']['previous_object'] ?? null,	4✔
84	];	4✔
85	}
86
87	if (!$this->resourceAccessChecker->isGranted($operation->getClass(), $isGranted, $resourceAccessCheckerContext)) {	36✔
88	$operation instanceof GraphQlOperation ? throw new AccessDeniedHttpException($message ?? 'Access Denied.') : throw new AccessDeniedException($message ?? 'Access Denied.');	8✔
89	}
90
91	return $body;	28✔
92	}
93	}

api-platform / core / 9809380648

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous