9796587375

Committed 04 Jul 2024 03:05PM UTC coverage: 48.331% (-0.2%) from 48.517%

Build # 9796587375

Build Type

Pull #1698

github

Committed by

hectorgomezv

Commit Message

Add AppData filtering for TWAP order parts

Pull Request Pull Request #1698: Filter out TWAP orders from not allowed apps

Run Details

414 of 2568 branches covered (16.12%)

Branch coverage included in aggregate %.

7 of 20 new or added lines in 3 files covered. (35.0%)

70 existing lines in 7 files now uncovered.

4219 of 7018 relevant lines covered (60.12%)

13.11 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

21.74

/src/domain/accounts/accounts.repository.ts

import { IAccountsRepository } from '@/domain/accounts/accounts.repository.interface';
import { AccountDataType } from '@/domain/accounts/entities/account-data-type.entity';
import {
  Account,
  AccountSchema,
} from '@/domain/accounts/entities/account.entity';
import {
  AuthPayload,
  AuthPayloadDto,
} from '@/domain/auth/entities/auth-payload.entity';
import { IAccountsDatasource } from '@/domain/interfaces/accounts.datasource.interface';
import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';

@Injectable()
export class AccountsRepository implements IAccountsRepository {
  constructor(
    @Inject(IAccountsDatasource)
    private readonly datasource: IAccountsDatasource,
  ) {}

  async createAccount(args: {
    auth: AuthPayloadDto;
    address: `0x${string}`;
  }): Promise<Account> {
    const { auth, address } = args;
    this.checkAuth(auth, address);
    const account = await this.datasource.createAccount(address);
    return AccountSchema.parse(account);
  }

  async getAccount(args: {
    auth: AuthPayloadDto;
    address: `0x${string}`;
  }): Promise<Account> {
    const { auth, address } = args;
    this.checkAuth(auth, address);
    const account = await this.datasource.getAccount(address);
    return AccountSchema.parse(account);
  }

  async deleteAccount(args: {
    auth: AuthPayloadDto;
    address: `0x${string}`;
  }): Promise<void> {
    const { auth, address } = args;
    this.checkAuth(auth, address);
    // TODO: trigger a cascade deletion of the account-associated data.
    return this.datasource.deleteAccount(address);
  }

  async getDataTypes(): Promise<AccountDataType[]> {
    // TODO: add caching with clearing mechanism.
    return this.datasource.getDataTypes();
  }

  private checkAuth(auth: AuthPayloadDto, address: `0x${string}`): void {
    const authPayload = new AuthPayload(auth);
    if (!authPayload.isForSigner(address)) {
      throw new UnauthorizedException();
    }
  }
}

1	import { IAccountsRepository } from '@/domain/accounts/accounts.repository.interface';
2	import { AccountDataType } from '@/domain/accounts/entities/account-data-type.entity';
3	import {	16✔
4	Account,
5	AccountSchema,
6	} from '@/domain/accounts/entities/account.entity';
7	import {	16✔
8	AuthPayload,
9	AuthPayloadDto,
10	} from '@/domain/auth/entities/auth-payload.entity';
11	import { IAccountsDatasource } from '@/domain/interfaces/accounts.datasource.interface';	16✔
12	import { Inject, Injectable, UnauthorizedException } from '@nestjs/common';	16✔
13
14	@Injectable()
15	export class AccountsRepository implements IAccountsRepository {	16✔
16	constructor(
17	@Inject(IAccountsDatasource)
UNCOV 18	private readonly datasource: IAccountsDatasource,	×
19	) {}
20
21	async createAccount(args: {
22	auth: AuthPayloadDto;
23	address: `0x${string}`;
24	}): Promise<Account> {
25	const { auth, address } = args;	×
26	this.checkAuth(auth, address);	×
UNCOV 27	const account = await this.datasource.createAccount(address);	×
UNCOV 28	return AccountSchema.parse(account);	×
29	}
30
31	async getAccount(args: {
32	auth: AuthPayloadDto;
33	address: `0x${string}`;
34	}): Promise<Account> {
UNCOV 35	const { auth, address } = args;	×
36	this.checkAuth(auth, address);	×
37	const account = await this.datasource.getAccount(address);	×
UNCOV 38	return AccountSchema.parse(account);	×
39	}
40
41	async deleteAccount(args: {
42	auth: AuthPayloadDto;
43	address: `0x${string}`;
44	}): Promise<void> {
45	const { auth, address } = args;	×
UNCOV 46	this.checkAuth(auth, address);	×
47	// TODO: trigger a cascade deletion of the account-associated data.
48	return this.datasource.deleteAccount(address);	×
49	}
50
51	async getDataTypes(): Promise<AccountDataType[]> {
52	// TODO: add caching with clearing mechanism.
53	return this.datasource.getDataTypes();	×
54	}
55
56	private checkAuth(auth: AuthPayloadDto, address: `0x${string}`): void {
UNCOV 57	const authPayload = new AuthPayload(auth);	×
UNCOV 58	if (!authPayload.isForSigner(address)) {	×
UNCOV 59	throw new UnauthorizedException();	×
60	}
61	}
62	}

safe-global / safe-client-gateway / 9796587375

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous