9791693583

Committed 04 Jul 2024 09:14AM UTC coverage: 89.747% (-0.007%) from 89.754%

Build # 9791693583

Build Type

push

github

Committed by

AnthonyGlt

Commit Message

fix(PointCloud): fix after pr feedback

Run Details

2823 of 3721 branches covered (75.87%)

Branch coverage included in aggregate %.

2 of 6 new or added lines in 3 files covered. (33.33%)

8 existing lines in 3 files now uncovered.

24617 of 26854 relevant lines covered (91.67%)

904.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.45

/src/Layer/ReferencingLayerProperties.js


// next step is move these properties to Style class
// and hide transparent mechanism
function ReferLayerProperties(material, layer) {
    if (layer && layer.isGeometryLayer) {
        let transparent = material.transparent;
        material.layer = layer;

        if (material.uniforms && material.uniforms.opacity != undefined) {
            Object.defineProperty(material.uniforms.opacity, 'value', {
                get: () => material.layer.opacity,
            });
        } else if (material.opacity != undefined) {
            Object.defineProperty(material, 'opacity', {
                get: () => material.layer.opacity,
            });
        }

        if (material.uniforms && material.uniforms.mode != undefined) {
            Object.defineProperty(material.uniforms.mode, 'value', {
                get: () => material.layer.pntsMode,
            });
        }

        if (material.uniforms && material.uniforms.shape != undefined) {
            Object.defineProperty(material.uniforms.shape, 'value', {
                get: () => material.layer.pntsShape,
            });
        }

        if (material.uniforms && material.uniforms.sizeMode != undefined) {
            Object.defineProperty(material.uniforms.sizeMode, 'value', {
                get: () => material.layer.pntsSizeMode,
            });
        }

        if (material.uniforms && material.uniforms.minAttenuatedSize != undefined) {
            Object.defineProperty(material.uniforms.minAttenuatedSize, 'value', {
                get: () => material.layer.pntsMinAttenuatedSize,
            });
        }

        if (material.uniforms && material.uniforms.maxAttenuatedSize != undefined) {
            Object.defineProperty(material.uniforms.maxAttenuatedSize, 'value', {
                get: () => material.layer.pntsMaxAttenuatedSize,
            });
        }

        if (material.uniforms && material.uniforms.scale != undefined) {
            Object.defineProperty(material.uniforms.scale, 'value', {
                get: () => material.layer.scale,
            });
        }

        Object.defineProperty(material, 'wireframe', {
            get: () => material.layer.wireframe,
        });

        Object.defineProperty(material, 'transparent', {
            get: () => {
                const needTransparency = material.userData.needTransparency?.[material.mode] || material.layer.opacity < 1.0;
                if (transparent != needTransparency) {
                    material.needsUpdate = true;
                    transparent = needTransparency;
                }
                return transparent;
            },
        });
    }

    return material;
}

export default ReferLayerProperties;

1		1✔
2	// next step is move these properties to Style class	1✔
3	// and hide transparent mechanism	1✔
4	function ReferLayerProperties(material, layer) {	104✔
5	if (layer && layer.isGeometryLayer) {	104✔
6	let transparent = material.transparent;	92✔
7	material.layer = layer;	92✔
8		92✔
9	if (material.uniforms && material.uniforms.opacity != undefined) {	92✔
10	Object.defineProperty(material.uniforms.opacity, 'value', {	60✔
11	get: () => material.layer.opacity,	92✔
12	});	32✔
13	} else if (material.opacity != undefined) {	32✔
14	Object.defineProperty(material, 'opacity', {	32✔
15	get: () => material.layer.opacity,	92✔
16	});	60✔
17	}	92✔
18		92✔
19	if (material.uniforms && material.uniforms.mode != undefined) {	×
20	Object.defineProperty(material.uniforms.mode, 'value', {	92✔
21	get: () => material.layer.pntsMode,	92!
22	});	×
23	}	×
24		×
25	if (material.uniforms && material.uniforms.shape != undefined) {	×
26	Object.defineProperty(material.uniforms.shape, 'value', {	92✔
27	get: () => material.layer.pntsShape,	92!
28	});	×
29	}	×
30		×
31	if (material.uniforms && material.uniforms.sizeMode != undefined) {	92✔
32	Object.defineProperty(material.uniforms.sizeMode, 'value', {	92✔
33	get: () => material.layer.pntsSizeMode,	92!
34	});	×
35	}	×
36		×
37	if (material.uniforms && material.uniforms.minAttenuatedSize != undefined) {	92✔
38	Object.defineProperty(material.uniforms.minAttenuatedSize, 'value', {	92!
39	get: () => material.layer.pntsMinAttenuatedSize,	×
40	});	×
41	}	×
42		×
43	if (material.uniforms && material.uniforms.maxAttenuatedSize != undefined) {	92✔
44	Object.defineProperty(material.uniforms.maxAttenuatedSize, 'value', {	92!
45	get: () => material.layer.pntsMaxAttenuatedSize,	92✔
46	});	92✔
47	}	92✔
48		92✔
49	if (material.uniforms && material.uniforms.scale != undefined) {	92✔
50	Object.defineProperty(material.uniforms.scale, 'value', {	92✔
51	get: () => material.layer.scale,	3✔
52	});	3✔
53	}	3!
54		×
55	Object.defineProperty(material, 'wireframe', {	3✔
56	get: () => material.layer.wireframe,	3!
UNCOV 57	});	×
UNCOV 58		×
UNCOV 59	Object.defineProperty(material, 'transparent', {	×
60	get: () => {	3✔
61	const needTransparency = material.userData.needTransparency?.[material.mode] \|\| material.layer.opacity < 1.0;	1✔
62	if (transparent != needTransparency) {	1✔
63	material.needsUpdate = true;	1✔
64	transparent = needTransparency;	1✔
65	}	1✔
66	return transparent;	1✔
67	},	1✔
68	});	1✔
69	}	1✔
70		1✔
71	return material;	1✔
72	}	1✔
73		1✔
74	export default ReferLayerProperties;	1✔

iTowns / itowns / 9791693583

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous