9763017983

Committed 02 Jul 2024 02:37PM UTC coverage: 32.003% (-0.001%) from 32.004%

Build # 9763017983

Build Type

Pull #9473

github

Committed by

oetherington

Commit Message

Add people directory card view for mobile

Pull Request Pull Request #9473: [EA] People directory mobile styles

Run Details

4893 of 39905 branches covered (12.26%)

Branch coverage included in aggregate %.

14 of 27 new or added lines in 4 files covered. (51.85%)

106 existing lines in 8 files now uncovered.

28500 of 64438 relevant lines covered (44.23%)

180.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.98

/packages/lesswrong/components/messaging/NewConversationButton.tsx

import React, { MouseEvent, ReactNode, useCallback, useEffect } from 'react';
import { registerComponent } from '../../lib/vulcan-lib';
import qs from 'qs';
import { useDialog } from '../common/withDialog';
import { useNavigate } from '../../lib/reactRouterWrapper';
import { useInitiateConversation } from '../hooks/useInitiateConversation';
import { userCanStartConversations } from '../../lib/collections/conversations/collection';

export interface TemplateQueryStrings {
  templateId: string;
  displayName: string;
}

// Button used to start a new conversation for a given user
const NewConversationButton = ({
  user,
  currentUser,
  children,
  from,
  includeModerators,
  templateQueries,
  embedConversation,
  openInNewTab,
}: {
  user: {
    _id: string
  },
  currentUser: UsersCurrent|null,
  templateQueries?: TemplateQueryStrings,
  from?: string,
  children: ReactNode,
  includeModerators?: boolean,
  embedConversation?: (conversationId: string, templateQueries?: TemplateQueryStrings) => void
  openInNewTab?: boolean,
}) => {
  const navigate = useNavigate();
  const { openDialog } = useDialog()
  const { conversation, initiateConversation } = useInitiateConversation({ includeModerators })

  const getTemplateParams = useCallback(() => {
    let templateParams: Array<string> = []
    if (templateQueries) {
      templateParams.push(qs.stringify(templateQueries))
    }
    if (from) {
      templateParams.push(`from=${from}`)
    }
    return templateParams.length > 0 ? {search:`?${templateParams.join('&')}`} : {}
  }, [from, templateQueries])

  // Navigate to the conversation that is created
  useEffect(() => {
    if (!conversation) return;

    if (embedConversation) {
      embedConversation(conversation._id, templateQueries)
    } else {
      const templateParams = getTemplateParams()
      navigate({pathname: `/inbox/${conversation._id}`, ...templateParams}, {
        openInNewTab,
      });
    }
  }, [conversation, embedConversation, getTemplateParams, navigate, templateQueries, openInNewTab])

  const handleClick = currentUser
    ? (e: MouseEvent) => {
      initiateConversation([user._id])
      e.stopPropagation()
    }
    : () => openDialog({componentName: "LoginPopup"})

  if (currentUser && !userCanStartConversations(currentUser)) return null

  // in this case we show the button, but we don't actually let them create a conversation with themselves
  if (currentUser?._id === user._id)
    return <div>
      {children}
    </div>

  return (
    <div onClick={handleClick}>
      {children}
    </div>
  )
}

const NewConversationButtonComponent = registerComponent('NewConversationButton', NewConversationButton);

declare global {
  interface ComponentTypes {
    NewConversationButton: typeof NewConversationButtonComponent
  }
}

1	import React, { MouseEvent, ReactNode, useCallback, useEffect } from 'react';	2✔
2	import { registerComponent } from '../../lib/vulcan-lib';	1✔
3	import qs from 'qs';	1✔
4	import { useDialog } from '../common/withDialog';	1✔
5	import { useNavigate } from '../../lib/reactRouterWrapper';	1✔
6	import { useInitiateConversation } from '../hooks/useInitiateConversation';	1✔
7	import { userCanStartConversations } from '../../lib/collections/conversations/collection';	1✔
8
9	export interface TemplateQueryStrings {
10	templateId: string;
11	displayName: string;
12	}
13
14	// Button used to start a new conversation for a given user
15	const NewConversationButton = ({	1✔
16	user,
17	currentUser,
18	children,
19	from,
20	includeModerators,
21	templateQueries,
22	embedConversation,
23	openInNewTab,
24	}: {
25	user: {
26	_id: string
27	},
28	currentUser: UsersCurrent\|null,
29	templateQueries?: TemplateQueryStrings,
30	from?: string,
31	children: ReactNode,
32	includeModerators?: boolean,
33	embedConversation?: (conversationId: string, templateQueries?: TemplateQueryStrings) => void
34	openInNewTab?: boolean,
35	}) => {
36	const navigate = useNavigate();	×
37	const { openDialog } = useDialog()	×
38	const { conversation, initiateConversation } = useInitiateConversation({ includeModerators })	×
39
40	const getTemplateParams = useCallback(() => {	×
41	let templateParams: Array<string> = []	×
42	if (templateQueries) {	×
43	templateParams.push(qs.stringify(templateQueries))	×
44	}
45	if (from) {	×
46	templateParams.push(`from=${from}`)	×
47	}
48	return templateParams.length > 0 ? {search:`?${templateParams.join('&')}`} : {}	×
49	}, [from, templateQueries])
50
51	// Navigate to the conversation that is created
52	useEffect(() => {	×
53	if (!conversation) return;	×
54
55	if (embedConversation) {	×
56	embedConversation(conversation._id, templateQueries)	×
57	} else {
58	const templateParams = getTemplateParams()	×
NEW 59	navigate({pathname: `/inbox/${conversation._id}`, ...templateParams}, {	×
60	openInNewTab,
61	});
62	}
63	}, [conversation, embedConversation, getTemplateParams, navigate, templateQueries, openInNewTab])
64
65	const handleClick = currentUser	×
66	? (e: MouseEvent) => {	×
67	initiateConversation([user._id])	×
68	e.stopPropagation()	×
69	}
70	: () => openDialog({componentName: "LoginPopup"})	×
71
72	if (currentUser && !userCanStartConversations(currentUser)) return null	×
73
74	// in this case we show the button, but we don't actually let them create a conversation with themselves
75	if (currentUser?._id === user._id)	×
76	return <div>	×
77	{children}
78	</div>
79
80	return (	×
81	<div onClick={handleClick}>
82	{children}
83	</div>
84	)
85	}
86
87	const NewConversationButtonComponent = registerComponent('NewConversationButton', NewConversationButton);	1✔
88
89	declare global {
90	interface ComponentTypes {
91	NewConversationButton: typeof NewConversationButtonComponent
92	}
93	}

ForumMagnum / ForumMagnum / 9763017983

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous