9760154529

Committed 02 Jul 2024 11:31AM UTC coverage: 31.859% (-0.1%) from 32.001%

Build # 9760154529

Build Type

Pull #9446

github

Committed by

Will-Howard

Commit Message

address comments

Pull Request Pull Request #9446: [EA] Port the twitter bot into the forum codebase

Run Details

4838 of 39590 branches covered (12.22%)

Branch coverage included in aggregate %.

43 of 97 new or added lines in 7 files covered. (44.33%)

406 existing lines in 17 files now uncovered.

28152 of 63961 relevant lines covered (44.01%)

179.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

53.85

/packages/lesswrong/server/repos/TweetsRepo.ts

import AbstractRepo from "./AbstractRepo";
import Tweets from "../../lib/collections/tweets/collection";
import { recordPerfMetrics } from "./perfMetricWrapper";
import { getViewablePostsSelector } from "./helpers";

class TweetsRepo extends AbstractRepo<"Tweets"> {
  constructor() {
    super(Tweets);
  }

  /**
   * @returns {string[]} The ids of posts that have crossed `threshold` karma since `since`
   */
  async getUntweetedPostsCrossingKarmaThreshold({threshold, since}: {threshold: number, since: Date}): Promise<string[]> {
    const res = await this.getRawDb().any<{postId: string}>(`
      -- TweetsRepo.getPostsCrossingKarmaThreshold
      WITH KarmaChanges AS (
        SELECT
          *,
          prior_karma + power AS post_karma
        FROM (
          SELECT
            v."votedAt",
            v."documentId" AS post_id,
            v.power,
            (
              SELECT
                sum(v1.power) AS karma
              FROM
                "Votes" v1
              WHERE
                v1."documentId" = v."documentId"
                AND v1.cancelled IS FALSE
                AND v1."votedAt" < v."votedAt"
              GROUP BY
                v1."documentId") AS prior_karma
          FROM
            "Votes" v
            INNER JOIN "Posts" p ON p._id = v."documentId"
            LEFT JOIN "Tweets" t ON t."postId" = p._id
          WHERE
            "collectionName" = 'Posts'
            AND cancelled = FALSE
            AND "votedAt" > $2
            AND ${getViewablePostsSelector("p")}
            AND t._id IS NULL
          ORDER BY
            "votedAt" DESC) q
      )
      SELECT
        post_id AS "postId"
      FROM
        KarmaChanges
      WHERE
        prior_karma < $1
        AND post_karma >= $1;
    `, [threshold, since]);

    return res?.map(r => r.postId) ?? []
  }
}

recordPerfMetrics(TweetsRepo);

export default TweetsRepo;

1	import AbstractRepo from "./AbstractRepo";	1,715✔
2	import Tweets from "../../lib/collections/tweets/collection";	20✔
3	import { recordPerfMetrics } from "./perfMetricWrapper";	20✔
4	import { getViewablePostsSelector } from "./helpers";	20✔
5
6	class TweetsRepo extends AbstractRepo<"Tweets"> {
7	constructor() {
8	super(Tweets);	1,655✔
9	}
10
11	/**
12	* @returns {string[]} The ids of posts that have crossed `threshold` karma since `since`
13	*/
14	async getUntweetedPostsCrossingKarmaThreshold({threshold, since}: {threshold: number, since: Date}): Promise<string[]> {
NEW 15	const res = await this.getRawDb().any<{postId: string}>(`	×
16	-- TweetsRepo.getPostsCrossingKarmaThreshold
17	WITH KarmaChanges AS (
18	SELECT
19	*,
20	prior_karma + power AS post_karma
21	FROM (
22	SELECT
23	v."votedAt",
24	v."documentId" AS post_id,
25	v.power,
26	(
27	SELECT
28	sum(v1.power) AS karma
29	FROM
30	"Votes" v1
31	WHERE
32	v1."documentId" = v."documentId"
33	AND v1.cancelled IS FALSE
34	AND v1."votedAt" < v."votedAt"
35	GROUP BY
36	v1."documentId") AS prior_karma
37	FROM
38	"Votes" v
39	INNER JOIN "Posts" p ON p._id = v."documentId"
40	LEFT JOIN "Tweets" t ON t."postId" = p._id
41	WHERE
42	"collectionName" = 'Posts'
43	AND cancelled = FALSE
44	AND "votedAt" > $2
45	AND ${getViewablePostsSelector("p")}
46	AND t._id IS NULL
47	ORDER BY
48	"votedAt" DESC) q
49	)
50	SELECT
51	post_id AS "postId"
52	FROM
53	KarmaChanges
54	WHERE
55	prior_karma < $1
56	AND post_karma >= $1;
57	`, [threshold, since]);
58
NEW 59	return res?.map(r => r.postId) ?? []	×
60	}
61	}	20✔
62
63	recordPerfMetrics(TweetsRepo);
64
65	export default TweetsRepo;	20✔

ForumMagnum / ForumMagnum / 9760154529

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous