9753823860

Committed 02 Jul 2024 02:05AM UTC coverage: 31.9% (+0.003%) from 31.897%

Build # 9753823860

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9472 from ForumMagnum/master

LW Deploy, 2024-07-07c

Run Details

4899 of 40120 branches covered (12.21%)

Branch coverage included in aggregate %.

22 of 45 new or added lines in 6 files covered. (48.89%)

2 existing lines in 2 files now uncovered.

28526 of 64660 relevant lines covered (44.12%)

180.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

37.93

/packages/lesswrong/components/dropdowns/posts/PostActions.tsx

import React from 'react';
import { registerComponent, Components } from '../../../lib/vulcan-lib';
import { useCurrentUser } from '../../common/withUser';
import { isBookUI, isFriendlyUI } from '../../../themes/forumTheme';
import { hasCuratedPostsSetting } from '../../../lib/instanceSettings';

// We use a context here vs. passing in a boolean prop because we'd need to pass
// through ~4 layers of hierarchy
export const AllowHidingFrontPagePostsContext = React.createContext<boolean>(false);

// Same as above context provider but for whether a post is being served as a recommendation
export const IsRecommendationContext = React.createContext<boolean>(false);

const styles = (_theme: ThemeType): JssStyles => ({
  root: {
    minWidth: isFriendlyUI ? undefined : 300,
    maxWidth: "calc(100vw - 100px)",
  },
})

const PostActions = ({post, closeMenu, includeBookmark=true, classes}: {
  post: PostsList|SunshinePostsList,
  closeMenu: () => void,
  includeBookmark?: boolean,
  classes: ClassesType,
}) => {
  const currentUser = useCurrentUser();

  const {
    MoveToDraftDropdownItem, BookmarkDropdownItem, SuggestCuratedDropdownItem,
    SuggestAlignmentPostDropdownItem, ReportPostDropdownItem, DeleteDraftDropdownItem,
    HideFrontpagePostDropdownItem, SetSideCommentVisibility, ResyncRssDropdownItem,
    MarkAsReadDropdownItem, SummarizeDropdownItem, MoveToFrontpageDropdownItem,
    MoveToAlignmentPostDropdownItem, ShortformDropdownItem, DropdownMenu,
    EditTagsDropdownItem, EditPostDropdownItem, DuplicateEventDropdownItem,
    PostAnalyticsDropdownItem, ExcludeFromRecommendationsDropdownItem,
    ApproveNewUserDropdownItem, SharePostSubmenu, PostSubscriptionsDropdownItem,
    DislikeRecommendationDropdownItem
  } = Components;

  if (!post) return null;

  // WARNING: Clickable items in this menu must be full-width, and
  // ideally should use the <DropdownItem> component. In particular,
  // do NOT wrap a <MenuItem> around something that has its own
  // onClick handler; the onClick handler should either be on the
  // MenuItem, or on something outside of it. Putting an onClick
  // on an element inside of a MenuItem can create a dead-space
  // click area to the right of the item which looks like you've
  // selected the thing, and closes the menu, but doesn't do the
  // thing.

  return (
    <DropdownMenu className={classes.root} >
      <EditPostDropdownItem post={post} />
      <ResyncRssDropdownItem post={post} closeMenu={closeMenu} />
      {isBookUI && <SharePostSubmenu post={post} closeMenu={closeMenu} />}
      <DuplicateEventDropdownItem post={post} />
      <PostAnalyticsDropdownItem post={post} />
      <PostSubscriptionsDropdownItem post={post} />
      {includeBookmark && <BookmarkDropdownItem post={post} />}
      <SetSideCommentVisibility />
      <HideFrontpagePostDropdownItem post={post} />
      <DislikeRecommendationDropdownItem post={post} />
      <ReportPostDropdownItem post={post}/>
      {currentUser && <EditTagsDropdownItem post={post} closeMenu={closeMenu} />}
      <SummarizeDropdownItem post={post} closeMenu={closeMenu} />
      {currentUser && <MarkAsReadDropdownItem post={post} />}
      {hasCuratedPostsSetting.get() && <SuggestCuratedDropdownItem post={post} />}
      <MoveToDraftDropdownItem post={post} />
      <DeleteDraftDropdownItem post={post} />
      <MoveToFrontpageDropdownItem post={post} />
      <ShortformDropdownItem post={post} />
      <ExcludeFromRecommendationsDropdownItem post={post} />
      <ApproveNewUserDropdownItem post={post} />
      <SuggestAlignmentPostDropdownItem post={post}/>
      <MoveToAlignmentPostDropdownItem post={post}/>
    </DropdownMenu>
  );
}

const PostActionsComponent = registerComponent('PostActions', PostActions, {styles});

declare global {
  interface ComponentTypes {
    PostActions: typeof PostActionsComponent
  }
}

1	import React from 'react';	54✔
2	import { registerComponent, Components } from '../../../lib/vulcan-lib';	18✔
3	import { useCurrentUser } from '../../common/withUser';	18✔
4	import { isBookUI, isFriendlyUI } from '../../../themes/forumTheme';	18✔
5	import { hasCuratedPostsSetting } from '../../../lib/instanceSettings';	18✔
6
7	// We use a context here vs. passing in a boolean prop because we'd need to pass
8	// through ~4 layers of hierarchy
9	export const AllowHidingFrontPagePostsContext = React.createContext<boolean>(false);	18✔
10
11	// Same as above context provider but for whether a post is being served as a recommendation
12	export const IsRecommendationContext = React.createContext<boolean>(false);	18✔
13
14	const styles = (_theme: ThemeType): JssStyles => ({	18✔
15	root: {
16	minWidth: isFriendlyUI ? undefined : 300,	1!
17	maxWidth: "calc(100vw - 100px)",
18	},
19	})
20
21	const PostActions = ({post, closeMenu, includeBookmark=true, classes}: {	18!
22	post: PostsList\|SunshinePostsList,
23	closeMenu: () => void,
24	includeBookmark?: boolean,
25	classes: ClassesType,
26	}) => {
27	const currentUser = useCurrentUser();	×
28
29	const {
30	MoveToDraftDropdownItem, BookmarkDropdownItem, SuggestCuratedDropdownItem,
31	SuggestAlignmentPostDropdownItem, ReportPostDropdownItem, DeleteDraftDropdownItem,
32	HideFrontpagePostDropdownItem, SetSideCommentVisibility, ResyncRssDropdownItem,
33	MarkAsReadDropdownItem, SummarizeDropdownItem, MoveToFrontpageDropdownItem,
34	MoveToAlignmentPostDropdownItem, ShortformDropdownItem, DropdownMenu,
35	EditTagsDropdownItem, EditPostDropdownItem, DuplicateEventDropdownItem,
36	PostAnalyticsDropdownItem, ExcludeFromRecommendationsDropdownItem,
37	ApproveNewUserDropdownItem, SharePostSubmenu, PostSubscriptionsDropdownItem,
38	DislikeRecommendationDropdownItem
UNCOV 39	} = Components;	×
40
41	if (!post) return null;	×
42
43	// WARNING: Clickable items in this menu must be full-width, and
44	// ideally should use the <DropdownItem> component. In particular,
45	// do NOT wrap a <MenuItem> around something that has its own
46	// onClick handler; the onClick handler should either be on the
47	// MenuItem, or on something outside of it. Putting an onClick
48	// on an element inside of a MenuItem can create a dead-space
49	// click area to the right of the item which looks like you've
50	// selected the thing, and closes the menu, but doesn't do the
51	// thing.
52
53	return (	×
54	<DropdownMenu className={classes.root} >
55	<EditPostDropdownItem post={post} />
56	<ResyncRssDropdownItem post={post} closeMenu={closeMenu} />
57	{isBookUI && <SharePostSubmenu post={post} closeMenu={closeMenu} />}	×
58	<DuplicateEventDropdownItem post={post} />
59	<PostAnalyticsDropdownItem post={post} />
60	<PostSubscriptionsDropdownItem post={post} />
61	{includeBookmark && <BookmarkDropdownItem post={post} />}	×
62	<SetSideCommentVisibility />
63	<HideFrontpagePostDropdownItem post={post} />
64	<DislikeRecommendationDropdownItem post={post} />
65	<ReportPostDropdownItem post={post}/>
66	{currentUser && <EditTagsDropdownItem post={post} closeMenu={closeMenu} />}	×
67	<SummarizeDropdownItem post={post} closeMenu={closeMenu} />
68	{currentUser && <MarkAsReadDropdownItem post={post} />}	×
69	{hasCuratedPostsSetting.get() && <SuggestCuratedDropdownItem post={post} />}	×
70	<MoveToDraftDropdownItem post={post} />
71	<DeleteDraftDropdownItem post={post} />
72	<MoveToFrontpageDropdownItem post={post} />
73	<ShortformDropdownItem post={post} />
74	<ExcludeFromRecommendationsDropdownItem post={post} />
75	<ApproveNewUserDropdownItem post={post} />
76	<SuggestAlignmentPostDropdownItem post={post}/>
77	<MoveToAlignmentPostDropdownItem post={post}/>
78	</DropdownMenu>
79	);
80	}
81
82	const PostActionsComponent = registerComponent('PostActions', PostActions, {styles});	18✔
83
84	declare global {
85	interface ComponentTypes {
86	PostActions: typeof PostActionsComponent
87	}
88	}

ForumMagnum / ForumMagnum / 9753823860

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous