9733990794

Committed 30 Jun 2024 06:12PM UTC coverage: 31.947% (-0.01%) from 31.959%

Build # 9733990794

Build Type

Pull #9457

github

Committed by

s-cheng

Commit Message

update how points are calculated

Pull Request Pull Request #9457: [EA Forum only] Debate week post page section

Run Details

4885 of 39932 branches covered (12.23%)

Branch coverage included in aggregate %.

26 of 72 new or added lines in 6 files covered. (36.11%)

5 existing lines in 3 files now uncovered.

28466 of 64462 relevant lines covered (44.16%)

180.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

10.53

/packages/lesswrong/server/resolvers/forumEventResolvers.ts

import { captureEvent } from '@/lib/analyticsEvents';
import { addGraphQLMutation, addGraphQLResolvers } from '../vulcan-lib';


addGraphQLResolvers({
  Mutation: {
    AddForumEventVote: async (
      _root: void,
      {forumEventId, x, delta, postIds}: {forumEventId: string, x: number, delta?: number, postIds?: string[]},
      {currentUser, repos}: ResolverContext
    ) => {
      if (!currentUser) {
        throw new Error("Permission denied");
      }
      
      const oldVote = await repos.forumEvents.getUserVote(forumEventId, currentUser._id)
      const voteData = {
        x,
        points: oldVote?.points ?? {}
      }
      // Update the points associated with this vote if there was a change and that change was associated with posts
      if (postIds?.length && !!delta) {
        const pointsPerPost = Math.abs(delta)
        postIds.forEach(postId => {
          // Each post gets points equal to the max change attributed to that post
          voteData.points[postId] = Math.max(pointsPerPost, voteData.points?.[postId] ?? 0)
        })
      }
      repos.forumEvents.addVote(forumEventId, currentUser._id, voteData)
      captureEvent("addForumEventVote", {
        forumEventId,
        userId: currentUser._id,
        x,
        delta,
        postIds
      })
      return true
    },
    RemoveForumEventVote: (_root: void, {forumEventId}: {forumEventId: string}, {currentUser, repos}: ResolverContext) => {
      if (!currentUser) {
        throw new Error("Not logged in");
      }
      repos.forumEvents.removeVote(forumEventId, currentUser._id)
      captureEvent("removeForumEventVote", {
        forumEventId,
        userId: currentUser._id,
      })
      return true
    },
  },
})

addGraphQLMutation('AddForumEventVote(forumEventId: String!, x: Float!, delta: Float, postIds: [String]): Boolean')
addGraphQLMutation('RemoveForumEventVote(forumEventId: String!): Boolean')

1	import { captureEvent } from '@/lib/analyticsEvents';	18✔
2	import { addGraphQLMutation, addGraphQLResolvers } from '../vulcan-lib';	18✔
3
4
5	addGraphQLResolvers({
6	Mutation: {
7	AddForumEventVote: async (
8	_root: void,
9	{forumEventId, x, delta, postIds}: {forumEventId: string, x: number, delta?: number, postIds?: string[]},
10	{currentUser, repos}: ResolverContext
11	) => {
12	if (!currentUser) {	×
13	throw new Error("Permission denied");	×
14	}
15
16	const oldVote = await repos.forumEvents.getUserVote(forumEventId, currentUser._id)	×
17	const voteData = {	×
18	x,
19	points: oldVote?.points ?? {}	×
20	}
21	// Update the points associated with this vote if there was a change and that change was associated with posts
22	if (postIds?.length && !!delta) {	×
23	const pointsPerPost = Math.abs(delta)	×
24	postIds.forEach(postId => {	×
25	// Each post gets points equal to the max change attributed to that post
NEW 26	voteData.points[postId] = Math.max(pointsPerPost, voteData.points?.[postId] ?? 0)	×
27	})
28	}
29	repos.forumEvents.addVote(forumEventId, currentUser._id, voteData)	×
30	captureEvent("addForumEventVote", {	×
31	forumEventId,
32	userId: currentUser._id,
33	x,
34	delta,
35	postIds
36	})
37	return true	×
38	},
39	RemoveForumEventVote: (_root: void, {forumEventId}: {forumEventId: string}, {currentUser, repos}: ResolverContext) => {
40	if (!currentUser) {	×
41	throw new Error("Not logged in");	×
42	}
43	repos.forumEvents.removeVote(forumEventId, currentUser._id)	×
44	captureEvent("removeForumEventVote", {	×
45	forumEventId,
46	userId: currentUser._id,
47	})
48	return true	×
49	},
50	},
51	})	18✔
52
53	addGraphQLMutation('AddForumEventVote(forumEventId: String!, x: Float!, delta: Float, postIds: [String]): Boolean')	18✔
54	addGraphQLMutation('RemoveForumEventVote(forumEventId: String!): Boolean')

ForumMagnum / ForumMagnum / 9733990794

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous