9688550621

Committed 27 Jun 2024 12:18AM UTC coverage: 14.616% (+14.3%) from 0.359%

Build # 9688550621

Build Type

Pull #8210

github

Committed by

web-flow

Commit Message

Merge 9947444df into 4b0cef8c2

Pull Request Pull Request #8210: Fixes for session keys after v0.10 Canvas upgrade

Run Details

3550 of 23082 branches covered (15.38%)

Branch coverage included in aggregate %.

11 of 30 new or added lines in 9 files covered. (36.67%)

52 existing lines in 7 files now uncovered.

4889 of 34657 relevant lines covered (14.11%)

4.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.91

/packages/commonwealth/server/util/verifySessionSignature.ts

import { Session } from '@canvas-js/interfaces';
import assert from 'assert';

import { NotificationCategories } from '@hicommonwealth/shared';
import Sequelize from 'sequelize';
import { getSessionSignerForAddress } from 'shared/canvas/verify';

import {
  type AddressInstance,
  type DB,
  type ProfileAttributes,
} from '@hicommonwealth/model';
import { CANVAS_TOPIC } from '../../shared/canvas';

/**
 * Verify the session signature is valid for the address model,
 * and either create a new user linked to `addressModel`
 * or attach it to an existing `user_id`.
 */
const verifySessionSignature = async (
  models: DB,
  addressModel: AddressInstance,
  user_id: number | undefined | null,
  session: Session,
): Promise<void> => {
  const expectedAddress = addressModel.address;
  const sessionAddress = session.address.split(':')[2];

  assert(
    sessionAddress === expectedAddress,
    `session.address (${sessionAddress}) does not match addressModel.address (${expectedAddress})`,
  );

  const signer = getSessionSignerForAddress(session.address);
  if (!signer) {
    throw new Error('missing signer');
  }

  await signer.verifySession(CANVAS_TOPIC, session);

  addressModel.last_active = new Date();

  if (user_id === null || user_id === undefined) {
    // mark the address as verified, and if it doesn't have an associated user, create a new user
    // @ts-expect-error StrictNullChecks
    addressModel.verification_token_expires = null;
    addressModel.verified = new Date();
    if (!addressModel.user_id) {
      const existingAddress = await models.Address.findOne({
        // @ts-expect-error StrictNullChecks
        where: {
          address: addressModel.address,
          user_id: { [Sequelize.Op.ne]: null },
        },
      });
      if (existingAddress) {
        addressModel.user_id = existingAddress.user_id;
        addressModel.profile_id = existingAddress.profile_id;
      } else {
        const user = await models.User.createWithProfile?.({
          email: null,
        });
        if (!user || !user.id) throw new Error('Failed to create user');
        addressModel.profile_id = (user?.Profiles?.[0] as ProfileAttributes).id;
        await models.Subscription.create({
          subscriber_id: user.id,
          category_id: NotificationCategories.NewMention,
          is_active: true,
        });
        await models.Subscription.create({
          subscriber_id: user.id,
          category_id: NotificationCategories.NewCollaboration,
          is_active: true,
        });
        addressModel.user_id = user?.id;
      }
    }
  } else {
    // mark the address as verified
    // @ts-expect-error StrictNullChecks
    addressModel.verification_token_expires = null;
    addressModel.verified = new Date();
    addressModel.user_id = user_id;
    const profile = await models.Profile.findOne({ where: { user_id } });
    addressModel.profile_id = profile?.id;
  }
  await addressModel.save();
};

export default verifySessionSignature;

1	import { Session } from '@canvas-js/interfaces';
2	import assert from 'assert';
3
4	import { NotificationCategories } from '@hicommonwealth/shared';
5	import Sequelize from 'sequelize';
6	import { getSessionSignerForAddress } from 'shared/canvas/verify';
7
8	import {
9	type AddressInstance,
10	type DB,
11	type ProfileAttributes,
12	} from '@hicommonwealth/model';
13	import { CANVAS_TOPIC } from '../../shared/canvas';
14
15	/**
16	* Verify the session signature is valid for the address model,
17	* and either create a new user linked to `addressModel`
18	* or attach it to an existing `user_id`.
19	*/
20	const verifySessionSignature = async (	22✔
21	models: DB,
22	addressModel: AddressInstance,
23	user_id: number \| undefined \| null,
24	session: Session,
25	): Promise<void> => {
26	const expectedAddress = addressModel.address;	54✔
27	const sessionAddress = session.address.split(':')[2];	54✔
28
29	assert(	54✔
30	sessionAddress === expectedAddress,
31	`session.address (${sessionAddress}) does not match addressModel.address (${expectedAddress})`,
32	);
33
34	const signer = getSessionSignerForAddress(session.address);	54✔
35	if (!signer) {	54!
NEW 36	throw new Error('missing signer');	×
37	}
38
39	await signer.verifySession(CANVAS_TOPIC, session);	54✔
40
41	addressModel.last_active = new Date();	54✔
42
43	if (user_id === null \|\| user_id === undefined) {	54!
44	// mark the address as verified, and if it doesn't have an associated user, create a new user
45	// @ts-expect-error StrictNullChecks
46	addressModel.verification_token_expires = null;	54✔
47	addressModel.verified = new Date();	54✔
48	if (!addressModel.user_id) {	54!
49	const existingAddress = await models.Address.findOne({	54✔
50	// @ts-expect-error StrictNullChecks
51	where: {
52	address: addressModel.address,
53	user_id: { [Sequelize.Op.ne]: null },
54	},
55	});
56	if (existingAddress) {	54!
57	addressModel.user_id = existingAddress.user_id;	×
58	addressModel.profile_id = existingAddress.profile_id;	×
59	} else {
60	const user = await models.User.createWithProfile?.({	54✔
61	email: null,
62	});
63	if (!user \|\| !user.id) throw new Error('Failed to create user');	54!
64	addressModel.profile_id = (user?.Profiles?.[0] as ProfileAttributes).id;	54✔
65	await models.Subscription.create({	54✔
66	subscriber_id: user.id,
67	category_id: NotificationCategories.NewMention,
68	is_active: true,
69	});
70	await models.Subscription.create({	54✔
71	subscriber_id: user.id,
72	category_id: NotificationCategories.NewCollaboration,
73	is_active: true,
74	});
75	addressModel.user_id = user?.id;	54✔
76	}
77	}
78	} else {
79	// mark the address as verified
80	// @ts-expect-error StrictNullChecks
81	addressModel.verification_token_expires = null;	×
82	addressModel.verified = new Date();	×
83	addressModel.user_id = user_id;	×
84	const profile = await models.Profile.findOne({ where: { user_id } });	×
NEW 85	addressModel.profile_id = profile?.id;	×
86	}
87	await addressModel.save();	54✔
88	};
89
90	export default verifySessionSignature;

hicommonwealth / commonwealth / 9688550621

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous