9688487489

Committed 27 Jun 2024 12:12AM UTC coverage: 14.609% (+14.3%) from 0.359%

Build # 9688487489

Build Type

Pull #8210

github

Committed by

web-flow

Commit Message

Merge 270b7c85b into 4b0cef8c2

Pull Request Pull Request #8210: Fixes for session keys after v0.10 Canvas upgrade

Run Details

3544 of 23074 branches covered (15.36%)

Branch coverage included in aggregate %.

10 of 29 new or added lines in 9 files covered. (34.48%)

70 existing lines in 9 files now uncovered.

4890 of 34658 relevant lines covered (14.11%)

4.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

7.69

/packages/commonwealth/server/routes/viewComments.ts

import { AppError } from '@hicommonwealth/core';
import type { DB } from '@hicommonwealth/model';
import type { NextFunction, Request, Response } from 'express';
import { getLastEdited } from 'server/util/getLastEdited';
import { sanitizeDeletedComment } from 'server/util/sanitizeDeletedComment';

export const Errors = {
  NoRootId: 'Must provide thread_id',
  InvalidId: 'Invalid thread_id',
};

const viewComments = async (
  models: DB,
  req: Request,
  res: Response,
  next: NextFunction,
) => {
  const { community } = req;
  const threadId = req.query.thread_id as string;

  if (!threadId) {
    return next(new AppError(Errors.NoRootId));
  }

  const parsedInt = parseInt(threadId, 10);
  if (isNaN(parsedInt) || parsedInt !== parseFloat(threadId)) {
    return next(new AppError(Errors.InvalidId));
  }

  const comments = await models.Comment.findAll({
    // @ts-expect-error StrictNullChecks
    where: { community_id: community.id, thread_id: threadId },
    include: [
      {
        model: models.Address,
        include: [
          {
            model: models.User,
            as: 'User',
            required: true,
            attributes: ['id'],
            include: [
              {
                model: models.Profile,
                as: 'Profiles',
                required: true,
                attributes: ['id', 'avatar_url', 'profile_name'],
              },
            ],
          },
        ],
      },
      {
        model: models.Reaction,
        as: 'reactions',
        include: [
          {
            model: models.Address,
            as: 'Address',
            required: true,
            attributes: ['address', 'last_active'],
            include: [
              {
                model: models.User,
                as: 'User',
                required: true,
                attributes: ['id'],
                include: [
                  {
                    model: models.Profile,
                    as: 'Profiles',
                    required: true,
                    attributes: ['id', 'avatar_url', 'profile_name'],
                  },
                ],
              },
            ],
          },
        ],
      },
    ],
    order: [['created_at', 'DESC']],
    paranoid: false,
  });

  const sanitizedComments = comments.map((c) => {
    const data = c.toJSON();
    return {
      ...sanitizeDeletedComment(data),
      last_edited: getLastEdited(data),
    };
  });

  return res.json({
    status: 'Success',
    result: sanitizedComments,
  });
};

export default viewComments;

1	import { AppError } from '@hicommonwealth/core';
2	import type { DB } from '@hicommonwealth/model';
3	import type { NextFunction, Request, Response } from 'express';
4	import { getLastEdited } from 'server/util/getLastEdited';
5	import { sanitizeDeletedComment } from 'server/util/sanitizeDeletedComment';
6
7	export const Errors = {	22✔
8	NoRootId: 'Must provide thread_id',
9	InvalidId: 'Invalid thread_id',
10	};
11
12	const viewComments = async (	22✔
13	models: DB,
14	req: Request,
15	res: Response,
16	next: NextFunction,
17	) => {
18	const { community } = req;	×
UNCOV 19	const threadId = req.query.thread_id as string;	×
20
21	if (!threadId) {	×
UNCOV 22	return next(new AppError(Errors.NoRootId));	×
23	}
24
UNCOV 25	const parsedInt = parseInt(threadId, 10);	×
UNCOV 26	if (isNaN(parsedInt) \|\| parsedInt !== parseFloat(threadId)) {	×
UNCOV 27	return next(new AppError(Errors.InvalidId));	×
28	}
29
UNCOV 30	const comments = await models.Comment.findAll({	×
31	// @ts-expect-error StrictNullChecks
32	where: { community_id: community.id, thread_id: threadId },
33	include: [
34	{
35	model: models.Address,
36	include: [
37	{
38	model: models.User,
39	as: 'User',
40	required: true,
41	attributes: ['id'],
42	include: [
43	{
44	model: models.Profile,
45	as: 'Profiles',
46	required: true,
47	attributes: ['id', 'avatar_url', 'profile_name'],
48	},
49	],
50	},
51	],
52	},
53	{
54	model: models.Reaction,
55	as: 'reactions',
56	include: [
57	{
58	model: models.Address,
59	as: 'Address',
60	required: true,
61	attributes: ['address', 'last_active'],
62	include: [
63	{
64	model: models.User,
65	as: 'User',
66	required: true,
67	attributes: ['id'],
68	include: [
69	{
70	model: models.Profile,
71	as: 'Profiles',
72	required: true,
73	attributes: ['id', 'avatar_url', 'profile_name'],
74	},
75	],
76	},
77	],
78	},
79	],
80	},
81	],
82	order: [['created_at', 'DESC']],
83	paranoid: false,
84	});
85
UNCOV 86	const sanitizedComments = comments.map((c) => {	×
UNCOV 87	const data = c.toJSON();	×
88	return {	×
89	...sanitizeDeletedComment(data),
90	last_edited: getLastEdited(data),
91	};
92	});
93
UNCOV 94	return res.json({	×
95	status: 'Success',
96	result: sanitizedComments,
97	});
98	};
99
100	export default viewComments;

hicommonwealth / commonwealth / 9688487489

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous