9645834835

Committed 24 Jun 2024 01:02PM UTC coverage: 14.86% (+2.0%) from 12.845%

Build # 9645834835

Build Type

Pull #8041

github

Committed by

web-flow

Commit Message

Merge b8cb3f7ae into 3dc674aab

Pull Request Pull Request #8041: Refactor version history (PART 1/2)

Run Details

3724 of 26795 branches covered (13.9%)

Branch coverage included in aggregate %.

7 of 76 new or added lines in 9 files covered. (9.21%)

240 existing lines in 40 files now uncovered.

5159 of 32982 relevant lines covered (15.64%)

5.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.78

/packages/commonwealth/server/routes/comments/create_comment_reaction_handler.ts

import { AppError } from '@hicommonwealth/core';
import { ReactionAttributes } from '@hicommonwealth/model';
import { verifyReaction } from '../../../shared/canvas/serverVerify';
import { config } from '../../config';
import { ServerControllers } from '../../routing/router';
import { TypedRequest, TypedResponse, success } from '../../types';

const Errors = {
  InvalidReaction: 'Invalid reaction',
  InvalidCommentId: 'Invalid comment ID',
};

type CreateCommentReactionRequestParams = { id: string };
type CreateCommentReactionRequestBody = {
  reaction: string;
  canvas_action?: any;
  canvas_session?: any;
  canvas_hash?: any;
};
type CreateCommentReactionResponse = ReactionAttributes;

export const createCommentReactionHandler = async (
  controllers: ServerControllers,
  req: TypedRequest<
    CreateCommentReactionRequestBody,
    any,
    CreateCommentReactionRequestParams
  >,
  res: TypedResponse<CreateCommentReactionResponse>,
) => {
  const { user, address } = req;
  const {
    // @ts-expect-error StrictNullChecks
    reaction,
    // @ts-expect-error StrictNullChecks
    canvas_action: canvasAction,
    // @ts-expect-error StrictNullChecks
    canvas_session: canvasSession,
    // @ts-expect-error StrictNullChecks
    canvas_hash: canvasHash,
  } = req.body;

  if (!reaction) {
    throw new AppError(Errors.InvalidReaction);
  }

  // @ts-expect-error StrictNullChecks
  const commentId = parseInt(req.params.id, 10);
  if (!commentId) {
    throw new AppError(Errors.InvalidCommentId);
  }

  if (config.ENFORCE_SESSION_KEYS) {
    await verifyReaction(canvasAction, canvasSession, canvasHash, {
      comment_id: commentId,
      // @ts-expect-error StrictNullChecks
      address: address.address,
      value: reaction,
    });
  }

  // create comment reaction
  const [newReaction, notificationOptions, analyticsOptions] =
    await controllers.comments.createCommentReaction({
      // @ts-expect-error StrictNullChecks
      user,
      // @ts-expect-error StrictNullChecks
      address,
      reaction,
      commentId,
      canvasAction,
      canvasSession,
      canvasHash,
    });

  // emit notifications
  for (const n of notificationOptions) {
    controllers.notifications.emit(n).catch(console.error);
  }

  // track analytics events
  for (const a of analyticsOptions) {
    controllers.analytics.track(a, req).catch(console.error);
  }

  return success(res, newReaction);
};

1	import { AppError } from '@hicommonwealth/core';
2	import { ReactionAttributes } from '@hicommonwealth/model';
3	import { verifyReaction } from '../../../shared/canvas/serverVerify';
4	import { config } from '../../config';
5	import { ServerControllers } from '../../routing/router';
6	import { TypedRequest, TypedResponse, success } from '../../types';
7
8	const Errors = {
9	InvalidReaction: 'Invalid reaction',
10	InvalidCommentId: 'Invalid comment ID',
11	};
12
13	type CreateCommentReactionRequestParams = { id: string };
14	type CreateCommentReactionRequestBody = {	22✔
15	reaction: string;
16	canvas_action?: any;
17	canvas_session?: any;
18	canvas_hash?: any;
19	};
20	type CreateCommentReactionResponse = ReactionAttributes;
21
22	export const createCommentReactionHandler = async (
23	controllers: ServerControllers,	22✔
24	req: TypedRequest<
25	CreateCommentReactionRequestBody,
26	any,
27	CreateCommentReactionRequestParams
28	>,
29	res: TypedResponse<CreateCommentReactionResponse>,
30	) => {
31	const { user, address } = req;
32	const {	2✔
33	// @ts-expect-error StrictNullChecks
34	reaction,	2✔
35	// @ts-expect-error StrictNullChecks
36	canvas_action: canvasAction,	2!
37	// @ts-expect-error StrictNullChecks
38	canvas_session: canvasSession,
39	// @ts-expect-error StrictNullChecks
40	canvas_hash: canvasHash,
41	} = req.body;	2✔
42		2!
UNCOV 43	if (!reaction) {	×
44	throw new AppError(Errors.InvalidReaction);
45	}
46		2✔
47	// @ts-expect-error StrictNullChecks
48	const commentId = parseInt(req.params.id, 10);
49	if (!commentId) {	×
50	throw new AppError(Errors.InvalidCommentId);
51	}
52
53	if (config.ENFORCE_SESSION_KEYS) {	×
54	await verifyReaction(canvasAction, canvasSession, canvasHash, {
55	comment_id: commentId,	2!
56	// @ts-expect-error StrictNullChecks	2✔
57	address: address.address,	2✔
58	value: reaction,
59	});	2!
60	}
61
62	// create comment reaction
63	const [newReaction, notificationOptions, analyticsOptions] =
64	await controllers.comments.createCommentReaction({
65	// @ts-expect-error StrictNullChecks	×
66	user,
67	// @ts-expect-error StrictNullChecks
68	address,
69	reaction,
70	commentId,
71	canvasAction,
72	canvasSession,
73	canvasHash,
74	});
75
76	// emit notifications
77	for (const n of notificationOptions) {
78	controllers.notifications.emit(n).catch(console.error);
79	}
80
81	// track analytics events	2✔
82	for (const a of analyticsOptions) {
83	controllers.analytics.track(a, req).catch(console.error);
84	}	2✔
85		2✔
86	return success(res, newReaction);
87	};

hicommonwealth / commonwealth / 9645834835

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous