9634531412

Committed 23 Jun 2024 03:24PM UTC coverage: 87.373% (-0.5%) from 87.828%

Build # 9634531412

Build Type

Pull #1202

github

Committed by

web-flow

Commit Message

Merge dfecf0262 into 355949326

Pull Request Pull Request #1202: Refactor Signup Method: Signup Flow and Shift Structure

Run Details

2907 of 3299 branches covered (88.12%)

Branch coverage included in aggregate %.

1160 of 1406 new or added lines in 53 files covered. (82.5%)

1 existing line in 1 file now uncovered.

11361 of 13031 relevant lines covered (87.18%)

0.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.58

/ephios/plugins/baseshiftstructures/structure/group_common.py

from django import forms
from django.core.exceptions import ValidationError
from django.utils.translation import gettext_lazy as _
from django_select2.forms import Select2Widget

from ephios.core.models import Qualification
from ephios.core.signup.structure.base import (
    BaseShiftStructure,
    BaseShiftStructureConfigurationForm,
)
from ephios.plugins.baseshiftstructures.structure.common import MinimumAgeConfigForm


def format_min_max_count(min_count, max_count):
    if not max_count:
        return f"{min_count}+"
    if min_count == max_count:
        return f"{min_count}"
    return f"{min_count}-{max_count}"


class BaseGroupBasedShiftStructure(BaseShiftStructure):

    def get_signup_stats(self):
        from ephios.core.signup.stats import SignupStats

        participations = list(self.shift.participations.all())
        return SignupStats.reduce(self._get_signup_stats_per_group(participations).values())

    def _get_signup_stats_per_group(self, participations):
        raise NotImplementedError


class AbstractGroupBasedStructureConfigurationForm(
    MinimumAgeConfigForm, BaseShiftStructureConfigurationForm
):
    formset_data_field_name = None

    def get_formset_class(self):
        raise NotImplementedError

    def _clean_formset_data(self):
        if not self.formset.is_valid():
            raise ValidationError(
                _("{field_label} aren't configured correctly.").format(
                    field_label=self.fields[self.formset_data_field_name].label
                )
            )
        data = [
            {key: value for key, value in cleaned_data.items() if key != "DELETE"}
            for cleaned_data in self.formset.cleaned_data
            if cleaned_data and not cleaned_data.get("DELETE")
        ]
        return data

    def __init__(self, data=None, **kwargs):
        super().__init__(data, **kwargs)
        self.formset = self.get_formset_class()(
            data=data,
            initial=self.initial.get(self.formset_data_field_name, []),
            prefix=self.formset_data_field_name,
        )
        setattr(self, f"clean_{self.formset_data_field_name}", self._clean_formset_data)

    @classmethod
    def format_formset_item(cls, item):
        raise NotImplementedError

    @classmethod
    def _format_formset_data_field(cls, value):
        return ", ".join(cls.format_formset_item(item) for item in value)

    def __init_subclass__(cls):
        super().__init_subclass__()
        setattr(cls, f"format_{cls.formset_data_field_name}", cls._format_formset_data_field)


class QualificationRequirementForm(forms.Form):
    qualification = forms.ModelChoiceField(
        label=_("Required Qualification"),
        queryset=Qualification.objects.all(),
        widget=Select2Widget,
        required=False,
    )
    min_count = forms.IntegerField(label=_("min amount"), min_value=0, required=True)
    max_count = forms.IntegerField(label=_("max amount"), min_value=1, required=False)

    def clean_max_count(self):
        if (
            self.cleaned_data["max_count"]
            and self.cleaned_data["max_count"] < self.cleaned_data["min_count"]
        ):
            raise ValidationError(_("Max count must not be smaller than min count."))
        return self.cleaned_data["max_count"]

1	from django import forms	1✔
2	from django.core.exceptions import ValidationError	1✔
3	from django.utils.translation import gettext_lazy as _	1✔
4	from django_select2.forms import Select2Widget	1✔
5
6	from ephios.core.models import Qualification	1✔
7	from ephios.core.signup.structure.base import (	1✔
8	BaseShiftStructure,
9	BaseShiftStructureConfigurationForm,
10	)
11	from ephios.plugins.baseshiftstructures.structure.common import MinimumAgeConfigForm	1✔
12
13
14	def format_min_max_count(min_count, max_count):	1✔
15	if not max_count:	1!
NEW 16	return f"{min_count}+"	×
17	if min_count == max_count:	1!
18	return f"{min_count}"	1✔
NEW 19	return f"{min_count}-{max_count}"	×
20
21
22	class BaseGroupBasedShiftStructure(BaseShiftStructure):	1✔
23
24	def get_signup_stats(self):	1✔
25	from ephios.core.signup.stats import SignupStats	1✔
26
27	participations = list(self.shift.participations.all())	1✔
28	return SignupStats.reduce(self._get_signup_stats_per_group(participations).values())	1✔
29
30	def _get_signup_stats_per_group(self, participations):	1✔
NEW 31	raise NotImplementedError	×
32
33
34	class AbstractGroupBasedStructureConfigurationForm(	1✔
35	MinimumAgeConfigForm, BaseShiftStructureConfigurationForm
36	):
37	formset_data_field_name = None	1✔
38
39	def get_formset_class(self):	1✔
NEW 40	raise NotImplementedError	×
41
42	def _clean_formset_data(self):	1✔
43	if not self.formset.is_valid():	1!
NEW 44	raise ValidationError(	×
45	_("{field_label} aren't configured correctly.").format(
46	field_label=self.fields[self.formset_data_field_name].label
47	)
48	)
49	data = [	1✔
50	{key: value for key, value in cleaned_data.items() if key != "DELETE"}
51	for cleaned_data in self.formset.cleaned_data
52	if cleaned_data and not cleaned_data.get("DELETE")
53	]
54	return data	1✔
55
56	def __init__(self, data=None, **kwargs):	1✔
57	super().__init__(data, **kwargs)	1✔
58	self.formset = self.get_formset_class()(	1✔
59	data=data,
60	initial=self.initial.get(self.formset_data_field_name, []),
61	prefix=self.formset_data_field_name,
62	)
63	setattr(self, f"clean_{self.formset_data_field_name}", self._clean_formset_data)	1✔
64
65	@classmethod	1✔
66	def format_formset_item(cls, item):	1✔
NEW 67	raise NotImplementedError	×
68
69	@classmethod	1✔
70	def _format_formset_data_field(cls, value):	1✔
71	return ", ".join(cls.format_formset_item(item) for item in value)	1✔
72
73	def __init_subclass__(cls):	1✔
74	super().__init_subclass__()	1✔
75	setattr(cls, f"format_{cls.formset_data_field_name}", cls._format_formset_data_field)	1✔
76
77
78	class QualificationRequirementForm(forms.Form):	1✔
79	qualification = forms.ModelChoiceField(	1✔
80	label=_("Required Qualification"),
81	queryset=Qualification.objects.all(),
82	widget=Select2Widget,
83	required=False,
84	)
85	min_count = forms.IntegerField(label=_("min amount"), min_value=0, required=True)	1✔
86	max_count = forms.IntegerField(label=_("max amount"), min_value=1, required=False)	1✔
87
88	def clean_max_count(self):	1✔
89	if (	1!
90	self.cleaned_data["max_count"]
91	and self.cleaned_data["max_count"] < self.cleaned_data["min_count"]
92	):
NEW 93	raise ValidationError(_("Max count must not be smaller than min count."))	×
94	return self.cleaned_data["max_count"]	1✔

ephios-dev / ephios / 9634531412

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous