9611883624

Committed 21 Jun 2024 10:04AM UTC coverage: 64.664% (+0.02%) from 64.64%

Build # 9611883624

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #14360 from rgacogne/auth-fix-distributor-unit-test-leak

auth: Better fix for the leak reported by LSAN in test-distributor_hh.cc

Run Details

37201 of 88260 branches covered (42.15%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

17 existing lines in 6 files now uncovered.

124640 of 162019 relevant lines covered (76.93%)

5054845.34 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.8

/modules/godbcbackend/sodbc.cc

/*
 * This file is part of PowerDNS or dnsdist.
 * Copyright -- PowerDNS.COM B.V. and its contributors
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * In addition, for the avoidance of any doubt, permission is granted to
 * link this program with OpenSSL and to (re)distribute the binaries
 * produced as the result of such linking.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
#include "pdns/logger.hh"
#include "pdns/utility.hh"
#include <sstream>
#include "sodbc.hh"
#include <string.h>

static bool realTestResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message, std::string& errorMessage)
{
  // cerr<<"result = "<<result<<endl;
  if (result == SQL_SUCCESS || result == SQL_SUCCESS_WITH_INFO)
    return true;

  ostringstream errmsg;

  errmsg << message << ": ";

  if (result != SQL_ERROR && result != SQL_SUCCESS_WITH_INFO) {
    cerr << "handle " << handle << " got result " << result << endl;
    errmsg << "SQL function returned " << result << ", no additional information available" << endl;
    errorMessage = errmsg.str();
    return false;
  }

  SQLINTEGER i = 0;
  SQLINTEGER native;
  SQLCHAR state[7];
  SQLCHAR text[256];
  SQLSMALLINT len;
  SQLRETURN ret;

  do {
    // cerr<<"getting sql diag record "<<i<<endl;
    ret = SQLGetDiagRec(type, handle, ++i, state, &native, text,
                        sizeof(text), &len);
    // cerr<<"getdiagrec said "<<ret<<endl;
    if (SQL_SUCCEEDED(ret)) { // cerr<<"got it"<<endl;
      errmsg << state << i << native << text << "/";
    }
  } while (ret == SQL_SUCCESS);
  errorMessage = errmsg.str();
  return false;
}

class SODBCStatement : public SSqlStatement
{
public:
  SODBCStatement(const string& query, bool dolog, int nparams, SQLHDBC connection)
  {
    d_query = query;
    d_conn = connection;
    d_dolog = dolog;
    d_residx = 0;
    d_paridx = 0;
    d_result = SQL_NO_DATA;
    d_statement = NULL;
    d_prepared = false;
    m_columncount = 0;
    d_parnum = nparams;
  }

  struct ODBCParam
  {
    SQLPOINTER ParameterValuePtr;
    SQLLEN* LenPtr;
    SQLSMALLINT ParameterType;
    SQLSMALLINT ValueType;
  };

  vector<ODBCParam> d_req_bind;

  SSqlStatement* bind(const string& /* name */, ODBCParam& p)
  {
    prepareStatement();
    d_req_bind.push_back(p);
    SQLLEN ColumnSize = (p.ParameterType == SQL_VARCHAR) ? *(p.LenPtr) : 0;
    SQLRETURN result = SQLBindParameter(
      d_statement, // StatementHandle,
      d_paridx + 1, // ParameterNumber,
      SQL_PARAM_INPUT, // InputOutputType,
      p.ValueType, // ValueType,
      p.ParameterType, // ParameterType,
      ColumnSize, // ColumnSize,
      0, // DecimalDigits,
      p.ParameterValuePtr, // ParameterValuePtr,
      0, // BufferLength,
      p.LenPtr // StrLen_or_IndPtr
    );
    testResult(result, SQL_HANDLE_STMT, d_statement, "Could not bind parameter.");
    d_paridx++;

    return this;
  }

  SSqlStatement* bind(const string& name, bool value) override
  {
    prepareStatement();
    return bind(name, (uint32_t)value);
  }

  SSqlStatement* bind(const string& name, long value) override
  {
    prepareStatement();
    return bind(name, (unsigned long)value);
  }

  SSqlStatement* bind(const string& name, int value) override
  {
    prepareStatement();
    return bind(name, (uint32_t)value);
  }

  SSqlStatement* bind(const string& name, long long value) override
  {
    prepareStatement();
    return bind(name, (unsigned long long)value);
  }

  SSqlStatement* bind(const string& name, uint32_t value) override
  {
    prepareStatement();
    ODBCParam p;
    p.ParameterValuePtr = new UDWORD{value};
    p.LenPtr = new SQLLEN{sizeof(UDWORD)};
    p.ParameterType = SQL_INTEGER;
    p.ValueType = SQL_INTEGER;
    return bind(name, p);
  }

  SSqlStatement* bind(const string& name, unsigned long value) override
  {
    prepareStatement();
    ODBCParam p;
    p.ParameterValuePtr = new ULONG{value};
    p.LenPtr = new SQLLEN{sizeof(ULONG)};
    p.ParameterType = SQL_INTEGER;
    p.ValueType = SQL_INTEGER;
    return bind(name, p);
  }

  SSqlStatement* bind(const string& name, unsigned long long value) override
  {
    prepareStatement();
    ODBCParam p;
    p.ParameterValuePtr = new unsigned long long{value};
    p.LenPtr = new SQLLEN{sizeof(unsigned long long)};
    p.ParameterType = SQL_BIGINT;
    p.ValueType = SQL_C_UBIGINT;
    return bind(name, p);
  }

  SSqlStatement* bind(const string& name, const std::string& value) override
  {

    // cerr<<"asked to bind string "<<value<<endl;

    if (d_req_bind.size() > (d_parnum + 1))
      throw SSqlException("Trying to bind too many parameters.");
    prepareStatement();
    ODBCParam p;

    p.ParameterValuePtr = (char*)new char[value.size() + 1];
    value.copy((char*)p.ParameterValuePtr, value.size());
    ((char*)p.ParameterValuePtr)[value.size()] = 0;
    p.LenPtr = new SQLLEN;
    *(p.LenPtr) = value.size();
    p.ParameterType = SQL_VARCHAR;
    p.ValueType = SQL_C_CHAR;

    return bind(name, p);
  }

  SSqlStatement* bindNull(const string& name) override
  {
    if (d_req_bind.size() > (d_parnum + 1))
      throw SSqlException("Trying to bind too many parameters.");

    prepareStatement();
    ODBCParam p;

    p.ParameterValuePtr = NULL;
    p.LenPtr = new SQLLEN;
    *(p.LenPtr) = SQL_NULL_DATA;
    p.ParameterType = SQL_VARCHAR;
    p.ValueType = SQL_C_CHAR;

    return bind(name, p);
  }

  SSqlStatement* execute() override
  {
    prepareStatement();
    SQLRETURN result;
    // cerr<<"execute("<<d_query<<")"<<endl;
    if (d_dolog) {
      g_log << Logger::Warning << "Query: " << d_query << endl;
    }

    result = SQLExecute(d_statement);
    if (result != SQL_NO_DATA) // odbc+sqlite returns this on 'no rows updated'
      testResult(result, SQL_HANDLE_STMT, d_statement, "Could not execute query (" + d_query + ").");

    // Determine the number of columns.
    result = SQLNumResultCols(d_statement, &m_columncount);
    testResult(result, SQL_HANDLE_STMT, d_statement, "Could not determine the number of columns.");
    // cerr<<"got "<<m_columncount<<" columns"<<endl;

    if (m_columncount) {
      // cerr<<"first SQLFetch"<<endl;
      d_result = SQLFetch(d_statement);
      // cerr<<"first SQLFetch done, d_result="<<d_result<<endl;
    }
    else
      d_result = SQL_NO_DATA;

    if (d_result != SQL_NO_DATA)
      testResult(d_result, SQL_HANDLE_STMT, d_statement, "Could not do first SQLFetch for (" + d_query + ").");
    return this;
  }

  bool hasNextRow() override
  {
    // cerr<<"hasNextRow d_result="<<d_result<<endl;
    return d_result != SQL_NO_DATA;
  }
  SSqlStatement* nextRow(row_t& row) override;

  SSqlStatement* getResult(result_t& result) override
  {
    result.clear();
    // if (d_res == NULL) return this;
    row_t row;
    while (hasNextRow()) {
      nextRow(row);
      result.push_back(row);
    }
    return this;
  }

  SSqlStatement* reset() override
  {
    SQLCloseCursor(d_statement); // hack, this probably violates some state transitions

    for (auto& i : d_req_bind) {
      if (i.ParameterType == SQL_VARCHAR)
        delete[](char*) i.ParameterValuePtr;
      else if (i.ParameterType == SQL_INTEGER)
        delete (ULONG*)i.ParameterValuePtr;
      else if (i.ParameterType == SQL_C_UBIGINT)
        delete (unsigned long long*)i.ParameterValuePtr;
      delete i.LenPtr;
    }
    d_req_bind.clear();
    d_residx = 0;
    d_paridx = 0;
    return this;
  }
  const std::string& getQuery() override { return d_query; }

  ~SODBCStatement() override
  {
    releaseStatement();
  }

private:
  void testResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message)
  {
    std::string errorMessage;
    if (!realTestResult(result, type, handle, message, errorMessage)) {
      releaseStatement();
      throw SSqlException(errorMessage);
    }
  }

  void releaseStatement()
  {
    reset();
    if (d_statement != NULL)
      SQLFreeHandle(SQL_HANDLE_STMT, d_statement);
    d_prepared = false;
  }

  void prepareStatement()
  {
    if (d_prepared)
      return;

    SQLRETURN result;

    // Allocate statement handle.
    result = SQLAllocHandle(SQL_HANDLE_STMT, d_conn, &d_statement);
    testResult(result, SQL_HANDLE_DBC, d_conn, "Could not allocate a statement handle.");

    result = SQLPrepare(d_statement, (SQLCHAR*)d_query.c_str(), SQL_NTS);
    testResult(result, SQL_HANDLE_STMT, d_statement, "Could not prepare query.");

    SQLSMALLINT paramcount;
    result = SQLNumParams(d_statement, &paramcount);
    testResult(result, SQL_HANDLE_STMT, d_statement, "Could not get parameter count.");

    if (paramcount != static_cast<SQLSMALLINT>(d_parnum)) {
      releaseStatement();
      throw SSqlException("Provided parameter count does not match statement: " + d_query);
    }

    // cerr<<"prepared ("<<query<<")"<<endl;
    d_prepared = true;
  }

  string d_query;
  bool d_dolog;
  bool d_prepared;
  int d_residx;
  size_t d_paridx, d_parnum;
  SQLRETURN d_result;

  SQLHDBC d_conn;
  SQLHSTMT d_statement; //!< Database statement handle.

  //! Column type.
  struct column_t
  {
    SQLSMALLINT m_type; //!< Type of the column.
    SQLULEN m_size; //!< Column size.
    SQLPOINTER m_pData; //!< Pointer to the memory where to store the data.
    bool m_canBeNull; //!< Can this column be null?
  };

  //! Column info.
  SQLSMALLINT m_columncount;
};

SSqlStatement* SODBCStatement::nextRow(row_t& row)
{
  SQLRETURN result;

  row.clear();

  result = d_result;
  // cerr<<"at start of nextRow, previous SQLFetch result is "<<result<<endl;
  // FIXME handle errors (SQL_NO_DATA==100, anything other than the two SUCCESS options below is bad news)
  if (result == SQL_SUCCESS || result == SQL_SUCCESS_WITH_INFO) {
    // cerr<<"got row"<<endl;
    // We've got a data row, now lets get the results.
    for (int i = 0; i < m_columncount; i++) {
      SQLLEN len;
      SQLCHAR coldata[128 * 1024];
      std::string strres = "";
      result = SQLGetData(d_statement, i + 1, SQL_C_CHAR, (SQLPOINTER)coldata, sizeof(coldata), &len);
      testResult(result, SQL_HANDLE_STMT, d_statement, "Could not get data.");
      if (len > SQL_NULL_DATA)
        strres = std::string(reinterpret_cast<const char*>(coldata), std::min<SQLLEN>(sizeof(coldata) - 1, len)); // do not use nil byte
      row.push_back(strres);
    }

    // Done!
    d_residx++;
    // cerr<<"SQLFetch"<<endl;
    d_result = SQLFetch(d_statement);
    // cerr<<"subsequent SQLFetch done, d_result="<<d_result<<endl;
    if (d_result == SQL_NO_DATA) {
      SQLRETURN result2 = SQLMoreResults(d_statement);
      // cerr<<"SQLMoreResults done, result="<<d_result2<<endl;
      if (result2 == SQL_NO_DATA) {
        d_result = result2;
      }
      else {
        testResult(result2, SQL_HANDLE_STMT, d_statement, "Could not fetch next result set for (" + d_query + ").");
        d_result = SQLFetch(d_statement);
      }
    }
    testResult(result, SQL_HANDLE_STMT, d_statement, "Could not do subsequent SQLFetch for (" + d_query + ").");

    return this;
  }

  SQLFreeStmt(d_statement, SQL_CLOSE);
  throw SSqlException("Should not get here.");
}

// Constructor.
SODBC::SODBC(
  const std::string& dsn,
  const std::string& username,
  const std::string& password)
{
  SQLRETURN result;

  // Allocate an environment handle.
  result = SQLAllocHandle(SQL_HANDLE_ENV, SQL_NULL_HANDLE, &m_environment);
  testResult(result, SQL_NULL_HANDLE, NULL, "Could not allocate an environment handle.");

  // Set ODBC version. (IEUW!)
  result = SQLSetEnvAttr(m_environment, SQL_ATTR_ODBC_VERSION, reinterpret_cast<void*>(SQL_OV_ODBC3), 0);
  testResult(result, SQL_HANDLE_ENV, m_environment, "Could not set the ODBC version.");

  // Allocate connection handle.
  result = SQLAllocHandle(SQL_HANDLE_DBC, m_environment, &m_connection);
  testResult(result, SQL_HANDLE_ENV, m_environment, "Could not allocate a connection handle.");

  // Connect to the database.
  char* l_dsn = strdup(dsn.c_str());
  char* l_username = strdup(username.c_str());
  char* l_password = strdup(password.c_str());

  result = SQLConnect(m_connection,
                      reinterpret_cast<SQLTCHAR*>(l_dsn), dsn.length(),
                      reinterpret_cast<SQLTCHAR*>(l_username), username.length(),
                      reinterpret_cast<SQLTCHAR*>(l_password), password.length());

  free(l_dsn);
  free(l_username);
  free(l_password);

  testResult(result, SQL_HANDLE_DBC, m_connection, "Could not connect to ODBC datasource.");

  m_busy = false;
  m_log = false;
}

// Destructor.
SODBC::~SODBC()
{
  // Disconnect from database and free all used resources.
  // SQLFreeHandle( SQL_HANDLE_STMT, m_statement );

  SQLDisconnect(m_connection);

  SQLFreeHandle(SQL_HANDLE_DBC, m_connection);
  SQLFreeHandle(SQL_HANDLE_ENV, m_environment);

  // Free all allocated column memory.
  // for ( int i = 0; i < m_columnInfo.size(); i++ )
  // {
  //   if ( m_columnInfo[ i ].m_pData )
  //     delete m_columnInfo[ i ].m_pData;
  // }
}

// Executes a command.
void SODBC::execute(const std::string& command)
{
  SODBCStatement stmt(command, m_log, 0, m_connection);

  stmt.execute()->reset();
}

// Sets the log state.
void SODBC::setLog(bool state)
{
  m_log = state;
}

// Returns an exception.
SSqlException SODBC::sPerrorException(const std::string& reason)
{
  return SSqlException(reason);
}

std::unique_ptr<SSqlStatement> SODBC::prepare(const string& query, int nparams)
{
  return std::make_unique<SODBCStatement>(query, m_log, nparams, m_connection);
}

void SODBC::startTransaction()
{
  // cerr<<"starting transaction"<<endl;
  SQLRETURN result;
  result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);
  testResult(result, SQL_HANDLE_DBC, m_connection, "startTransaction (enable autocommit) failed");
}

void SODBC::commit()
{
  // cerr<<"commit!"<<endl;
  SQLRETURN result;

  result = SQLEndTran(SQL_HANDLE_DBC, m_connection, SQL_COMMIT); // don't really need this, AUTOCOMMIT_OFF below will also commit
  testResult(result, SQL_HANDLE_DBC, m_connection, "commit failed");

  result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);
  testResult(result, SQL_HANDLE_DBC, m_connection, "disabling autocommit after commit failed");
}

void SODBC::rollback()
{
  // cerr<<"rollback!"<<endl;
  SQLRETURN result;

  result = SQLEndTran(SQL_HANDLE_DBC, m_connection, SQL_ROLLBACK);
  testResult(result, SQL_HANDLE_DBC, m_connection, "rollback failed");

  result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);
  testResult(result, SQL_HANDLE_DBC, m_connection, "disabling autocommit after rollback failed");
}

void SODBC::testResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message)
{
  std::string errorMessage;
  if (!realTestResult(result, type, handle, message, errorMessage))
    throw SSqlException(errorMessage);
}

1	/*
2	* This file is part of PowerDNS or dnsdist.
3	* Copyright -- PowerDNS.COM B.V. and its contributors
4	*
5	* This program is free software; you can redistribute it and/or modify
6	* it under the terms of version 2 of the GNU General Public License as
7	* published by the Free Software Foundation.
8	*
9	* In addition, for the avoidance of any doubt, permission is granted to
10	* link this program with OpenSSL and to (re)distribute the binaries
11	* produced as the result of such linking.
12	*
13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.
17	*
18	* You should have received a copy of the GNU General Public License
19	* along with this program; if not, write to the Free Software
20	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21	*/
22	#include "pdns/logger.hh"
23	#include "pdns/utility.hh"
24	#include <sstream>
25	#include "sodbc.hh"
26	#include <string.h>
27
28	static bool realTestResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message, std::string& errorMessage)
29	{	1,699,187✔
30	// cerr<<"result = "<<result<<endl;
31	if (result == SQL_SUCCESS \|\| result == SQL_SUCCESS_WITH_INFO)	1,699,187!
32	return true;	1,699,187✔
33
34	ostringstream errmsg;	×
35
36	errmsg << message << ": ";	×
37
38	if (result != SQL_ERROR && result != SQL_SUCCESS_WITH_INFO) {	×
39	cerr << "handle " << handle << " got result " << result << endl;	×
40	errmsg << "SQL function returned " << result << ", no additional information available" << endl;	×
41	errorMessage = errmsg.str();	×
42	return false;	×
43	}	×
44
45	SQLINTEGER i = 0;	×
46	SQLINTEGER native;	×
47	SQLCHAR state[7];	×
48	SQLCHAR text[256];	×
49	SQLSMALLINT len;	×
50	SQLRETURN ret;	×
51
52	do {	×
53	// cerr<<"getting sql diag record "<<i<<endl;
54	ret = SQLGetDiagRec(type, handle, ++i, state, &native, text,	×
55	sizeof(text), &len);	×
56	// cerr<<"getdiagrec said "<<ret<<endl;
57	if (SQL_SUCCEEDED(ret)) { // cerr<<"got it"<<endl;	×
58	errmsg << state << i << native << text << "/";	×
59	}	×
60	} while (ret == SQL_SUCCESS);	×
61	errorMessage = errmsg.str();	×
62	return false;	×
63	}	×
64
65	class SODBCStatement : public SSqlStatement
66	{
67	public:
68	SODBCStatement(const string& query, bool dolog, int nparams, SQLHDBC connection)
69	{	51,606✔
70	d_query = query;	51,606✔
71	d_conn = connection;	51,606✔
72	d_dolog = dolog;	51,606✔
73	d_residx = 0;	51,606✔
74	d_paridx = 0;	51,606✔
75	d_result = SQL_NO_DATA;	51,606✔
76	d_statement = NULL;	51,606✔
77	d_prepared = false;	51,606✔
78	m_columncount = 0;	51,606✔
79	d_parnum = nparams;	51,606✔
80	}	51,606✔
81
82	struct ODBCParam
83	{
84	SQLPOINTER ParameterValuePtr;
85	SQLLEN* LenPtr;
86	SQLSMALLINT ParameterType;
87	SQLSMALLINT ValueType;
88	};
89
90	vector<ODBCParam> d_req_bind;
91
92	SSqlStatement* bind(const string& /* name */, ODBCParam& p)
93	{	263,400✔
94	prepareStatement();	263,400✔
95	d_req_bind.push_back(p);	263,400✔
96	SQLLEN ColumnSize = (p.ParameterType == SQL_VARCHAR) ? *(p.LenPtr) : 0;	263,400✔
97	SQLRETURN result = SQLBindParameter(	263,400✔
98	d_statement, // StatementHandle,	263,400✔
99	d_paridx + 1, // ParameterNumber,	263,400✔
100	SQL_PARAM_INPUT, // InputOutputType,	263,400✔
101	p.ValueType, // ValueType,	263,400✔
102	p.ParameterType, // ParameterType,	263,400✔
103	ColumnSize, // ColumnSize,	263,400✔
104	0, // DecimalDigits,	263,400✔
105	p.ParameterValuePtr, // ParameterValuePtr,	263,400✔
106	0, // BufferLength,	263,400✔
107	p.LenPtr // StrLen_or_IndPtr	263,400✔
108	);	263,400✔
109	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not bind parameter.");	263,400✔
110	d_paridx++;	263,400✔
111
112	return this;	263,400✔
113	}	263,400✔
114
115	SSqlStatement* bind(const string& name, bool value) override
116	{	61,551✔
117	prepareStatement();	61,551✔
118	return bind(name, (uint32_t)value);	61,551✔
119	}	61,551✔
120
121	SSqlStatement* bind(const string& name, long value) override
122	{	×
123	prepareStatement();	×
124	return bind(name, (unsigned long)value);	×
125	}	×
126
127	SSqlStatement* bind(const string& name, int value) override
128	{	2,152✔
129	prepareStatement();	2,152✔
130	return bind(name, (uint32_t)value);	2,152✔
131	}	2,152✔
132
133	SSqlStatement* bind(const string& name, long long value) override
134	{	×
135	prepareStatement();	×
136	return bind(name, (unsigned long long)value);	×
137	}	×
138
139	SSqlStatement* bind(const string& name, uint32_t value) override
140	{	131,158✔
141	prepareStatement();	131,158✔
142	ODBCParam p;	131,158✔
143	p.ParameterValuePtr = new UDWORD{value};	131,158✔
144	p.LenPtr = new SQLLEN{sizeof(UDWORD)};	131,158✔
145	p.ParameterType = SQL_INTEGER;	131,158✔
146	p.ValueType = SQL_INTEGER;	131,158✔
147	return bind(name, p);	131,158✔
148	}	131,158✔
149
150	SSqlStatement* bind(const string& name, unsigned long value) override
151	{	×
152	prepareStatement();	×
153	ODBCParam p;	×
154	p.ParameterValuePtr = new ULONG{value};	×
155	p.LenPtr = new SQLLEN{sizeof(ULONG)};	×
156	p.ParameterType = SQL_INTEGER;	×
157	p.ValueType = SQL_INTEGER;	×
158	return bind(name, p);	×
159	}	×
160
161	SSqlStatement* bind(const string& name, unsigned long long value) override
162	{	×
163	prepareStatement();	×
164	ODBCParam p;	×
165	p.ParameterValuePtr = new unsigned long long{value};	×
166	p.LenPtr = new SQLLEN{sizeof(unsigned long long)};	×
167	p.ParameterType = SQL_BIGINT;	×
168	p.ValueType = SQL_C_UBIGINT;	×
169	return bind(name, p);	×
170	}	×
171
172	SSqlStatement* bind(const string& name, const std::string& value) override
173	{	132,014✔
174
175	// cerr<<"asked to bind string "<<value<<endl;
176
177	if (d_req_bind.size() > (d_parnum + 1))	132,014!
178	throw SSqlException("Trying to bind too many parameters.");	×
179	prepareStatement();	132,014✔
180	ODBCParam p;	132,014✔
181
182	p.ParameterValuePtr = (char*)new char[value.size() + 1];	132,014✔
183	value.copy((char*)p.ParameterValuePtr, value.size());	132,014✔
184	((char*)p.ParameterValuePtr)[value.size()] = 0;	132,014✔
185	p.LenPtr = new SQLLEN;	132,014✔
186	*(p.LenPtr) = value.size();	132,014✔
187	p.ParameterType = SQL_VARCHAR;	132,014✔
188	p.ValueType = SQL_C_CHAR;	132,014✔
189
190	return bind(name, p);	132,014✔
191	}	132,014✔
192
193	SSqlStatement* bindNull(const string& name) override
194	{	228✔
195	if (d_req_bind.size() > (d_parnum + 1))	228!
196	throw SSqlException("Trying to bind too many parameters.");	×
197
198	prepareStatement();	228✔
199	ODBCParam p;	228✔
200
201	p.ParameterValuePtr = NULL;	228✔
202	p.LenPtr = new SQLLEN;	228✔
203	*(p.LenPtr) = SQL_NULL_DATA;	228✔
204	p.ParameterType = SQL_VARCHAR;	228✔
205	p.ValueType = SQL_C_CHAR;	228✔
206
207	return bind(name, p);	228✔
208	}	228✔
209
210	SSqlStatement* execute() override
211	{	70,999✔
212	prepareStatement();	70,999✔
213	SQLRETURN result;	70,999✔
214	// cerr<<"execute("<<d_query<<")"<<endl;
215	if (d_dolog) {	70,999!
216	g_log << Logger::Warning << "Query: " << d_query << endl;	×
217	}	×
218
219	result = SQLExecute(d_statement);	70,999✔
220	if (result != SQL_NO_DATA) // odbc+sqlite returns this on 'no rows updated'	70,999✔
221	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not execute query (" + d_query + ").");	70,998✔
222
223	// Determine the number of columns.
224	result = SQLNumResultCols(d_statement, &m_columncount);	70,999✔
225	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not determine the number of columns.");	70,999✔
226	// cerr<<"got "<<m_columncount<<" columns"<<endl;
227
228	if (m_columncount) {	70,999✔
229	// cerr<<"first SQLFetch"<<endl;
230	d_result = SQLFetch(d_statement);	9,292✔
231	// cerr<<"first SQLFetch done, d_result="<<d_result<<endl;
232	}	9,292✔
233	else	61,707✔
234	d_result = SQL_NO_DATA;	61,707✔
235
236	if (d_result != SQL_NO_DATA)	70,999✔
237	testResult(d_result, SQL_HANDLE_STMT, d_statement, "Could not do first SQLFetch for (" + d_query + ").");	8,132✔
238	return this;	70,999✔
239	}	70,999✔
240
241	bool hasNextRow() override
242	{	142,083✔
243	// cerr<<"hasNextRow d_result="<<d_result<<endl;
244	return d_result != SQL_NO_DATA;	142,083✔
245	}	142,083✔
246	SSqlStatement* nextRow(row_t& row) override;
247
248	SSqlStatement* getResult(result_t& result) override
249	{	173✔
250	result.clear();	173✔
251	// if (d_res == NULL) return this;
252	row_t row;	173✔
253	while (hasNextRow()) {	346✔
254	nextRow(row);	173✔
255	result.push_back(row);	173✔
256	}	173✔
257	return this;	173✔
258	}	173✔
259
260	SSqlStatement* reset() override
261	{	119,440✔
262	SQLCloseCursor(d_statement); // hack, this probably violates some state transitions	119,440✔
263
264	for (auto& i : d_req_bind) {	266,275✔
265	if (i.ParameterType == SQL_VARCHAR)	263,400✔
266	delete[](char*) i.ParameterValuePtr;	132,242✔
267	else if (i.ParameterType == SQL_INTEGER)	131,158!
268	delete (ULONG*)i.ParameterValuePtr;	131,158✔
UNCOV 269	else if (i.ParameterType == SQL_C_UBIGINT)	×
270	delete (unsigned long long*)i.ParameterValuePtr;	×
271	delete i.LenPtr;	263,400✔
272	}	263,400✔
273	d_req_bind.clear();	119,440✔
274	d_residx = 0;	119,440✔
275	d_paridx = 0;	119,440✔
276	return this;	119,440✔
277	}	119,440✔
278	const std::string& getQuery() override { return d_query; }	×
279
280	~SODBCStatement() override
281	{	48,441✔
282	releaseStatement();	48,441✔
283	}	48,441✔
284
285	private:
286	void testResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message)
287	{	1,695,543✔
288	std::string errorMessage;	1,695,543✔
289	if (!realTestResult(result, type, handle, message, errorMessage)) {	1,695,543!
290	releaseStatement();	×
291	throw SSqlException(errorMessage);	×
292	}	×
293	}	1,695,543✔
294
295	void releaseStatement()
296	{	48,441✔
297	reset();	48,441✔
298	if (d_statement != NULL)	48,441✔
299	SQLFreeHandle(SQL_HANDLE_STMT, d_statement);	1,616✔
300	d_prepared = false;	48,441✔
301	}	48,441✔
302
303	void prepareStatement()
304	{	661,502✔
305	if (d_prepared)	661,502✔
306	return;	659,688✔
307
308	SQLRETURN result;	1,814✔
309
310	// Allocate statement handle.
311	result = SQLAllocHandle(SQL_HANDLE_STMT, d_conn, &d_statement);	1,814✔
312	testResult(result, SQL_HANDLE_DBC, d_conn, "Could not allocate a statement handle.");	1,814✔
313
314	result = SQLPrepare(d_statement, (SQLCHAR*)d_query.c_str(), SQL_NTS);	1,814✔
315	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not prepare query.");	1,814✔
316
317	SQLSMALLINT paramcount;	1,814✔
318	result = SQLNumParams(d_statement, &paramcount);	1,814✔
319	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not get parameter count.");	1,814✔
320
321	if (paramcount != static_cast<SQLSMALLINT>(d_parnum)) {	1,814!
322	releaseStatement();	×
323	throw SSqlException("Provided parameter count does not match statement: " + d_query);	×
324	}	×
325
326	// cerr<<"prepared ("<<query<<")"<<endl;
327	d_prepared = true;	1,814✔
328	}	1,814✔
329
330	string d_query;
331	bool d_dolog;
332	bool d_prepared;
333	int d_residx;
334	size_t d_paridx, d_parnum;
335	SQLRETURN d_result;
336
337	SQLHDBC d_conn;
338	SQLHSTMT d_statement; //!< Database statement handle.
339
340	//! Column type.
341	struct column_t
342	{
343	SQLSMALLINT m_type; //!< Type of the column.
344	SQLULEN m_size; //!< Column size.
345	SQLPOINTER m_pData; //!< Pointer to the memory where to store the data.
346	bool m_canBeNull; //!< Can this column be null?
347	};
348
349	//! Column info.
350	SQLSMALLINT m_columncount;
351	};
352
353	SSqlStatement* SODBCStatement::nextRow(row_t& row)
354	{	132,791✔
355	SQLRETURN result;	132,791✔
356
357	row.clear();	132,791✔
358
359	result = d_result;	132,791✔
360	// cerr<<"at start of nextRow, previous SQLFetch result is "<<result<<endl;
361	// FIXME handle errors (SQL_NO_DATA==100, anything other than the two SUCCESS options below is bad news)
362	if (result == SQL_SUCCESS \|\| result == SQL_SUCCESS_WITH_INFO) {	132,791!
363	// cerr<<"got row"<<endl;
364	// We've got a data row, now lets get the results.
365	for (int i = 0; i < m_columncount; i++) {	1,276,572✔
366	SQLLEN len;	1,143,781✔
367	SQLCHAR coldata[128 * 1024];	1,143,781✔
368	std::string strres = "";	1,143,781✔
369	result = SQLGetData(d_statement, i + 1, SQL_C_CHAR, (SQLPOINTER)coldata, sizeof(coldata), &len);	1,143,781✔
370	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not get data.");	1,143,781✔
371	if (len > SQL_NULL_DATA)	1,143,781✔
372	strres = std::string(reinterpret_cast<const char*>(coldata), std::min<SQLLEN>(sizeof(coldata) - 1, len)); // do not use nil byte	1,017,672✔
373	row.push_back(strres);	1,143,781✔
374	}	1,143,781✔
375
376	// Done!
377	d_residx++;	132,791✔
378	// cerr<<"SQLFetch"<<endl;
379	d_result = SQLFetch(d_statement);	132,791✔
380	// cerr<<"subsequent SQLFetch done, d_result="<<d_result<<endl;
381	if (d_result == SQL_NO_DATA) {	132,791✔
382	SQLRETURN result2 = SQLMoreResults(d_statement);	8,132✔
383	// cerr<<"SQLMoreResults done, result="<<d_result2<<endl;
384	if (result2 == SQL_NO_DATA) {	8,132!
385	d_result = result2;	8,132✔
386	}	8,132✔
387	else {	×
388	testResult(result2, SQL_HANDLE_STMT, d_statement, "Could not fetch next result set for (" + d_query + ").");	×
389	d_result = SQLFetch(d_statement);	×
390	}	×
391	}	8,132✔
392	testResult(result, SQL_HANDLE_STMT, d_statement, "Could not do subsequent SQLFetch for (" + d_query + ").");	132,791✔
393
394	return this;	132,791✔
395	}	132,791✔
396
397	SQLFreeStmt(d_statement, SQL_CLOSE);	×
398	throw SSqlException("Should not get here.");	×
399	}	132,791✔
400
401	// Constructor.
402	SODBC::SODBC(
403	const std::string& dsn,
404	const std::string& username,
405	const std::string& password)
406	{	782✔
407	SQLRETURN result;	782✔
408
409	// Allocate an environment handle.
410	result = SQLAllocHandle(SQL_HANDLE_ENV, SQL_NULL_HANDLE, &m_environment);	782✔
411	testResult(result, SQL_NULL_HANDLE, NULL, "Could not allocate an environment handle.");	782✔
412
413	// Set ODBC version. (IEUW!)
414	result = SQLSetEnvAttr(m_environment, SQL_ATTR_ODBC_VERSION, reinterpret_cast<void*>(SQL_OV_ODBC3), 0);	782✔
415	testResult(result, SQL_HANDLE_ENV, m_environment, "Could not set the ODBC version.");	782✔
416
417	// Allocate connection handle.
418	result = SQLAllocHandle(SQL_HANDLE_DBC, m_environment, &m_connection);	782✔
419	testResult(result, SQL_HANDLE_ENV, m_environment, "Could not allocate a connection handle.");	782✔
420
421	// Connect to the database.
422	char* l_dsn = strdup(dsn.c_str());	782✔
423	char* l_username = strdup(username.c_str());	782✔
424	char* l_password = strdup(password.c_str());	782✔
425
426	result = SQLConnect(m_connection,	782✔
427	reinterpret_cast<SQLTCHAR*>(l_dsn), dsn.length(),	782✔
428	reinterpret_cast<SQLTCHAR*>(l_username), username.length(),	782✔
429	reinterpret_cast<SQLTCHAR*>(l_password), password.length());	782✔
430
431	free(l_dsn);	782✔
432	free(l_username);	782✔
433	free(l_password);	782✔
434
435	testResult(result, SQL_HANDLE_DBC, m_connection, "Could not connect to ODBC datasource.");	782✔
436
437	m_busy = false;	782✔
438	m_log = false;	782✔
439	}	782✔
440
441	// Destructor.
442	SODBC::~SODBC()
443	{	734✔
444	// Disconnect from database and free all used resources.
445	// SQLFreeHandle( SQL_HANDLE_STMT, m_statement );
446
447	SQLDisconnect(m_connection);	734✔
448
449	SQLFreeHandle(SQL_HANDLE_DBC, m_connection);	734✔
450	SQLFreeHandle(SQL_HANDLE_ENV, m_environment);	734✔
451
452	// Free all allocated column memory.
453	// for ( int i = 0; i < m_columnInfo.size(); i++ )
454	// {
455	// if ( m_columnInfo[ i ].m_pData )
456	// delete m_columnInfo[ i ].m_pData;
457	// }
458	}	734✔
459
460	// Executes a command.
461	void SODBC::execute(const std::string& command)
462	{	×
463	SODBCStatement stmt(command, m_log, 0, m_connection);	×
464
465	stmt.execute()->reset();	×
466	}	×
467
468	// Sets the log state.
469	void SODBC::setLog(bool state)
470	{	782✔
471	m_log = state;	782✔
472	}	782✔
473
474	// Returns an exception.
475	SSqlException SODBC::sPerrorException(const std::string& reason)
476	{	×
477	return SSqlException(reason);	×
478	}	×
479
480	std::unique_ptr<SSqlStatement> SODBC::prepare(const string& query, int nparams)
481	{	51,608✔
482	return std::make_unique<SODBCStatement>(query, m_log, nparams, m_connection);	51,608✔
483	}	51,608✔
484
485	void SODBC::startTransaction()
486	{	172✔
487	// cerr<<"starting transaction"<<endl;
488	SQLRETURN result;	172✔
489	result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);	172✔
490	testResult(result, SQL_HANDLE_DBC, m_connection, "startTransaction (enable autocommit) failed");	172✔
491	}	172✔
492
493	void SODBC::commit()
494	{	172✔
495	// cerr<<"commit!"<<endl;
496	SQLRETURN result;	172✔
497
498	result = SQLEndTran(SQL_HANDLE_DBC, m_connection, SQL_COMMIT); // don't really need this, AUTOCOMMIT_OFF below will also commit	172✔
499	testResult(result, SQL_HANDLE_DBC, m_connection, "commit failed");	172✔
500
501	result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);	172✔
502	testResult(result, SQL_HANDLE_DBC, m_connection, "disabling autocommit after commit failed");	172✔
503	}	172✔
504
505	void SODBC::rollback()
506	{	×
507	// cerr<<"rollback!"<<endl;
508	SQLRETURN result;	×
509
510	result = SQLEndTran(SQL_HANDLE_DBC, m_connection, SQL_ROLLBACK);	×
511	testResult(result, SQL_HANDLE_DBC, m_connection, "rollback failed");	×
512
513	result = SQLSetConnectAttr(m_connection, SQL_ATTR_AUTOCOMMIT, SQL_AUTOCOMMIT_OFF, 0);	×
514	testResult(result, SQL_HANDLE_DBC, m_connection, "disabling autocommit after rollback failed");	×
515	}	×
516
517	void SODBC::testResult(SQLRETURN result, SQLSMALLINT type, SQLHANDLE handle, const std::string& message)
518	{	3,644✔
519	std::string errorMessage;	3,644✔
520	if (!realTestResult(result, type, handle, message, errorMessage))	3,644!
521	throw SSqlException(errorMessage);	×
522	}	3,644✔

PowerDNS / pdns / 9611883624

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous