openSUSE / agama / 9597041213

push

github

feat: unify progress handling (#1356)

Trello:
https://trello.com/c/Miuvai6N/3706-5-better-progress-report-during-installation

The main goal of this PR is to implement a better mechanism for
displaying progress in the web UI. It takes the product selection
progress as inspiration but eliminates hardcoded values.

## Progress API problem

When we designed the initial progress API, Agama was quite different.
While working on this PR, we have identified a relevant problem: there
is no way to have a subprogress in the same service.

The manager service defines the main steps (e.g., "Probing Software")
and the details are just the progress from software and storage services
(e.g., "Refreshing repositories metadata").

As a consequence, we cannot have a detailed "Configuring system" step at
the end of the installation with its details (e.g., "Writing users").
You can only have either 1) a "Configuring system" with no details or
several separate steps, which is too much.

In general, we are telling people that they can use the WS to track the
progress, so we should decide on a stable API as soon as possible.

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

60 of 68 new or added lines in 12 files covered. (88.24%)

18889 of 26569 relevant lines covered (71.09%)

34.38 hits per line