9575546497

Committed 19 Jun 2024 03:12AM UTC coverage: 15.14% (+0.006%) from 15.134%

Build # 9575546497

Build Type

push

github

Committed by

web-flow

Commit Message

One-off contest fixes (#8170)

* fix FE bug

* prevent actions for ended one-off contests

* fix one-off score

* rollover for one-off contests

Run Details

3752 of 24351 branches covered (15.41%)

Branch coverage included in aggregate %.

3 of 20 new or added lines in 4 files covered. (15.0%)

1 existing line in 1 file now uncovered.

5184 of 34673 relevant lines covered (14.95%)

4.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

6.45

/libs/model/src/contest/PerformContestRollovers.command.ts

import { logger, type Command } from '@hicommonwealth/core';
import * as schemas from '@hicommonwealth/schemas';
import { QueryTypes } from 'sequelize';
import { fileURLToPath } from 'url';
import { models } from '../database';
import { rollOverContest } from '../services/commonProtocol/contestHelper';

const __filename = fileURLToPath(import.meta.url);
const log = logger(__filename);

export function PerformContestRollovers(): Command<
  typeof schemas.PerformContestRollovers
> {
  return {
    ...schemas.PerformContestRollovers,
    auth: [],
    body: async () => {
      const contestManagersWithEndedContest = await models.sequelize.query<{
        contest_address: string;
        interval: number;
        ended: boolean;
        url: string;
      }>(
        `
          SELECT
            cm.contest_address,
            cm.interval,
            cm.ended,
            co.end_time,
            COALESCE(cn.private_url, cn.url) as url
          FROM "ContestManagers" cm
          JOIN (
              SELECT *
              FROM "Contests"
              WHERE (contest_address, contest_id) IN (
                  SELECT contest_address, MAX(contest_id) AS contest_id
                  FROM "Contests"
                  GROUP BY contest_address
              )
          ) co ON co.contest_address = cm.contest_address
          AND (
            cm.interval = 0 AND cm.ended IS NOT TRUE
            OR
            cm.interval > 0
          )
          AND NOW() > co.end_time
          AND cm.cancelled = false
          JOIN "Communities" cu ON cm.community_id = cu.id
          JOIN "ChainNodes" cn ON cu.chain_node_id = cn.id;
        `,
        {
          type: QueryTypes.SELECT,
          raw: true,
        },
      );

      const contestRolloverPromises = contestManagersWithEndedContest.map(
        async ({ url, contest_address, interval, ended }) => {
          log.debug(`ROLLOVER: ${contest_address}`);

          if (interval === 0 && !ended) {
            // preemptively mark as ended so that rollover
            // is not attempted again after failure
            await models.ContestManager.update(
              {
                ended: true,
              },
              {
                where: {
                  contest_address,
                },
              },
            );
          }

          return rollOverContest(url, contest_address, interval === 0);
        },
      );

      const promiseResults = await Promise.allSettled(contestRolloverPromises);

      const errors = promiseResults
        .filter(({ status }) => status === 'rejected')
        .map(
          (result) =>
            (result as PromiseRejectedResult).reason || '<unknown reason>',
        );

      if (errors.length > 0) {
        log.warn(
          `GetAllContests performContestRollovers: failed with errors: ${errors.join(
            ', ',
          )}"`,
        );
      }
    },
  };
}

1	import { logger, type Command } from '@hicommonwealth/core';
2	import * as schemas from '@hicommonwealth/schemas';
3	import { QueryTypes } from 'sequelize';
4	import { fileURLToPath } from 'url';
5	import { models } from '../database';
6	import { rollOverContest } from '../services/commonProtocol/contestHelper';
7
8	const __filename = fileURLToPath(import.meta.url);	12✔
9	const log = logger(__filename);	12✔
10
11	export function PerformContestRollovers(): Command<
12	typeof schemas.PerformContestRollovers
13	> {
NEW 14	return {	×
15	...schemas.PerformContestRollovers,
16	auth: [],
17	body: async () => {
NEW 18	const contestManagersWithEndedContest = await models.sequelize.query<{	×
19	contest_address: string;
20	interval: number;
21	ended: boolean;
22	url: string;
23	}>(
24	`
25	SELECT
26	cm.contest_address,
27	cm.interval,
28	cm.ended,
29	co.end_time,
30	COALESCE(cn.private_url, cn.url) as url
31	FROM "ContestManagers" cm
32	JOIN (
33	SELECT *
34	FROM "Contests"
35	WHERE (contest_address, contest_id) IN (
36	SELECT contest_address, MAX(contest_id) AS contest_id
37	FROM "Contests"
38	GROUP BY contest_address
39	)
40	) co ON co.contest_address = cm.contest_address
41	AND (
42	cm.interval = 0 AND cm.ended IS NOT TRUE
43	OR
44	cm.interval > 0
45	)
46	AND NOW() > co.end_time
47	AND cm.cancelled = false
48	JOIN "Communities" cu ON cm.community_id = cu.id
49	JOIN "ChainNodes" cn ON cu.chain_node_id = cn.id;
50	`,
51	{
52	type: QueryTypes.SELECT,
53	raw: true,
54	},
55	);
56
NEW 57	const contestRolloverPromises = contestManagersWithEndedContest.map(	×
58	async ({ url, contest_address, interval, ended }) => {
NEW 59	log.debug(`ROLLOVER: ${contest_address}`);	×
60
NEW 61	if (interval === 0 && !ended) {	×
62	// preemptively mark as ended so that rollover
63	// is not attempted again after failure
NEW 64	await models.ContestManager.update(	×
65	{
66	ended: true,
67	},
68	{
69	where: {
70	contest_address,
71	},
72	},
73	);
74	}
75
NEW 76	return rollOverContest(url, contest_address, interval === 0);	×
77	},
78	);
79
NEW 80	const promiseResults = await Promise.allSettled(contestRolloverPromises);	×
81
NEW 82	const errors = promiseResults	×
NEW 83	.filter(({ status }) => status === 'rejected')	×
84	.map(
85	(result) =>
NEW 86	(result as PromiseRejectedResult).reason \|\| '<unknown reason>',	×
87	);
88
NEW 89	if (errors.length > 0) {	×
NEW 90	log.warn(	×
91	`GetAllContests performContestRollovers: failed with errors: ${errors.join(
92	', ',
93	)}"`,
94	);
95	}
96	},
97	};
98	}

hicommonwealth / commonwealth / 9575546497

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous