9507171717

Committed 13 Jun 2024 09:43PM UTC coverage: 31.906% (+0.05%) from 31.858%

Build # 9507171717

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9399 from ForumMagnum/mark-comments-read-status

update readstatus lastUpdated when users interact with comments in subscribed feed

Run Details

4816 of 39334 branches covered (12.24%)

Branch coverage included in aggregate %.

1 of 18 new or added lines in 4 files covered. (5.56%)

2 existing lines in 2 files now uncovered.

27996 of 63506 relevant lines covered (44.08%)

180.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

9.76

/packages/lesswrong/components/recentDiscussion/useRecentDiscussionThread.ts

import { useCallback, useState } from "react";
import { useRecordPostView } from "../hooks/useRecordPostView";
import { ThreadableCommentType, unflattenComments } from "../../lib/utils/unflatten";
import type { CommentTreeOptions } from "../comments/commentTree";

export const useRecentDiscussionThread = <T extends ThreadableCommentType>({
  post,
  comments,
  refetch,
  commentTreeOptions = {},
  initialExpandAllThreads,
}: {
  post: PostsRecentDiscussion,
  comments?: T[],
  refetch: () => void,
  commentTreeOptions?: CommentTreeOptions,
  initialExpandAllThreads?: boolean,
}) => {
  const [highlightVisible, setHighlightVisible] = useState(false);
  const [markedAsVisitedAt, setMarkedAsVisitedAt] = useState<Date|null>(null);
  const [expandAllThreads, setExpandAllThreads] = useState(initialExpandAllThreads ?? false);
  const {recordPostView, recordPostCommentsView} = useRecordPostView(post);

  const markAsRead = useCallback(
    () => {
      setMarkedAsVisitedAt(new Date());
      setExpandAllThreads(true);
      void recordPostView({post, extraEventProperties: {type: "recentDiscussionClick"}, recommendationOptions: {skip: true}})
    },
    [setMarkedAsVisitedAt, setExpandAllThreads, recordPostView, post],
  );
  const showHighlight = useCallback(
    () => {
      setHighlightVisible(!highlightVisible);
      markAsRead();
    },
    [setHighlightVisible, highlightVisible, markAsRead],
  );

  const markCommentsAsRead = useCallback(
    () => {
      setMarkedAsVisitedAt(new Date());
      void recordPostCommentsView({ post });
    },
    [recordPostCommentsView, post]
  );

  const lastCommentId = comments && comments[0]?._id;
  const nestedComments = unflattenComments<T>(comments ?? []);

  const lastVisitedAt = markedAsVisitedAt || post.lastVisitedAt

  // For posts that have never been commented on, we do want to show them in the
  // recent discussion feed. For posts which have been commented on, but the comments
  // have been deleted, we don't want to show them (these are usually spam).
  //
  // There is no completely reliable way to tell the difference, but this is a fairly conservative
  // (in favour of showing a post) heuristic.
  const probablyNeverCommentedOn =
    new Date(post.lastCommentedAt).getTime() - new Date(post.postedAt).getTime() < 30_000;

  // TODO verify whether/how this should be interacting with afCommentCount
  // New posts should render (to display their highlight).
  // Posts with at least one comment should only render if those comments
  // meet the frontpage filter requirements
  const isSkippable = comments && !comments.length && !probablyNeverCommentedOn;

  const treeOptions: CommentTreeOptions = {
    scrollOnExpand: true,
    lastCommentId: lastCommentId,
    highlightDate: lastVisitedAt ?? undefined,
    refetch: refetch,
    condensed: true,
    post,
    ...commentTreeOptions
  };

  return {
    isSkippable,
    showHighlight,
    markCommentsAsRead,
    expandAllThreads,
    lastVisitedAt,
    nestedComments,
    treeOptions,
  };
}

1	import { useCallback, useState } from "react";	3✔
2	import { useRecordPostView } from "../hooks/useRecordPostView";	1✔
3	import { ThreadableCommentType, unflattenComments } from "../../lib/utils/unflatten";	1✔
4	import type { CommentTreeOptions } from "../comments/commentTree";
5
6	export const useRecentDiscussionThread = <T extends ThreadableCommentType>({	1✔
7	post,
8	comments,
9	refetch,
10	commentTreeOptions = {},	×
11	initialExpandAllThreads,
12	}: {
13	post: PostsRecentDiscussion,
14	comments?: T[],
15	refetch: () => void,
16	commentTreeOptions?: CommentTreeOptions,
17	initialExpandAllThreads?: boolean,
18	}) => {
19	const [highlightVisible, setHighlightVisible] = useState(false);	×
20	const [markedAsVisitedAt, setMarkedAsVisitedAt] = useState<Date\|null>(null);	×
21	const [expandAllThreads, setExpandAllThreads] = useState(initialExpandAllThreads ?? false);	×
NEW 22	const {recordPostView, recordPostCommentsView} = useRecordPostView(post);	×
23
24	const markAsRead = useCallback(	×
25	() => {
26	setMarkedAsVisitedAt(new Date());	×
27	setExpandAllThreads(true);	×
28	void recordPostView({post, extraEventProperties: {type: "recentDiscussionClick"}, recommendationOptions: {skip: true}})	×
29	},
30	[setMarkedAsVisitedAt, setExpandAllThreads, recordPostView, post],
31	);
32	const showHighlight = useCallback(	×
33	() => {
34	setHighlightVisible(!highlightVisible);	×
35	markAsRead();	×
36	},
37	[setHighlightVisible, highlightVisible, markAsRead],
38	);
39
NEW 40	const markCommentsAsRead = useCallback(	×
41	() => {
NEW 42	setMarkedAsVisitedAt(new Date());	×
NEW 43	void recordPostCommentsView({ post });	×
44	},
45	[recordPostCommentsView, post]
46	);
47
48	const lastCommentId = comments && comments[0]?._id;	×
49	const nestedComments = unflattenComments<T>(comments ?? []);	×
50
51	const lastVisitedAt = markedAsVisitedAt \|\| post.lastVisitedAt	×
52
53	// For posts that have never been commented on, we do want to show them in the
54	// recent discussion feed. For posts which have been commented on, but the comments
55	// have been deleted, we don't want to show them (these are usually spam).
56	//
57	// There is no completely reliable way to tell the difference, but this is a fairly conservative
58	// (in favour of showing a post) heuristic.
59	const probablyNeverCommentedOn =
60	new Date(post.lastCommentedAt).getTime() - new Date(post.postedAt).getTime() < 30_000;	×
61
62	// TODO verify whether/how this should be interacting with afCommentCount
63	// New posts should render (to display their highlight).
64	// Posts with at least one comment should only render if those comments
65	// meet the frontpage filter requirements
66	const isSkippable = comments && !comments.length && !probablyNeverCommentedOn;	×
67
68	const treeOptions: CommentTreeOptions = {	×
69	scrollOnExpand: true,
70	lastCommentId: lastCommentId,
71	highlightDate: lastVisitedAt ?? undefined,	×
72	refetch: refetch,
73	condensed: true,
74	post,
75	...commentTreeOptions
76	};
77
78	return {	×
79	isSkippable,
80	showHighlight,
81	markCommentsAsRead,
82	expandAllThreads,
83	lastVisitedAt,
84	nestedComments,
85	treeOptions,
86	};
87	}

ForumMagnum / ForumMagnum / 9507171717

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous