openSUSE / agama / 9500564853

push

github

fix(zypp): Reuse the repositories, use libzypp in "chroot" (#1329)

## Problem

- When changing the product from openSUSE Tumleweed to openSUSE MicroOS
the Tumbleweed repository is refreshed again
- The code initializes the libzypp in the Live ISO system, there are
some workarounds to avoid reusing the Live ISO repositories

Related cards:
-
https://trello.com/c/liPX29Cu/3695-5-research-improve-software-management-performance
 

## Solution

- When the changed product uses the same repositories then just reuse
them, do not create the repositories again
- Run libzypp in `/run/agama/zypp` repository to not mess with the
package management from the Live ISO, removed the related workarounds

## Notes

- The reusing is simple all-or-nothing, i.e. the products must use the
very same repositories. In the future we could improve it to allow
reusing just a subset of the repositories.
- Maybe it will need some adoption when the system is registered, but as
there is no real product to register I'm leaving this for the future.
- I put the zypp lock to `/run/agama/zypp` as well, that means now you
can run `zypper` in the Live system while Agama is running, yay!
:star_struck:
- That workaround with switching `Yast::Stage` is not needed anymore, it
was needed when we run the proposal using the YaST code, it is not
needed with the new refactored code.

## Testing

- Tested manually (mvidner: in container, switched products 3 times,
without hitting Install)

1987 of 2868 branches covered (69.28%)

Branch coverage included in aggregate %.

14 of 15 new or added lines in 1 file covered. (93.33%)

18841 of 26525 relevant lines covered (71.03%)

34.39 hits per line